From: Daniel Vetter <daniel@ffwll.ch>
To: Sinclair Yeh <syeh@vmware.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>,
Thomas Hellstrom <thellstrom@vmware.com>,
David Airlie <airlied@linux.ie>,
daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org,
outreachy-kernel@googlegroups.com,
VMware Graphics <linux-graphics-maintainer@vmware.com>
Subject: Re: [PATCH DRM] drm/vmwgfx: replace drm_*_unreference with drm_*_put
Date: Tue, 13 Mar 2018 11:44:35 +0100 [thread overview]
Message-ID: <20180313104310.GA4788@phenom.ffwll.local> (raw)
In-Reply-To: <20180312174246.GA32341@vmware.com>
On Mon, Mar 12, 2018 at 10:42:47AM -0700, Sinclair Yeh wrote:
> Hi Daniel,
>
>
> On Mon, Mar 12, 2018 at 06:34:43PM +0100, Daniel Vetter wrote:
> > On Sun, Mar 11, 2018 at 05:33:13PM -0600, Haneen Mohammed wrote:
> > > This patch replace instances of drm_framebuffer_unreference with _put()
> > > suffix, because it is shorter and consistent with the kernel use of
> > > *_get/put() suffixes.
> > > This was done with the following Coccinelle script:
> > >
> > > @r@
> > > expression e;
> > > @@
> > >
> > > (
> > > -drm_framebuffer_reference(e);
> > > +drm_framebuffer_get(e);
> > > |
> > > -drm_framebuffer_unreference(e);
> > > +drm_framebuffer_put(e);
> > > )
> > >
> > > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Sinclair/Thomas: Ok if I pull this in through drm-misc? Makes outreachy
> > applicant book-keeping easier since iirc the vmwgfx tree isn't in
> > linux-next. But ok if you want to merge it too.
>
> Yes, drm-misc is fine.
Thanks, applied.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-03-13 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 23:33 [PATCH DRM] drm/vmwgfx: replace drm_*_unreference with drm_*_put Haneen Mohammed
2018-03-12 17:34 ` Daniel Vetter
2018-03-12 17:42 ` Sinclair Yeh
2018-03-13 10:44 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313104310.GA4788@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-graphics-maintainer@vmware.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=syeh@vmware.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox