dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Paul <seanpaul@chromium.org>
To: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	outreachy-kernel@googlegroups.com, daniel.vetter@intel.com,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH DRM] drm/zte: Replace include drmP.h with drm_print.h
Date: Wed, 21 Mar 2018 10:09:42 -0400	[thread overview]
Message-ID: <20180321140942.GT223881@art_vandelay> (raw)
In-Reply-To: <20180320114320.GA23062@haneen-VirtualBox>

On Tue, Mar 20, 2018 at 07:43:20AM -0400, Haneen Mohammed wrote:
> Remove drmP.h as it is not needed anymore since nothing it defines is
> used in these files and use drm_print.h instead as these files are using
> the debug macros defined there.
> 
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>

Thanks for the patch, Haneen, this lgtm.

Reviewed-by: Sean Paul <seanpaul@chromium.org>

> ---
>  drivers/gpu/drm/zte/zx_drm_drv.c | 2 +-
>  drivers/gpu/drm/zte/zx_hdmi.c    | 2 +-
>  drivers/gpu/drm/zte/zx_plane.c   | 2 +-
>  drivers/gpu/drm/zte/zx_tvenc.c   | 2 +-
>  drivers/gpu/drm/zte/zx_vga.c     | 2 +-
>  drivers/gpu/drm/zte/zx_vou.c     | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..f375cb0 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -24,7 +24,7 @@
>  #include <drm/drm_gem_cma_helper.h>
>  #include <drm/drm_gem_framebuffer_helper.h>
>  #include <drm/drm_of.h>
> -#include <drm/drmP.h>
> +#include <drm/drm_print.h>
>  
>  #include "zx_drm_drv.h"
>  #include "zx_vou.h"
> diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu/drm/zte/zx_hdmi.c
> index 13ea90f..4cc9ebd 100644
> --- a/drivers/gpu/drm/zte/zx_hdmi.c
> +++ b/drivers/gpu/drm/zte/zx_hdmi.c
> @@ -23,7 +23,7 @@
>  #include <drm/drm_crtc_helper.h>
>  #include <drm/drm_edid.h>
>  #include <drm/drm_of.h>
> -#include <drm/drmP.h>
> +#include <drm/drm_print.h>
>  
>  #include <sound/hdmi-codec.h>
>  
> diff --git a/drivers/gpu/drm/zte/zx_plane.c b/drivers/gpu/drm/zte/zx_plane.c
> index 68fd2e2..eeeea99 100644
> --- a/drivers/gpu/drm/zte/zx_plane.c
> +++ b/drivers/gpu/drm/zte/zx_plane.c
> @@ -14,7 +14,7 @@
>  #include <drm/drm_gem_cma_helper.h>
>  #include <drm/drm_modeset_helper_vtables.h>
>  #include <drm/drm_plane_helper.h>
> -#include <drm/drmP.h>
> +#include <drm/drm_print.h>
>  
>  #include "zx_common_regs.h"
>  #include "zx_drm_drv.h"
> diff --git a/drivers/gpu/drm/zte/zx_tvenc.c b/drivers/gpu/drm/zte/zx_tvenc.c
> index 0de1a71..355b7fb 100644
> --- a/drivers/gpu/drm/zte/zx_tvenc.c
> +++ b/drivers/gpu/drm/zte/zx_tvenc.c
> @@ -15,7 +15,7 @@
>  
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_crtc_helper.h>
> -#include <drm/drmP.h>
> +#include <drm/drm_print.h>
>  
>  #include "zx_drm_drv.h"
>  #include "zx_tvenc_regs.h"
> diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu/drm/zte/zx_vga.c
> index 3e7e33c..9d18e8a 100644
> --- a/drivers/gpu/drm/zte/zx_vga.c
> +++ b/drivers/gpu/drm/zte/zx_vga.c
> @@ -14,7 +14,7 @@
>  
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_crtc_helper.h>
> -#include <drm/drmP.h>
> +#include <drm/drm_print.h>
>  
>  #include "zx_drm_drv.h"
>  #include "zx_vga_regs.h"
> diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.c
> index 7491813..7f49c1f 100644
> --- a/drivers/gpu/drm/zte/zx_vou.c
> +++ b/drivers/gpu/drm/zte/zx_vou.c
> @@ -21,7 +21,7 @@
>  #include <drm/drm_gem_cma_helper.h>
>  #include <drm/drm_of.h>
>  #include <drm/drm_plane_helper.h>
> -#include <drm/drmP.h>
> +#include <drm/drm_print.h>
>  
>  #include "zx_common_regs.h"
>  #include "zx_drm_drv.h"
> -- 
> 2.7.4
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2018-03-21 14:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 11:43 [PATCH DRM] drm/zte: Replace include drmP.h with drm_print.h Haneen Mohammed
2018-03-21 14:09 ` Sean Paul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180321140942.GT223881@art_vandelay \
    --to=seanpaul@chromium.org \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox