From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH 09/10] drm/sun4i: Add a dedicated ioctl call for
 allocating tiled buffers
Date: Fri, 23 Mar 2018 11:48:57 +0100
Message-ID: <20180323104856.qo7w376xr3gcznmm@flea>
References: <20180321152904.22411-1-paul.kocialkowski@bootlin.com>
 <20180321152904.22411-10-paul.kocialkowski@bootlin.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54])
 by gabe.freedesktop.org (Postfix) with ESMTP id C920E6E1B0
 for <dri-devel@lists.freedesktop.org>; Fri, 23 Mar 2018 10:48:58 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20180321152904.22411-10-paul.kocialkowski@bootlin.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai <wens@csie.org>, Daniel Vetter <daniel.vetter@intel.com>, linux-arm-kernel@lists.infradead.org
List-Id: dri-devel@lists.freedesktop.org

SGksCgpPbiBXZWQsIE1hciAyMSwgMjAxOCBhdCAwNDoyOTowM1BNICswMTAwLCBQYXVsIEtvY2lh
bGtvd3NraSB3cm90ZToKPiBUaGlzIGludHJvZHVjZXMgYSBkZWRpY2F0ZWQgaW9jdGwgZm9yIGFs
bG9jYXRpbmcgdGlsZWQgYnVmZmVycyBpbiB0aGUKPiBBbGx3aW5uZXIgTUIzMiBmb3JtYXQsIHRo
YXQgY29tZXMgd2l0aCBhIGhhbmRmdWwgb2Ygc3BlY2lmaWMKPiBjb25zdHJhaW50cy4gSW4gcGFy
dGljdWxhciwgdGhlIHN0cmlkZSBvZiB0aGUgYnVmZmVycyBpcyBleHBlY3RlZCB0byBiZQo+IGFs
aWduZWQgdG8gMzIgYnl0ZXMuCgpZb3Ugc2hvdWxkIGhhdmUgbW9yZSBkZXRhaWxzIGhlcmUuIFdo
YXQgYXJlIHRob3NlIGNvbnN0cmFpbnRzLCB3aGF0IGlzCnRoZSBleHBlY3RlZCB1c2VyPyBDYW4g
eW91IHVzZSBpdCBvbmx5IGZvciB0aGUgc2Nhbm91dCwgbGlrZSB0aGUgZHVtYgpidWZmZXJzLCBv
ciBhbHNvIGZvciB0aGUgb3RoZXIgZGV2aWNlcyBpbiB0aGUgc3lzdGVtPwoKPiBTaWduZWQtb2Zm
LWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2NpYWxrb3dza2lAYm9vdGxpbi5jb20+Cj4g
LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV9kcnYuYyB8IDk2ICsrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3Vu
NGlfZHJ2LmggfCAgMiArCj4gIGluY2x1ZGUvdWFwaS9kcm0vc3VuNGlfZHJtLmggICAgICB8IDQy
ICsrKysrKysrKysrKysrKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwgMTQwIGluc2VydGlvbnMoKykK
PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvdWFwaS9kcm0vc3VuNGlfZHJtLmgKPiAKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5jIGIvZHJpdmVycy9n
cHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5jCj4gaW5kZXggZDM3NGJiNjFjNTY1Li5lOWNiMDNkMzRi
NDQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5jCj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5jCj4gQEAgLTIxLDExICsyMSwxOCBA
QAo+ICAjaW5jbHVkZSA8ZHJtL2RybV9nZW1fY21hX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJt
L2RybV9mYl9oZWxwZXIuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fb2YuaD4KPiArI2luY2x1ZGUg
PGRybS9zdW40aV9kcm0uaD4KPiAgCj4gICNpbmNsdWRlICJzdW40aV9kcnYuaCIKPiAgI2luY2x1
ZGUgInN1bjRpX2Zyb250ZW5kLmgiCj4gICNpbmNsdWRlICJzdW40aV9mcmFtZWJ1ZmZlci5oIgo+
ICAjaW5jbHVkZSAic3VuNGlfdGNvbi5oIgo+ICsjaW5jbHVkZSAic3VuNGlfZm9ybWF0LmgiCj4g
Kwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9pb2N0bF9kZXNjIHN1bjRpX2Rydl9pb2N0bHNb
XSA9IHsKPiArCURSTV9JT0NUTF9ERUZfRFJWKFNVTjRJX0dFTV9DUkVBVEVfVElMRUQsIGRybV9z
dW40aV9nZW1fY3JlYXRlX3RpbGVkLAo+ICsJCQkgIERSTV9BVVRIIHwgRFJNX1JFTkRFUl9BTExP
VyksCgpXaHkgZG8geW91IG5lZWQgRFJNX1JFTkRFUl9BTExPVz8gYXMgZmFyIGFzIEkga25vdywg
dGhpcyBpcyBvbmx5CnVzZWZ1bCBmb3IgcmVuZGVyLW5vZGVzLgoKPiArfTsKPiAgCj4gIERFRklO
RV9EUk1fR0VNX0NNQV9GT1BTKHN1bjRpX2Rydl9mb3BzKTsKPiAgCj4gQEAgLTM0LDYgKzQxLDgg
QEAgc3RhdGljIHN0cnVjdCBkcm1fZHJpdmVyIHN1bjRpX2Rydl9kcml2ZXIgPSB7Cj4gIAo+ICAJ
LyogR2VuZXJpYyBPcGVyYXRpb25zICovCj4gIAkubGFzdGNsb3NlCQk9IGRybV9mYl9oZWxwZXJf
bGFzdGNsb3NlLAo+ICsJLmlvY3RscwkJCT0gc3VuNGlfZHJ2X2lvY3RscywKPiArCS5udW1faW9j
dGxzCQk9IEFSUkFZX1NJWkUoc3VuNGlfZHJ2X2lvY3RscyksCj4gIAkuZm9wcwkJCT0gJnN1bjRp
X2Rydl9mb3BzLAo+ICAJLm5hbWUJCQk9ICJzdW40aS1kcm0iLAo+ICAJLmRlc2MJCQk9ICJBbGx3
aW5uZXIgc3VuNGkgRGlzcGxheSBFbmdpbmUiLAo+IEBAIC02OSw2ICs3OCw5MyBAQCBpbnQgZHJt
X3N1bjRpX2dlbV9kdW1iX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwKPiAgCXJl
dHVybiBkcm1fZ2VtX2NtYV9kdW1iX2NyZWF0ZV9pbnRlcm5hbChmaWxlX3ByaXYsIGRybSwgYXJn
cyk7Cj4gIH0KPiAgCj4gK2ludCBkcm1fc3VuNGlfZ2VtX2NyZWF0ZV90aWxlZChzdHJ1Y3QgZHJt
X2RldmljZSAqZHJtLCB2b2lkICpkYXRhLAo+ICsJCQkgICAgICAgc3RydWN0IGRybV9maWxlICpm
aWxlX3ByaXYpCj4gK3sKPiArCXN0cnVjdCBkcm1fc3VuNGlfZ2VtX2NyZWF0ZV90aWxlZCAqYXJn
cyA9IGRhdGE7Cj4gKwlzdHJ1Y3QgZHJtX2dlbV9jbWFfb2JqZWN0ICpjbWFfb2JqOwo+ICsJc3Ry
dWN0IGRybV9nZW1fb2JqZWN0ICpnZW1fb2JqOwo+ICsJdWludDMyX3QgbHVtYV9zdHJpZGUsIGNo
cm9tYV9zdHJpZGU7Cj4gKwl1aW50MzJfdCBsdW1hX2hlaWdodCwgY2hyb21hX2hlaWdodDsKPiAr
CWludCByZXQ7Cj4gKwo+ICsJaWYgKCFzdW40aV9mb3JtYXRfc3VwcG9ydHNfdGlsaW5nKGFyZ3Mt
PmZvcm1hdCkpCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICsJbWVtc2V0KGFyZ3MtPnBpdGNo
ZXMsIDAsIHNpemVvZihhcmdzLT5waXRjaGVzKSk7Cj4gKwltZW1zZXQoYXJncy0+b2Zmc2V0cywg
MCwgc2l6ZW9mKGFyZ3MtPm9mZnNldHMpKTsKPiArCj4gKwkvKiBTdHJpZGUgYW5kIGhlaWdodCBh
cmUgYWxpZ25lZCB0byAzMiBieXRlcyBmb3IgTUIzMiB0aWxlZCBmb3JtYXQuICovCj4gKwlsdW1h
X3N0cmlkZSA9IEFMSUdOKGFyZ3MtPndpZHRoLCAzMik7Cj4gKwlsdW1hX2hlaWdodCA9IEFMSUdO
KGFyZ3MtPmhlaWdodCwgMzIpOwo+ICsKPiArCWlmIChzdW40aV9mb3JtYXRfaXNfc2VtaXBsYW5h
cihhcmdzLT5mb3JtYXQpKSB7Cj4gKwkJY2hyb21hX3N0cmlkZSA9IGx1bWFfc3RyaWRlOwo+ICsK
PiArCQlpZiAoc3VuNGlfZm9ybWF0X2lzX3l1djQyMChhcmdzLT5mb3JtYXQpKQo+ICsJCQljaHJv
bWFfaGVpZ2h0ID0gQUxJR04oRElWX1JPVU5EX1VQKGFyZ3MtPmhlaWdodCwgMiksIDMyKTsKPiAr
CQllbHNlIGlmIChzdW40aV9mb3JtYXRfaXNfeXV2NDIyKGFyZ3MtPmZvcm1hdCkpCj4gKwkJCWNo
cm9tYV9oZWlnaHQgPSBsdW1hX2hlaWdodDsKPiArCQllbHNlCj4gKwkJCXJldHVybiAtRUlOVkFM
Owo+ICsKPiArCQlhcmdzLT5waXRjaGVzWzBdID0gbHVtYV9zdHJpZGU7Cj4gKwkJYXJncy0+cGl0
Y2hlc1sxXSA9IGNocm9tYV9zdHJpZGU7Cj4gKwo+ICsJCWFyZ3MtPm9mZnNldHNbMF0gPSAwOwo+
ICsJCWFyZ3MtPm9mZnNldHNbMV0gPSBsdW1hX3N0cmlkZSAqIGx1bWFfaGVpZ2h0Owo+ICsKPiAr
CQlhcmdzLT5zaXplID0gbHVtYV9zdHJpZGUgKiBsdW1hX2hlaWdodCArCj4gKwkJCSAgICAgY2hy
b21hX3N0cmlkZSAqIGNocm9tYV9oZWlnaHQ7Cj4gKwl9IGVsc2UgaWYgKHN1bjRpX2Zvcm1hdF9p
c19wbGFuYXIoYXJncy0+Zm9ybWF0KSkgewo+ICsJCWlmIChzdW40aV9mb3JtYXRfaXNfeXV2NDEx
KGFyZ3MtPmZvcm1hdCkpIHsKPiArCQkJY2hyb21hX3N0cmlkZSA9IEFMSUdOKERJVl9ST1VORF9V
UChhcmdzLT53aWR0aCwgNCksIDMyKTsKPiArCQkJY2hyb21hX2hlaWdodCA9IGx1bWFfaGVpZ2h0
Owo+ICsJCX0gaWYgKHN1bjRpX2Zvcm1hdF9pc195dXY0MjAoYXJncy0+Zm9ybWF0KSkgewo+ICsJ
CQljaHJvbWFfc3RyaWRlID0gQUxJR04oRElWX1JPVU5EX1VQKGFyZ3MtPndpZHRoLCAyKSwgMzIp
Owo+ICsJCQljaHJvbWFfaGVpZ2h0ID0gQUxJR04oRElWX1JPVU5EX1VQKGFyZ3MtPmhlaWdodCwg
MiksIDMyKTsKPiArCQl9IGVsc2UgaWYgKHN1bjRpX2Zvcm1hdF9pc195dXY0MjIoYXJncy0+Zm9y
bWF0KSkgewo+ICsJCQljaHJvbWFfc3RyaWRlID0gQUxJR04oRElWX1JPVU5EX1VQKGFyZ3MtPndp
ZHRoLCAyKSwgMzIpOwo+ICsJCQljaHJvbWFfaGVpZ2h0ID0gbHVtYV9oZWlnaHQ7Cj4gKwkJfSBl
bHNlIHsKPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwkJfQo+ICsKPiArCQlhcmdzLT5waXRjaGVz
WzBdID0gbHVtYV9zdHJpZGU7Cj4gKwkJYXJncy0+cGl0Y2hlc1sxXSA9IGNocm9tYV9zdHJpZGU7
Cj4gKwkJYXJncy0+cGl0Y2hlc1syXSA9IGNocm9tYV9zdHJpZGU7Cj4gKwo+ICsJCWFyZ3MtPm9m
ZnNldHNbMF0gPSAwOwo+ICsJCWFyZ3MtPm9mZnNldHNbMV0gPSBsdW1hX3N0cmlkZSAqIGx1bWFf
aGVpZ2h0Owo+ICsJCWFyZ3MtPm9mZnNldHNbMl0gPSBsdW1hX3N0cmlkZSAqIGx1bWFfaGVpZ2h0
ICsKPiArCQkJCSAgIGNocm9tYV9zdHJpZGUgKiBjaHJvbWFfaGVpZ2h0Owo+ICsKPiArCQlhcmdz
LT5zaXplID0gbHVtYV9zdHJpZGUgKiBsdW1hX2hlaWdodCArCj4gKwkJCSAgICAgY2hyb21hX3N0
cmlkZSAqIGNocm9tYV9oZWlnaHQgKiAyOwo+ICsJfSBlbHNlIHsKPiArCQkvKiBObyBzdXBwb3J0
IGZvciBwYWNrZWQgZm9ybWF0cyBpbiB0aWxlZCBtb2RlLiAqLwo+ICsJCXJldHVybiAtRUlOVkFM
Owo+ICsJfQo+ICsKPiArCWNtYV9vYmogPSBkcm1fZ2VtX2NtYV9jcmVhdGUoZHJtLCBhcmdzLT5z
aXplKTsKPiArCWlmIChJU19FUlIoY21hX29iaikpCj4gKwkJcmV0dXJuIFBUUl9FUlIoY21hX29i
aik7Cj4gKwo+ICsJZ2VtX29iaiA9ICZjbWFfb2JqLT5iYXNlOwo+ICsKPiArCS8qCj4gKwkgKiBh
bGxvY2F0ZSBhIGlkIG9mIGlkciB0YWJsZSB3aGVyZSB0aGUgb2JqIGlzIHJlZ2lzdGVyZWQKPiAr
CSAqIGFuZCBoYW5kbGUgaGFzIHRoZSBpZCB3aGF0IHVzZXIgY2FuIHNlZS4KPiArCSAqLwo+ICsJ
cmV0ID0gZHJtX2dlbV9oYW5kbGVfY3JlYXRlKGZpbGVfcHJpdiwgZ2VtX29iaiwgJmFyZ3MtPmhh
bmRsZSk7Cj4gKwkvKiBkcm9wIHJlZmVyZW5jZSBmcm9tIGFsbG9jYXRlIC0gaGFuZGxlIGhvbGRz
IGl0IG5vdy4gKi8KPiArCWRybV9nZW1fb2JqZWN0X3B1dF91bmxvY2tlZChnZW1fb2JqKTsKPiAr
CWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwlyZXR1cm4gUFRSX0VSUl9PUl9aRVJP
KGNtYV9vYmopOwo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBzdW40aV9yZW1vdmVfZnJhbWVidWZm
ZXJzKHZvaWQpCj4gIHsKPiAgCXN0cnVjdCBhcGVydHVyZXNfc3RydWN0ICphcDsKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJt
L3N1bjRpL3N1bjRpX2Rydi5oCj4gaW5kZXggNDc5Njk3MTFhODg5Li4zMDhmZjRiZmNkZDUgMTAw
NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5oCj4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5oCj4gQEAgLTI2LDUgKzI2LDcgQEAgc3RydWN0
IHN1bjRpX2RydiB7Cj4gIGludCBkcm1fc3VuNGlfZ2VtX2R1bWJfY3JlYXRlKHN0cnVjdCBkcm1f
ZmlsZSAqZmlsZV9wcml2LAo+ICAJCQkgICAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZHJtLAo+ICAJ
CQkgICAgICBzdHJ1Y3QgZHJtX21vZGVfY3JlYXRlX2R1bWIgKmFyZ3MpOwo+ICtpbnQgZHJtX3N1
bjRpX2dlbV9jcmVhdGVfdGlsZWQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwK
PiArCQkJICAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2KTsKCkRvIHlvdSBuZWVkIGl0
IHRvIGJlIG5vbi1zdGF0aWMsIGFuZCBwYXJ0IG9mIHRoZSBoZWFkZXIgYXMgd2VsbD8KCkknbGwg
bGV0IHRoZSBEUk0tbWlzYyBtYWludGFpbmVycyBjb21tZW50IG9uIHRoZSB2YWxpZGl0eSBvZiB0
aGUgbmV3CmlvY3RsLgoKTWF4aW1lCgotLSAKTWF4aW1lIFJpcGFyZCwgQm9vdGxpbiAoZm9ybWVy
bHkgRnJlZSBFbGVjdHJvbnMpCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcK
aHR0cHM6Ly9ib290bGluLmNvbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz
a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k
cmktZGV2ZWwK