From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 02/23] drm/atomic-helper: Make drm_atomic_helper_disable_all() update the plane->fb pointers Date: Mon, 26 Mar 2018 22:28:06 +0200 Message-ID: <20180326202806.GY14155@phenom.ffwll.local> References: <20180322152313.6561-1-ville.syrjala@linux.intel.com> <20180322152313.6561-3-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 500E36E4DE for ; Mon, 26 Mar 2018 20:28:11 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id f125so17748730wme.4 for ; Mon, 26 Mar 2018 13:28:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180322152313.6561-3-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville Syrjala Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXIgMjIsIDIwMTggYXQgMDU6MjI6NTJQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IGRybV9hdG9taWNfaGVscGVyX3NodXRkb3duKCkgbmVlZHMgdG8gcmVsZWFzZSB0 aGUgcmVmZXJlbmNlIGhlbGQgYnkKPiBwbGFuZS0+ZmIsIHNvIHdlIHdhbnQgdG8gdXNlIGRybV9h dG9taWNfY2xlYW5fb2xkX2ZiKCkgaW4KPiBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbCgp LiBIb3dldmVyIGR1cmluZyBzdXNwZW5kL3Jlc3VtZSwgZ3B1Cj4gcmVzZXQgYW5kIGxvYWQgZGV0 ZWN0aW9uIHdlIHNob3VsZCBwcm9iYWJseSBsZWF2ZSB0aGF0IHN0dWZmIGFsb25lLAo+IGFzIG90 aGVyd2lzZSB3ZSdkIGhhdmUgdG8gbWFrZSBzdXJlIHdlIHB1dCB0aGVtIGJhY2sgYWdhaW4gd2hl bgo+IHdlIHJlc3RvcmUgdGhlIGR1cGxpY2F0ZWQgc3RhdGUgdG8gdGhlIGRldmljZS4gU2VlbXMg c2ltcGxlciB0byBtZQo+IHRvIG5vdCB0b3VjaCBhbnkgb2YgaXQgYW55d2F5Lgo+IAo+IHYyOiBE b24ndCBpbmZsaWN0IHRoZSBjbGVhbl9vbGRfZmJzIGJvb2wgdG8gZHJpdmVycyAoRGFuaWVsKQo+ IAo+IENjOiBtYXJ0aW4ucGVyZXNAZnJlZS5mcgo+IENjOiBjaHJpc0BjaHJpcy13aWxzb24uY28u dWsKPiBDYzogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAZ21haWwuY29tPiAodjEpCj4gQ2M6IE1hYXJ0 ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IERh bmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gU2lnbmVkLW9mZi1ieTogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCkkgdGhpbmsgdGhp cyB3b3VsZCBiZSBjbGVhbmVyIGRpZmYgdG8gcmVhZCBpZiB5b3Ugc3F1YXNoIHRoZSBmaXJzdCAy CnBhdGNoZXMgdG9nZXRoZXIuIEFsc28gYXZvaWRzIHRoZSBiaXNlY3QgZmFpbC4gV2l0aCB0aGF0 IChhbmQgSSB0cnVzdCB5b3UKdG8gY29tZSB1cCB3aXRoIGEgc3VpdGFibHkgbWVyZ2VkIGNvbW1p dCBtZXNzYWdlKToKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZm d2xsLmNoPgoKSSByZXZpZXdlZCB0aGlzIGJ5IHJlLXJlYWRpbmcgdGhlIGFuYWx5c2lzIGZyb20g NDlkNzBhZWFlY2E4ZjYyYjcyYjc3IGFuZAp0cnVzdGluZyBteSBmb3JtZXIgc2VsZiA6LSkKCkNo ZWVycywgRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIu YyB8IDY3ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fYXRvbWljX2hlbHBlci5jCj4gaW5kZXggYzQ4ZjE4N2QwOGRlLi4zOWE2OTUwOGQ4YzkgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IEBAIC0yODgxLDMxICsyODgxLDkg QEAgaW50IF9fZHJtX2F0b21pY19oZWxwZXJfc2V0X2NvbmZpZyhzdHJ1Y3QgZHJtX21vZGVfc2V0 ICpzZXQsCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAtLyoqCj4gLSAqIGRybV9hdG9taWNfaGVs cGVyX2Rpc2FibGVfYWxsIC0gZGlzYWJsZSBhbGwgY3VycmVudGx5IGFjdGl2ZSBvdXRwdXRzCj4g LSAqIEBkZXY6IERSTSBkZXZpY2UKPiAtICogQGN0eDogbG9jayBhY3F1aXNpdGlvbiBjb250ZXh0 Cj4gLSAqCj4gLSAqIExvb3BzIHRocm91Z2ggYWxsIGNvbm5lY3RvcnMsIGZpbmRpbmcgdGhvc2Ug dGhhdCBhcmVuJ3QgdHVybmVkIG9mZiBhbmQgdGhlbgo+IC0gKiB0dXJucyB0aGVtIG9mZiBieSBz ZXR0aW5nIHRoZWlyIERQTVMgbW9kZSB0byBPRkYgYW5kIGRlYWN0aXZhdGluZyB0aGUgQ1JUQwo+ IC0gKiB0aGF0IHRoZXkgYXJlIGNvbm5lY3RlZCB0by4KPiAtICoKPiAtICogVGhpcyBpcyB1c2Vk IGZvciBleGFtcGxlIGluIHN1c3BlbmQvcmVzdW1lIHRvIGRpc2FibGUgYWxsIGN1cnJlbnRseSBh Y3RpdmUKPiAtICogZnVuY3Rpb25zIHdoZW4gc3VzcGVuZGluZy4gSWYgeW91IGp1c3Qgd2FudCB0 byBzaHV0IGRvd24gZXZlcnl0aGluZyBhdCBlLmcuCj4gLSAqIGRyaXZlciB1bmxvYWQsIGxvb2sg YXQgZHJtX2F0b21pY19oZWxwZXJfc2h1dGRvd24oKS4KPiAtICoKPiAtICogTm90ZSB0aGF0IGlm IGNhbGxlcnMgaGF2ZW4ndCBhbHJlYWR5IGFjcXVpcmVkIGFsbCBtb2Rlc2V0IGxvY2tzIHRoaXMg bWlnaHQKPiAtICogcmV0dXJuIC1FREVBRExLLCB3aGljaCBtdXN0IGJlIGhhbmRsZWQgYnkgY2Fs bGluZyBkcm1fbW9kZXNldF9iYWNrb2ZmKCkuCj4gLSAqCj4gLSAqIFJldHVybnM6Cj4gLSAqIDAg b24gc3VjY2VzcyBvciBhIG5lZ2F0aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZS4KPiAtICoKPiAt ICogU2VlIGFsc286Cj4gLSAqIGRybV9hdG9taWNfaGVscGVyX3N1c3BlbmQoKSwgZHJtX2F0b21p Y19oZWxwZXJfcmVzdW1lKCkgYW5kCj4gLSAqIGRybV9hdG9taWNfaGVscGVyX3NodXRkb3duKCku Cj4gLSAqLwo+IC1pbnQgZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwKPiAtCQkJCSAgc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4ICpjdHgp Cj4gK3N0YXRpYyBpbnQgX19kcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbChzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LAo+ICsJCQkJCSAgIHN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCAq Y3R4LAo+ICsJCQkJCSAgIGJvb2wgY2xlYW5fb2xkX2ZicykKPiAgewo+ICAJc3RydWN0IGRybV9h dG9taWNfc3RhdGUgKnN0YXRlOwo+ICAJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5f c3RhdGU7Cj4gQEAgLTI5MTQsNiArMjg5Miw3IEBAIGludCBkcm1fYXRvbWljX2hlbHBlcl9kaXNh YmxlX2FsbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJc3RydWN0IGRybV9wbGFuZSAqcGxh bmU7Cj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gIAlzdHJ1Y3QgZHJt X2NydGMgKmNydGM7Cj4gKwl1bnNpZ25lZCBpbnQgcGxhbmVfbWFzayA9IDA7Cj4gIAlpbnQgcmV0 LCBpOwo+ICAKPiAgCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+IEBAIC0y OTU2LDE0ICsyOTM1LDQ4IEBAIGludCBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbChzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCQlnb3RvIGZyZWU7Cj4gIAo+ICAJCWRybV9hdG9taWNf c2V0X2ZiX2Zvcl9wbGFuZShwbGFuZV9zdGF0ZSwgTlVMTCk7Cj4gKwo+ICsJCWlmIChjbGVhbl9v bGRfZmJzKSB7Cj4gKwkJCXBsYW5lLT5vbGRfZmIgPSBwbGFuZS0+ZmI7Cj4gKwkJCXBsYW5lX21h c2sgfD0gQklUKGRybV9wbGFuZV9pbmRleChwbGFuZSkpOwo+ICsJCX0KPiAgCX0KPiAgCj4gIAly ZXQgPSBkcm1fYXRvbWljX2NvbW1pdChzdGF0ZSk7Cj4gIGZyZWU6Cj4gKwlkcm1fYXRvbWljX2Ns ZWFuX29sZF9mYihkZXYsIHBsYW5lX21hc2ssIHJldCk7Cj4gKwo+ICAJZHJtX2F0b21pY19zdGF0 ZV9wdXQoc3RhdGUpOwo+ICAJcmV0dXJuIHJldDsKPiAgfQo+IC0KPiArLyoqCj4gKyAqIGRybV9h dG9taWNfaGVscGVyX2Rpc2FibGVfYWxsIC0gZGlzYWJsZSBhbGwgY3VycmVudGx5IGFjdGl2ZSBv dXRwdXRzCj4gKyAqIEBkZXY6IERSTSBkZXZpY2UKPiArICogQGN0eDogbG9jayBhY3F1aXNpdGlv biBjb250ZXh0Cj4gKyAqCj4gKyAqIExvb3BzIHRocm91Z2ggYWxsIGNvbm5lY3RvcnMsIGZpbmRp bmcgdGhvc2UgdGhhdCBhcmVuJ3QgdHVybmVkIG9mZiBhbmQgdGhlbgo+ICsgKiB0dXJucyB0aGVt IG9mZiBieSBzZXR0aW5nIHRoZWlyIERQTVMgbW9kZSB0byBPRkYgYW5kIGRlYWN0aXZhdGluZyB0 aGUgQ1JUQwo+ICsgKiB0aGF0IHRoZXkgYXJlIGNvbm5lY3RlZCB0by4KPiArICoKPiArICogVGhp cyBpcyB1c2VkIGZvciBleGFtcGxlIGluIHN1c3BlbmQvcmVzdW1lIHRvIGRpc2FibGUgYWxsIGN1 cnJlbnRseSBhY3RpdmUKPiArICogZnVuY3Rpb25zIHdoZW4gc3VzcGVuZGluZy4gSWYgeW91IGp1 c3Qgd2FudCB0byBzaHV0IGRvd24gZXZlcnl0aGluZyBhdCBlLmcuCj4gKyAqIGRyaXZlciB1bmxv YWQsIGxvb2sgYXQgZHJtX2F0b21pY19oZWxwZXJfc2h1dGRvd24oKS4KPiArICoKPiArICogTm90 ZSB0aGF0IGlmIGNhbGxlcnMgaGF2ZW4ndCBhbHJlYWR5IGFjcXVpcmVkIGFsbCBtb2Rlc2V0IGxv Y2tzIHRoaXMgbWlnaHQKPiArICogcmV0dXJuIC1FREVBRExLLCB3aGljaCBtdXN0IGJlIGhhbmRs ZWQgYnkgY2FsbGluZyBkcm1fbW9kZXNldF9iYWNrb2ZmKCkuCj4gKyAqCj4gKyAqIFJldHVybnM6 Cj4gKyAqIDAgb24gc3VjY2VzcyBvciBhIG5lZ2F0aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZS4K PiArICoKPiArICogU2VlIGFsc286Cj4gKyAqIGRybV9hdG9taWNfaGVscGVyX3N1c3BlbmQoKSwg ZHJtX2F0b21pY19oZWxwZXJfcmVzdW1lKCkgYW5kCj4gKyAqIGRybV9hdG9taWNfaGVscGVyX3No dXRkb3duKCkuCj4gKyAqLwo+ICtpbnQgZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwKPiArCQkJCSAgc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVf Y3R4ICpjdHgpCj4gK3sKPiArCXJldHVybiBfX2RybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfYWxs KGRldiwgY3R4LCBmYWxzZSk7Cj4gK30KPiAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBl cl9kaXNhYmxlX2FsbCk7Cj4gIAo+ICAvKioKPiBAQCAtMjk4Niw3ICsyOTk5LDcgQEAgdm9pZCBk cm1fYXRvbWljX2hlbHBlcl9zaHV0ZG93bihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJd2hp bGUgKDEpIHsKPiAgCQlyZXQgPSBkcm1fbW9kZXNldF9sb2NrX2FsbF9jdHgoZGV2LCAmY3R4KTsK PiAgCQlpZiAoIXJldCkKPiAtCQkJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwo ZGV2LCAmY3R4KTsKPiArCQkJcmV0ID0gX19kcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbChk ZXYsICZjdHgsIHRydWUpOwo+ICAKPiAgCQlpZiAocmV0ICE9IC1FREVBRExLKQo+ICAJCQlicmVh azsKPiAtLSAKPiAyLjE2LjEKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK