From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 02/23] drm/atomic-helper: Make
 drm_atomic_helper_disable_all() update the plane->fb pointers
Date: Mon, 26 Mar 2018 22:43:03 +0200
Message-ID: <20180326204303.GB14155@phenom.ffwll.local>
References: <20180322152313.6561-1-ville.syrjala@linux.intel.com>
 <20180322152313.6561-3-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20180322152313.6561-3-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, martin.peres@free.fr
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCBNYXIgMjIsIDIwMTggYXQgMDU6MjI6NTJQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3
cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu
Y29tPgo+IAo+IGRybV9hdG9taWNfaGVscGVyX3NodXRkb3duKCkgbmVlZHMgdG8gcmVsZWFzZSB0
aGUgcmVmZXJlbmNlIGhlbGQgYnkKPiBwbGFuZS0+ZmIsIHNvIHdlIHdhbnQgdG8gdXNlIGRybV9h
dG9taWNfY2xlYW5fb2xkX2ZiKCkgaW4KPiBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbCgp
LiBIb3dldmVyIGR1cmluZyBzdXNwZW5kL3Jlc3VtZSwgZ3B1Cj4gcmVzZXQgYW5kIGxvYWQgZGV0
ZWN0aW9uIHdlIHNob3VsZCBwcm9iYWJseSBsZWF2ZSB0aGF0IHN0dWZmIGFsb25lLAo+IGFzIG90
aGVyd2lzZSB3ZSdkIGhhdmUgdG8gbWFrZSBzdXJlIHdlIHB1dCB0aGVtIGJhY2sgYWdhaW4gd2hl
bgo+IHdlIHJlc3RvcmUgdGhlIGR1cGxpY2F0ZWQgc3RhdGUgdG8gdGhlIGRldmljZS4gU2VlbXMg
c2ltcGxlciB0byBtZQo+IHRvIG5vdCB0b3VjaCBhbnkgb2YgaXQgYW55d2F5Lgo+IAo+IHYyOiBE
b24ndCBpbmZsaWN0IHRoZSBjbGVhbl9vbGRfZmJzIGJvb2wgdG8gZHJpdmVycyAoRGFuaWVsKQo+
IAo+IENjOiBtYXJ0aW4ucGVyZXNAZnJlZS5mcgo+IENjOiBjaHJpc0BjaHJpcy13aWxzb24uY28u
dWsKPiBDYzogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAZ21haWwuY29tPiAodjEpCgpNb3JlIGZ1bm55
ICh2MSkgSSBqdXN0IG5vdGljZWQgLi4uCi1EYW5pZWwKCj4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0
IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIg
PGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOk
IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt
L2RybV9hdG9taWNfaGVscGVyLmMgfCA2NyArKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t
LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMo
LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMg
Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4IGM0OGYxODdkMDhk
ZS4uMzlhNjk1MDhkOGM5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj
X2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBA
QCAtMjg4MSwzMSArMjg4MSw5IEBAIGludCBfX2RybV9hdG9taWNfaGVscGVyX3NldF9jb25maWco
c3RydWN0IGRybV9tb2RlX3NldCAqc2V0LAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLS8qKgo+
IC0gKiBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbCAtIGRpc2FibGUgYWxsIGN1cnJlbnRs
eSBhY3RpdmUgb3V0cHV0cwo+IC0gKiBAZGV2OiBEUk0gZGV2aWNlCj4gLSAqIEBjdHg6IGxvY2sg
YWNxdWlzaXRpb24gY29udGV4dAo+IC0gKgo+IC0gKiBMb29wcyB0aHJvdWdoIGFsbCBjb25uZWN0
b3JzLCBmaW5kaW5nIHRob3NlIHRoYXQgYXJlbid0IHR1cm5lZCBvZmYgYW5kIHRoZW4KPiAtICog
dHVybnMgdGhlbSBvZmYgYnkgc2V0dGluZyB0aGVpciBEUE1TIG1vZGUgdG8gT0ZGIGFuZCBkZWFj
dGl2YXRpbmcgdGhlIENSVEMKPiAtICogdGhhdCB0aGV5IGFyZSBjb25uZWN0ZWQgdG8uCj4gLSAq
Cj4gLSAqIFRoaXMgaXMgdXNlZCBmb3IgZXhhbXBsZSBpbiBzdXNwZW5kL3Jlc3VtZSB0byBkaXNh
YmxlIGFsbCBjdXJyZW50bHkgYWN0aXZlCj4gLSAqIGZ1bmN0aW9ucyB3aGVuIHN1c3BlbmRpbmcu
IElmIHlvdSBqdXN0IHdhbnQgdG8gc2h1dCBkb3duIGV2ZXJ5dGhpbmcgYXQgZS5nLgo+IC0gKiBk
cml2ZXIgdW5sb2FkLCBsb29rIGF0IGRybV9hdG9taWNfaGVscGVyX3NodXRkb3duKCkuCj4gLSAq
Cj4gLSAqIE5vdGUgdGhhdCBpZiBjYWxsZXJzIGhhdmVuJ3QgYWxyZWFkeSBhY3F1aXJlZCBhbGwg
bW9kZXNldCBsb2NrcyB0aGlzIG1pZ2h0Cj4gLSAqIHJldHVybiAtRURFQURMSywgd2hpY2ggbXVz
dCBiZSBoYW5kbGVkIGJ5IGNhbGxpbmcgZHJtX21vZGVzZXRfYmFja29mZigpLgo+IC0gKgo+IC0g
KiBSZXR1cm5zOgo+IC0gKiAwIG9uIHN1Y2Nlc3Mgb3IgYSBuZWdhdGl2ZSBlcnJvciBjb2RlIG9u
IGZhaWx1cmUuCj4gLSAqCj4gLSAqIFNlZSBhbHNvOgo+IC0gKiBkcm1fYXRvbWljX2hlbHBlcl9z
dXNwZW5kKCksIGRybV9hdG9taWNfaGVscGVyX3Jlc3VtZSgpIGFuZAo+IC0gKiBkcm1fYXRvbWlj
X2hlbHBlcl9zaHV0ZG93bigpLgo+IC0gKi8KPiAtaW50IGRybV9hdG9taWNfaGVscGVyX2Rpc2Fi
bGVfYWxsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gLQkJCQkgIHN0cnVjdCBkcm1fbW9kZXNl
dF9hY3F1aXJlX2N0eCAqY3R4KQo+ICtzdGF0aWMgaW50IF9fZHJtX2F0b21pY19oZWxwZXJfZGlz
YWJsZV9hbGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiArCQkJCQkgICBzdHJ1Y3QgZHJtX21v
ZGVzZXRfYWNxdWlyZV9jdHggKmN0eCwKPiArCQkJCQkgICBib29sIGNsZWFuX29sZF9mYnMpCj4g
IHsKPiAgCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiAgCXN0cnVjdCBkcm1fY29u
bmVjdG9yX3N0YXRlICpjb25uX3N0YXRlOwo+IEBAIC0yOTE0LDYgKzI4OTIsNyBAQCBpbnQgZHJt
X2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCXN0
cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+ICAJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0
YXRlOwo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ICsJdW5zaWduZWQgaW50IHBsYW5lX21h
c2sgPSAwOwo+ICAJaW50IHJldCwgaTsKPiAgCj4gIAlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVf
YWxsb2MoZGV2KTsKPiBAQCAtMjk1NiwxNCArMjkzNSw0OCBAQCBpbnQgZHJtX2F0b21pY19oZWxw
ZXJfZGlzYWJsZV9hbGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJZ290byBmcmVlOwo+
ICAKPiAgCQlkcm1fYXRvbWljX3NldF9mYl9mb3JfcGxhbmUocGxhbmVfc3RhdGUsIE5VTEwpOwo+
ICsKPiArCQlpZiAoY2xlYW5fb2xkX2Zicykgewo+ICsJCQlwbGFuZS0+b2xkX2ZiID0gcGxhbmUt
PmZiOwo+ICsJCQlwbGFuZV9tYXNrIHw9IEJJVChkcm1fcGxhbmVfaW5kZXgocGxhbmUpKTsKPiAr
CQl9Cj4gIAl9Cj4gIAo+ICAJcmV0ID0gZHJtX2F0b21pY19jb21taXQoc3RhdGUpOwo+ICBmcmVl
Ogo+ICsJZHJtX2F0b21pY19jbGVhbl9vbGRfZmIoZGV2LCBwbGFuZV9tYXNrLCByZXQpOwo+ICsK
PiAgCWRybV9hdG9taWNfc3RhdGVfcHV0KHN0YXRlKTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAt
Cj4gKy8qKgo+ICsgKiBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbCAtIGRpc2FibGUgYWxs
IGN1cnJlbnRseSBhY3RpdmUgb3V0cHV0cwo+ICsgKiBAZGV2OiBEUk0gZGV2aWNlCj4gKyAqIEBj
dHg6IGxvY2sgYWNxdWlzaXRpb24gY29udGV4dAo+ICsgKgo+ICsgKiBMb29wcyB0aHJvdWdoIGFs
bCBjb25uZWN0b3JzLCBmaW5kaW5nIHRob3NlIHRoYXQgYXJlbid0IHR1cm5lZCBvZmYgYW5kIHRo
ZW4KPiArICogdHVybnMgdGhlbSBvZmYgYnkgc2V0dGluZyB0aGVpciBEUE1TIG1vZGUgdG8gT0ZG
IGFuZCBkZWFjdGl2YXRpbmcgdGhlIENSVEMKPiArICogdGhhdCB0aGV5IGFyZSBjb25uZWN0ZWQg
dG8uCj4gKyAqCj4gKyAqIFRoaXMgaXMgdXNlZCBmb3IgZXhhbXBsZSBpbiBzdXNwZW5kL3Jlc3Vt
ZSB0byBkaXNhYmxlIGFsbCBjdXJyZW50bHkgYWN0aXZlCj4gKyAqIGZ1bmN0aW9ucyB3aGVuIHN1
c3BlbmRpbmcuIElmIHlvdSBqdXN0IHdhbnQgdG8gc2h1dCBkb3duIGV2ZXJ5dGhpbmcgYXQgZS5n
Lgo+ICsgKiBkcml2ZXIgdW5sb2FkLCBsb29rIGF0IGRybV9hdG9taWNfaGVscGVyX3NodXRkb3du
KCkuCj4gKyAqCj4gKyAqIE5vdGUgdGhhdCBpZiBjYWxsZXJzIGhhdmVuJ3QgYWxyZWFkeSBhY3F1
aXJlZCBhbGwgbW9kZXNldCBsb2NrcyB0aGlzIG1pZ2h0Cj4gKyAqIHJldHVybiAtRURFQURMSywg
d2hpY2ggbXVzdCBiZSBoYW5kbGVkIGJ5IGNhbGxpbmcgZHJtX21vZGVzZXRfYmFja29mZigpLgo+
ICsgKgo+ICsgKiBSZXR1cm5zOgo+ICsgKiAwIG9uIHN1Y2Nlc3Mgb3IgYSBuZWdhdGl2ZSBlcnJv
ciBjb2RlIG9uIGZhaWx1cmUuCj4gKyAqCj4gKyAqIFNlZSBhbHNvOgo+ICsgKiBkcm1fYXRvbWlj
X2hlbHBlcl9zdXNwZW5kKCksIGRybV9hdG9taWNfaGVscGVyX3Jlc3VtZSgpIGFuZAo+ICsgKiBk
cm1fYXRvbWljX2hlbHBlcl9zaHV0ZG93bigpLgo+ICsgKi8KPiAraW50IGRybV9hdG9taWNfaGVs
cGVyX2Rpc2FibGVfYWxsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCQkgIHN0cnVjdCBk
cm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqY3R4KQo+ICt7Cj4gKwlyZXR1cm4gX19kcm1fYXRvbWlj
X2hlbHBlcl9kaXNhYmxlX2FsbChkZXYsIGN0eCwgZmFsc2UpOwo+ICt9Cj4gIEVYUE9SVF9TWU1C
T0woZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwpOwo+ICAKPiAgLyoqCj4gQEAgLTI5ODYs
NyArMjk5OSw3IEBAIHZvaWQgZHJtX2F0b21pY19oZWxwZXJfc2h1dGRvd24oc3RydWN0IGRybV9k
ZXZpY2UgKmRldikKPiAgCXdoaWxlICgxKSB7Cj4gIAkJcmV0ID0gZHJtX21vZGVzZXRfbG9ja19h
bGxfY3R4KGRldiwgJmN0eCk7Cj4gIAkJaWYgKCFyZXQpCj4gLQkJCXJldCA9IGRybV9hdG9taWNf
aGVscGVyX2Rpc2FibGVfYWxsKGRldiwgJmN0eCk7Cj4gKwkJCXJldCA9IF9fZHJtX2F0b21pY19o
ZWxwZXJfZGlzYWJsZV9hbGwoZGV2LCAmY3R4LCB0cnVlKTsKPiAgCj4gIAkJaWYgKHJldCAhPSAt
RURFQURMSykKPiAgCQkJYnJlYWs7Cj4gLS0gCj4gMi4xNi4xCj4gCgotLSAKRGFuaWVsIFZldHRl
cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu
Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==