From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 08/23] drm: Use plane->state->fb over
 plane->fb
Date: Tue, 27 Mar 2018 10:10:35 +0200
Message-ID: <20180327081035.GM14155@phenom.ffwll.local>
References: <20180322152313.6561-1-ville.syrjala@linux.intel.com>
 <20180322152313.6561-9-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20180322152313.6561-9-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCBNYXIgMjIsIDIwMTggYXQgMDU6MjI6NThQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3
cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu
Y29tPgo+IAo+IFN0b3AgbG9va2luZyBhdCBwbGFuZS0+ZmIgb24gYXRvbWljIGRyaXZlcnMuIFVz
ZSBwbGFuZS0+c3RhdGUtPmZiCj4gaW5zdGVhZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBT
eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IERh
bmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cgo+IC0tLQo+ICBkcml2ZXJzL2dw
dS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8ICAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f
Y3J0Yy5jICAgICAgICAgIHwgMTEgKysrKysrKysrLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9w
bGFuZS5jICAgICAgICAgfCAxOSArKysrKysrKysrKysrKy0tLS0tCj4gIDMgZmlsZXMgY2hhbmdl
ZCwgMjQgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0
b21pY19oZWxwZXIuYwo+IGluZGV4IDFiMzllYmYyYmUyZS4uMGU4MDZmMDcwZDAwIDEwMDY0NAo+
IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBAQCAtMjY1OSw3ICsyNjU5LDcgQEAgaW50
IGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUs
Cj4gIAkJZ290byBmYWlsOwo+ICAJfQo+ICAKPiAtCWlmIChwbGFuZV9zdGF0ZS0+Y3J0YyAmJiAo
cGxhbmUgPT0gcGxhbmUtPmNydGMtPmN1cnNvcikpCj4gKwlpZiAocGxhbmVfc3RhdGUtPmNydGMg
JiYgcGxhbmVfc3RhdGUtPmNydGMtPmN1cnNvciA9PSBwbGFuZSkKPiAgCQlwbGFuZV9zdGF0ZS0+
c3RhdGUtPmxlZ2FjeV9jdXJzb3JfdXBkYXRlID0gdHJ1ZTsKPiAgCj4gIAlyZXQgPSBfX2RybV9h
dG9taWNfaGVscGVyX2Rpc2FibGVfcGxhbmUocGxhbmUsIHBsYW5lX3N0YXRlKTsKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Ny
dGMuYwo+IGluZGV4IDUzN2ZmYWFiODU1Yy4uYTIzMWRkNWRjZTE2IDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRj
LmMKPiBAQCAtNTk3LDEzICs1OTcsMjAgQEAgaW50IGRybV9tb2RlX3NldGNydGMoc3RydWN0IGRy
bV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCQkvKiBJZiB3ZSBoYXZlIGEgbW9kZSB3ZSBu
ZWVkIGEgZnJhbWVidWZmZXIuICovCj4gIAkJLyogSWYgd2UgcGFzcyAtMSwgc2V0IHRoZSBtb2Rl
IHdpdGggdGhlIGN1cnJlbnRseSBib3VuZCBmYiAqLwo+ICAJCWlmIChjcnRjX3JlcS0+ZmJfaWQg
PT0gLTEpIHsKPiAtCQkJaWYgKCFwbGFuZS0+ZmIpIHsKPiArCQkJc3RydWN0IGRybV9mcmFtZWJ1
ZmZlciAqb2xkX2ZiOwo+ICsKPiArCQkJaWYgKHBsYW5lLT5zdGF0ZSkKPiArCQkJCW9sZF9mYiA9
IHBsYW5lLT5zdGF0ZS0+ZmI7Cj4gKwkJCWVsc2UKPiArCQkJCW9sZF9mYiA9IHBsYW5lLT5mYjsK
PiArCj4gKwkJCWlmICghb2xkX2ZiKSB7Cj4gIAkJCQlEUk1fREVCVUdfS01TKCJDUlRDIGRvZXNu
J3QgaGF2ZSBjdXJyZW50IEZCXG4iKTsKPiAgCQkJCXJldCA9IC1FSU5WQUw7Cj4gIAkJCQlnb3Rv
IG91dDsKPiAgCQkJfQo+ICAKPiAtCQkJZmIgPSBwbGFuZS0+ZmI7Cj4gKwkJCWZiID0gb2xkX2Zi
Owo+ICAJCQkvKiBNYWtlIHJlZmNvdW50aW5nIHN5bW1ldHJpYyB3aXRoIHRoZSBsb29rdXAgcGF0
aC4gKi8KPiAgCQkJZHJtX2ZyYW1lYnVmZmVyX2dldChmYik7Cj4gIAkJfSBlbHNlIHsKPiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL2Ry
bV9wbGFuZS5jCj4gaW5kZXggMDA4Zjk0NTZhNWU4Li4wMzUwNTQ0NTUzMDEgMTAwNjQ0Cj4gLS0t
IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ry
bV9wbGFuZS5jCj4gQEAgLTc5Miw3ICs3OTIsMTEgQEAgc3RhdGljIGludCBkcm1fbW9kZV9jdXJz
b3JfdW5pdmVyc2FsKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCQkJZmIgPSBOVUxMOwo+ICAJ
CX0KPiAgCX0gZWxzZSB7Cj4gLQkJZmIgPSBwbGFuZS0+ZmI7Cj4gKwkJaWYgKHBsYW5lLT5zdGF0
ZSkKPiArCQkJZmIgPSBwbGFuZS0+c3RhdGUtPmZiOwo+ICsJCWVsc2UKPiArCQkJZmIgPSBwbGFu
ZS0+ZmI7Cj4gKwo+ICAJCWlmIChmYikKPiAgCQkJZHJtX2ZyYW1lYnVmZmVyX2dldChmYik7Cj4g
IAl9Cj4gQEAgLTkzNCw3ICs5MzgsNyBAQCBpbnQgZHJtX21vZGVfcGFnZV9mbGlwX2lvY3RsKHN0
cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlzdHJ1Y3QgZHJtX21vZGVfY3J0Y19wYWdlX2ZsaXBf
dGFyZ2V0ICpwYWdlX2ZsaXAgPSBkYXRhOwo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ICAJ
c3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gLQlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9
IE5VTEw7Cj4gKwlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IE5VTEwsICpvbGRfZmI7Cj4g
IAlzdHJ1Y3QgZHJtX3BlbmRpbmdfdmJsYW5rX2V2ZW50ICplID0gTlVMTDsKPiAgCXUzMiB0YXJn
ZXRfdmJsYW5rID0gcGFnZV9mbGlwLT5zZXF1ZW5jZTsKPiAgCXN0cnVjdCBkcm1fbW9kZXNldF9h
Y3F1aXJlX2N0eCBjdHg7Cj4gQEAgLTEwMTIsNyArMTAxNiwxMiBAQCBpbnQgZHJtX21vZGVfcGFn
ZV9mbGlwX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlpZiAocmV0KQo+ICAJCWdv
dG8gb3V0Owo+ICAKPiAtCWlmIChwbGFuZS0+ZmIgPT0gTlVMTCkgewo+ICsJaWYgKHBsYW5lLT5z
dGF0ZSkKPiArCQlvbGRfZmIgPSBwbGFuZS0+c3RhdGUtPmZiOwo+ICsJZWxzZQo+ICsJCW9sZF9m
YiA9IHBsYW5lLT5mYjsKPiArCj4gKwlpZiAob2xkX2ZiID09IE5VTEwpIHsKPiAgCQkvKiBUaGUg
ZnJhbWVidWZmZXIgaXMgY3VycmVudGx5IHVuYm91bmQsIHByZXN1bWFibHkKPiAgCQkgKiBkdWUg
dG8gYSBob3RwbHVnIGV2ZW50LCB0aGF0IHVzZXJzcGFjZSBoYXMgbm90Cj4gIAkJICogeWV0IGRp
c2NvdmVyZWQuCj4gQEAgLTEwMjcsNyArMTAzNiw3IEBAIGludCBkcm1fbW9kZV9wYWdlX2ZsaXBf
aW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQlnb3RvIG91dDsKPiAgCX0KPiAgCj4g
LQlpZiAoY3J0Yy0+c3RhdGUpIHsKPiArCWlmIChwbGFuZS0+c3RhdGUpIHsKPiAgCQljb25zdCBz
dHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSA9IHBsYW5lLT5zdGF0ZTsKPiAgCj4gIAkJcmV0
ID0gZHJtX2ZyYW1lYnVmZmVyX2NoZWNrX3NyY19jb29yZHMoc3RhdGUtPnNyY194LAo+IEBAIC0x
MDQyLDcgKzEwNTEsNyBAQCBpbnQgZHJtX21vZGVfcGFnZV9mbGlwX2lvY3RsKHN0cnVjdCBkcm1f
ZGV2aWNlICpkZXYsCj4gIAlpZiAocmV0KQo+ICAJCWdvdG8gb3V0Owo+ICAKPiAtCWlmIChwbGFu
ZS0+ZmItPmZvcm1hdCAhPSBmYi0+Zm9ybWF0KSB7Cj4gKwlpZiAob2xkX2ZiLT5mb3JtYXQgIT0g
ZmItPmZvcm1hdCkgewo+ICAJCURSTV9ERUJVR19LTVMoIlBhZ2UgZmxpcCBpcyBub3QgYWxsb3dl
ZCB0byBjaGFuZ2UgZnJhbWUgYnVmZmVyIGZvcm1hdC5cbiIpOwo+ICAJCXJldCA9IC1FSU5WQUw7
Cj4gIAkJZ290byBvdXQ7Cj4gLS0gCj4gMi4xNi4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au
b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy
ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp
bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==