From: Daniel Vetter <daniel@ffwll.ch>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/6] drm/tinydrm: Use gem_free_object_unlocked
Date: Tue, 27 Mar 2018 10:19:37 +0200 [thread overview]
Message-ID: <20180327081936.GP14155@phenom.ffwll.local> (raw)
In-Reply-To: <fdc823b7-41e3-eef8-1193-ba127a44190e@tronnes.org>
On Thu, Mar 22, 2018 at 02:46:45PM +0100, Noralf Trønnes wrote:
>
> Den 22.03.2018 11.51, skrev Daniel Vetter:
> > tinydrm doesn't use dev->struct_mutex and therefore has no need to use
> > gem_free_object.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: "Noralf Trønnes" <noralf@tronnes.org>
> > ---
>
> Acked-by: Noralf Trønnes <noralf@tronnes.org>
Thanks for your ack, applied. Somehow something is wrong with my mailer
and ate the other 5 patches. Even in the resend. I'll try again.
-Daniel
>
> > drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 2 +-
> > include/drm/tinydrm/tinydrm.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-core.c b/drivers/gpu/drm/tinydrm/core/tinydrm-core.c
> > index 4c6616278c48..24a33bf862fa 100644
> > --- a/drivers/gpu/drm/tinydrm/core/tinydrm-core.c
> > +++ b/drivers/gpu/drm/tinydrm/core/tinydrm-core.c
> > @@ -91,7 +91,7 @@ EXPORT_SYMBOL(tinydrm_gem_cma_prime_import_sg_table);
> > * GEM object state and frees the memory used to store the object itself using
> > * drm_gem_cma_free_object(). It also handles PRIME buffers which has the kernel
> > * virtual address set by tinydrm_gem_cma_prime_import_sg_table(). Drivers
> > - * can use this as their &drm_driver->gem_free_object callback.
> > + * can use this as their &drm_driver->gem_free_object_unlocked callback.
> > */
> > void tinydrm_gem_cma_free_object(struct drm_gem_object *gem_obj)
> > {
> > diff --git a/include/drm/tinydrm/tinydrm.h b/include/drm/tinydrm/tinydrm.h
> > index 07a9a11fe19d..77a93ec577fd 100644
> > --- a/include/drm/tinydrm/tinydrm.h
> > +++ b/include/drm/tinydrm/tinydrm.h
> > @@ -41,7 +41,7 @@ pipe_to_tinydrm(struct drm_simple_display_pipe *pipe)
> > * the &drm_driver structure.
> > */
> > #define TINYDRM_GEM_DRIVER_OPS \
> > - .gem_free_object = tinydrm_gem_cma_free_object, \
> > + .gem_free_object_unlocked = tinydrm_gem_cma_free_object, \
> > .gem_print_info = drm_gem_cma_print_info, \
> > .gem_vm_ops = &drm_gem_cma_vm_ops, \
> > .prime_handle_to_fd = drm_gem_prime_handle_to_fd, \
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-27 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 10:51 [PATCH 0/6] move more drivers to gem_free_object_unlocked Daniel Vetter
2018-03-22 10:51 ` [PATCH 1/6] drm/tinydrm: Use gem_free_object_unlocked Daniel Vetter
2018-03-22 13:46 ` Noralf Trønnes
2018-03-27 8:19 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-26 15:43 [PATCH 0/6] move more drivers to gem_free_object_unlocked Daniel Vetter
2018-03-26 15:43 ` [PATCH 1/6] drm/tinydrm: Use gem_free_object_unlocked Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327081936.GP14155@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox