From: Sean Paul <seanpaul@chromium.org>
To: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>,
Boris Brezillon <boris.brezillon@bootlin.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/atomic: Add sanity checks to drm_atomic_helper_async_commit()
Date: Mon, 2 Apr 2018 11:45:31 -0400 [thread overview]
Message-ID: <20180402154531.GM41885@art_vandelay> (raw)
In-Reply-To: <87o9j5jtme.fsf@anholt.net>
On Fri, Mar 30, 2018 at 11:39:05AM -0700, Eric Anholt wrote:
> Boris Brezillon <boris.brezillon@bootlin.com> writes:
>
> > ->atomic_async_update() requires that drivers update the plane->state
> > object before returning. Make sure at least common properties have been
> > updated.
> >
> > Cc: Gustavo Padovan <gustavo@padovan.org>
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > ---
> > Hello,
> >
> > This is a problem I had when debugging the VC4 ->atomic_async_update()
> > implementation. The function was not updating plane->fb as it's
> > supposed thus leaving plane->state->fb in an inconsistent state after
> > each async update.
> >
> > Not sure if such WARN_ON_ONCE() are accepted in the core though, so
> > I'll maintainers decide whether this is relevant or not and whether
> > they prefer to have WARN_ON() or DRM_ERROR() messages.
>
> I'm a huge fan of this kind of safety check. FWIW,
>
> Acked-by: Eric Anholt <eric@anholt.net>
Agreed, seems like a useful safety net to me.
Acked-by: Sean Paul <seanpaul@chromium.org>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-02 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 14:55 [PATCH] drm/atomic: Add sanity checks to drm_atomic_helper_async_commit() Boris Brezillon
2018-03-30 18:39 ` Eric Anholt
2018-04-02 15:45 ` Sean Paul [this message]
2018-04-03 9:23 ` Daniel Vetter
2018-04-18 7:07 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402154531.GM41885@art_vandelay \
--to=seanpaul@chromium.org \
--cc=airlied@linux.ie \
--cc=boris.brezillon@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox