From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC 3/3] drm: Add helper to validate damage during modeset_check Date: Thu, 5 Apr 2018 09:59:29 +0200 Message-ID: <20180405075929.GR3881@phenom.ffwll.local> References: <1522885748-67122-1-git-send-email-drawat@vmware.com> <1522885748-67122-4-git-send-email-drawat@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FC0A6E6CB for ; Thu, 5 Apr 2018 07:59:34 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id i3so4246005wmf.3 for ; Thu, 05 Apr 2018 00:59:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1522885748-67122-4-git-send-email-drawat@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Deepak Rawat Cc: thellstrom@vmware.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-graphics-maintainer@vmware.com, lukasz.spintzyk@displaylink.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMDQsIDIwMTggYXQgMDQ6NDk6MDhQTSAtMDcwMCwgRGVlcGFrIFJhd2F0IHdy b3RlOgo+IFRoaXMgcGF0Y2ggYWRkcyBhIGhlbHBlciB3aGljaCBzaG91bGQgYmUgY2FsbGVkIGJ5 IGRyaXZlciB3aGljaCBlbmFibGUKPiBkYW1hZ2UgKGJ5IGNhbGxpbmcgZHJtX3BsYW5lX2VuYWJs ZV9kYW1hZ2VfY2xpcHMpIGZyb20gYXRvbWljX2NoZWNrCj4gaG9vay4gVGhpcyBoZWxwZXIgZm9y IG5vdyBzZXQgdGhlIGRhbWFnZSB0byBOVUxMIGZvciB0aGUgcGxhbmVzIG9uIGNydGMKPiB3aGlj aCBuZWVkIGZ1bGwgbW9kZXNldC4KPiAKPiBUaGUgZHJpdmVyIGFsc28gbmVlZCB0byBjaGVjayBm b3Igb3RoZXIgY3J0YyBwcm9wZXJ0aWVzIHdoaWNoIGNhbgo+IGFmZmVjdCBkYW1hZ2UgaW4gYXRv bWljX2NoZWNrIGhvb2ssIGxpa2UgZ2FtbWEsIGN0bSwgZXRjLiBQbGFuZSByZWxhdGVkCj4gcHJv cGVydGllcyB3aGljaCBhZmZlY3QgZGFtYWdlIGNhbiBiZSBoYW5kbGVkIGluIGRhbWFnZSBpdGVy YXRvci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEZWVwYWsgUmF3YXQgPGRyYXdhdEB2bXdhcmUuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8IDQ3ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9kcm0vZHJtX2F0b21p Y19oZWxwZXIuaCAgICAgfCAgMiArKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMo KykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4IDM1NWI1MTQuLjIz ZjQ0YWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IEBAIC0zOTg3LDMg KzM5ODcsNTAgQEAgZHJtX2F0b21pY19oZWxwZXJfZGFtYWdlX2l0ZXJfbmV4dChzdHJ1Y3QgZHJt X2F0b21pY19oZWxwZXJfZGFtYWdlX2l0ZXIgKml0ZXIsCj4gIAlyZXR1cm4gdHJ1ZTsKPiAgfQo+ ICBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX2RhbWFnZV9pdGVyX25leHQpOwo+ICsK PiArLyoqCj4gKyAqIGRybV9hdG9taWNfaGVscGVyX2NoZWNrX2RhbWFnZSAtIHZhbGlkYXRlIHN0 YXRlIG9iamVjdCBmb3IgZGFtYWdlIGNoYW5nZXMKPiArICogQGRldjogRFJNIGRldmljZQo+ICsg KiBAc3RhdGU6IHRoZSBkcml2ZXIgc3RhdGUgb2JqZWN0Cj4gKyAqCj4gKyAqIENoZWNrIHRoZSBz dGF0ZSBvYmplY3QgaWYgZGFtYWdlIGlzIHJlcXVpcmVkIG9yIG5vdC4gSW4gY2FzZSBkYW1hZ2Ug aXMgbm90Cj4gKyAqIHJlcXVpcmVkIGUuZy4gbmVlZCBtb2Rlc2V0LCB0aGUgZGFtYWdlIGJsb2Ig aXMgc2V0IHRvIE5VTEwuCgpXaHkgaXMgdGhhdCBuZWVkZWQ/CgpJIGNhbiBpbWFnaW5lIHRoYXQg ZHJpdmVycyB1bmNvbmRpdGlvbmFsbHkgdXBsb2FkIGV2ZXJ5dGhpbmcgZm9yIGEKbW9kZXNldCwg YW5kIGhlbmNlIGRvbid0IG5lZWQgc3BlY2lhbCBkYW1hZ2UgdHJhY2tpbmcuIEJ1dCBmb3IgdGhh dCBpdCdzCmltbyBiZXR0ZXIgdG8gaGF2ZSBhIGNsZWFyX2RhbWFnZSgpIGhlbHBlci4KCkJ1dCBl dmVuIGZvciBtb2Rlc2V0cyAoZS5nLiByZXNvbHV0aW9uIGNoYW5nZXMpIEknZCBleHBlY3QgdGhh dCB2aXJ0dWFsCmRyaXZlcnMgZG9uJ3Qgd2FudCB0byB1cGxvYWQgdW5lY2Vzc2FyeSBhbW91bnRz IG9mIGRhdGEuIE1hbnVhbCB1cGxvYWQKaHcgZHJpdmVycyBwcm9iYWJseSBuZWVkIHRvIHVwbG9h ZCBldmVyeXRoaW5nLCBiZWNhdXNlIHRoZSBwYW5lbCB3aWxsIGhhdmUKZm9yZ290dGVuIGFsbCB0 aGUgb2xkIGRhdGEgb25jZSBwb3dlciBjeWNsZWQuCgpBbmQgaWYgeW91IHRoaW5rIHRoaXMgaXMg cmVhbGx5IHRoZSByaWdodCB0aGluZywgdGhlbiB3ZSBuZWVkIHRvIHJlbmFtZQp0aGUgZnVuY3Rp b24gdG8gdGVsbCB3aGF0IGl0IGRvZXMsIGUuZy4KCmRybV9kYW1hZ2VfaGVscGVyX2NsZWFyX2Rh bWFnZV9vbl9tb2Rlc2V0KCkKCmRybV9kYW1hZ2VfaGVscGVyIGJlY2F1c2UgSSB0aGluayB3ZSBz aG91bGQgc3R1ZmYgdGhpcyBhbGwgaW50bwpkcm1fZGFtYWdlX2hlbHBlci5jLCBzZWUgcHJldmlv dXMgcGF0Y2guCgpCdXQgSSB0aGluayBhCgpkcm1fZGFtYWdlX2hlbHBlcl9jbGVhcl9kYW1hZ2Uo Y3J0Y19zdGF0ZSkKCndoaWNoIHlvdSBjYW4gdXNlIGluIHlvdXIgY3J0Yy0+YXRvbWljX2NoZWNr IGZ1bmN0aW9uIGxpa2UKCmNydGNfYXRvbWljX2NoZWNrKHN0YXRlKQp7CglpZiAoZHJtX2F0b21p Y19jcnRjX25lZWRzX21vZGVzZXQoc3RhdGUpKQoJCWRybV9kYW1hZ2VfaGVscGVyX2NsZWFyX2Rh bWFnZShzdGF0ZSk7Cn0KCmlzIG1vcmUgZmxleGlibGUgYW5kIHVzZWZ1bCBmb3IgZHJpdmVycy4g VGhlcmUgbWlnaHQgYmUgb3RoZXIgY2FzZXMgd2hlcmUKY2xlYXJpbmcgZGFtYWdlIGlzIHRoZSBy aWdodCB0aGluZyB0byBkby4gQWxzbywgdGhlcmUncyB0aGUgcXVlc3Rpb24gb2YKd2hldGhlciBu byBkYW1hZ2UgY2xpcHMgPT0gZnVsbCBkYW1hZ2Ugb3Igbm90LCBzbyBtYXliZSB3ZSBzaG91bGQg Y2FsbAp0aGlzIGhlbHBlciBmdWxsX2RhbWFnZSgpIGluc3RlYWQuCi1EYW5pZWwKCj4gKyAqCj4g KyAqIE5PVEU6IFRoaXMgaGVscGVyIGlzIG5vdCBjYWxsZWQgYnkgY29yZS4gVGhvc2UgZHJpdmVy IHdoaWNoIGVuYWJsZSBkYW1hZ2UKPiArICogdXNpbmcgZHJtX3BsYW5lX2VuYWJsZV9kYW1hZ2Vf Y2xpcHMgc2hvdWxkIGNhbGwgdGhpcyBmcm9tIHRoZWlyIEBhdG9taWNfY2hlY2sKPiArICogaG9v ay4KPiArICovCj4gK2ludCBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19kYW1hZ2Uoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwKPiArCQkJCSAgIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkK PiArewo+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ICsJc3RydWN0IGRybV9wbGFuZSAqcGxh bmU7Cj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gKwl1bnNpZ25lZCBw bGFuZV9tYXNrOwo+ICsJaW50IGk7Cj4gKwo+ICsJZm9yX2VhY2hfbmV3X2NydGNfaW5fc3RhdGUo c3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpIHsKPiArCQlpZiAoIWRybV9hdG9taWNfY3J0Y19u ZWVkc19tb2Rlc2V0KGNydGNfc3RhdGUpKQo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJcGxhbmVf bWFzayA9IGNydGNfc3RhdGUtPnBsYW5lX21hc2s7Cj4gKwkJcGxhbmVfbWFzayB8PSBjcnRjLT5z dGF0ZS0+cGxhbmVfbWFzazsKPiArCj4gKwkJZHJtX2Zvcl9lYWNoX3BsYW5lX21hc2socGxhbmUs IGRldiwgcGxhbmVfbWFzaykgewo+ICsJCQlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9z dGF0ZSA9Cj4gKwkJCQlkcm1fYXRvbWljX2dldF9wbGFuZV9zdGF0ZShzdGF0ZSwgcGxhbmUpOwo+ ICsKPiArCQkJaWYgKElTX0VSUihwbGFuZV9zdGF0ZSkpCj4gKwkJCQlyZXR1cm4gUFRSX0VSUihw bGFuZV9zdGF0ZSk7Cj4gKwo+ICsJCQlpZiAocGxhbmVfc3RhdGUtPmRhbWFnZV9jbGlwcykgewo+ ICsJCQkJZHJtX3Byb3BlcnR5X2Jsb2JfcHV0KHBsYW5lX3N0YXRlLT5kYW1hZ2VfY2xpcHMpOwo+ ICsJCQkJcGxhbmVfc3RhdGUtPmRhbWFnZV9jbGlwcyA9IE5VTEw7Cj4gKwkJCQlwbGFuZV9zdGF0 ZS0+bnVtX2NsaXBzID0gMDsKPiArCQkJfQo+ICsJCX0KPiArCX0KPiArCj4gKwlyZXR1cm4gMDsK PiArfQo+ICtFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX2NoZWNrX2RhbWFnZSk7Cj4g ZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmggYi9pbmNsdWRlL2Ry bS9kcm1fYXRvbWljX2hlbHBlci5oCj4gaW5kZXggZWJkNGI2Ni4uYjEyMzM1YyAxMDA2NDQKPiAt LS0gYS9pbmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oCj4gKysrIGIvaW5jbHVkZS9kcm0v ZHJtX2F0b21pY19oZWxwZXIuaAo+IEBAIC0yMjQsNiArMjI0LDggQEAgZHJtX2F0b21pY19oZWxw ZXJfZGFtYWdlX2l0ZXJfaW5pdChzdHJ1Y3QgZHJtX2F0b21pY19oZWxwZXJfZGFtYWdlX2l0ZXIg Kml0ZXIsCj4gIGJvb2wKPiAgZHJtX2F0b21pY19oZWxwZXJfZGFtYWdlX2l0ZXJfbmV4dChzdHJ1 Y3QgZHJtX2F0b21pY19oZWxwZXJfZGFtYWdlX2l0ZXIgKml0ZXIsCj4gIAkJCQkgICBzdHJ1Y3Qg ZHJtX3JlY3QgKnJlY3QpOwo+ICtpbnQgZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfZGFtYWdlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCQkgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAq c3RhdGUpOwo+ICAKPiAgLyoqCj4gICAqIGRybV9hdG9taWNfY3J0Y19mb3JfZWFjaF9wbGFuZSAt IGl0ZXJhdGUgb3ZlciBwbGFuZXMgY3VycmVudGx5IGF0dGFjaGVkIHRvIENSVEMKPiAtLSAKPiAy LjcuNAo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=