From: Daniel Vetter <daniel@ffwll.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 11/13] drm/omapdrm: Nuke omap_framebuffer_get_next_connector()
Date: Mon, 9 Apr 2018 10:41:15 +0200 [thread overview]
Message-ID: <20180409084115.GP31310@phenom.ffwll.local> (raw)
In-Reply-To: <08573017-0b7f-38e7-b08b-82de353c3204@ti.com>
On Fri, Apr 06, 2018 at 09:10:43AM +0300, Tomi Valkeinen wrote:
> On 05/04/18 19:50, Daniel Vetter wrote:
> > On Thu, Apr 05, 2018 at 06:13:58PM +0300, Ville Syrjala wrote:
> >> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>
> >> omap_framebuffer_get_next_connector() uses plane->fb which we want to
> >> deprecate for atomic drivers. As omap_framebuffer_get_next_connector()
> >> is unused just nuke the entire function.
> >>
> >> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> >> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Yeah was slightly worried how to fix up this one, but we're lucky!
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> I tried to remove it just a week ago, but Sebastian said that it's used
> by a unmerged series about DSI command mode displays, so I dropped the
> patch.
>
> In the unmerged series, it's used by omap_framebuffer_dirty() ([PATCHv3
> 3/8] drm/omap: add support for manually updated displays). So we have a
> framebuffer, and we want to know which crtcs need to be flushed.
You can't do that in atomic drivers.
You need to take appropriate locks and do the full ->state->fb deref.
Also, there's a gazillion of copies for generic framebuffer_dirty
implementations floating around, pleas try to coordinate with those.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-09 8:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 15:13 [PATCH 01/13] drm/msm: Stop consulting plane->fb/crtc Ville Syrjala
2018-04-05 15:13 ` [PATCH 02/13] drm/sti: Stop consulting plane->crtc Ville Syrjala
2018-04-05 16:34 ` Daniel Vetter
2018-04-05 15:13 ` [PATCH 03/13] drm/atmel-hlcdc: " Ville Syrjala
2018-04-05 16:35 ` Daniel Vetter
2018-04-05 15:13 ` [PATCH 04/13] drm/amdgpu/dc: Stop updating plane->fb Ville Syrjala
2018-04-05 16:41 ` Daniel Vetter
2018-04-05 18:25 ` Harry Wentland
2018-04-05 15:13 ` [PATCH 05/13] drm/i915: Stop updating plane->fb/crtc Ville Syrjala
2018-04-05 16:44 ` Daniel Vetter
2018-04-05 17:02 ` [PATCH v2 " Ville Syrjala
2018-04-05 20:00 ` Daniel Vetter
2018-04-05 15:13 ` [PATCH 06/13] drm/exynos: Stop updating plane->crtc Ville Syrjala
2018-04-05 16:45 ` Daniel Vetter
2018-04-06 2:03 ` Inki Dae
[not found] ` <20180405151400.11326-1-ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-04-05 15:13 ` [PATCH 07/13] drm/msm: Stop updating plane->fb/crtc Ville Syrjala
2018-04-05 16:32 ` Daniel Vetter
2018-04-05 15:13 ` [PATCH 08/13] drm/virtio: Stop updating plane->crtc Ville Syrjala
2018-04-05 16:46 ` [Intel-gfx] " Daniel Vetter
2018-04-05 15:13 ` [PATCH 09/13] drm/vc4: Stop updating plane->fb/crtc Ville Syrjala
2018-04-05 16:46 ` Daniel Vetter
2018-04-05 15:13 ` [PATCH 10/13] drm/atmel-hlcdc: Stop using plane->fb Ville Syrjala
2018-04-05 16:38 ` Daniel Vetter
2018-04-05 15:13 ` [PATCH 11/13] drm/omapdrm: Nuke omap_framebuffer_get_next_connector() Ville Syrjala
2018-04-05 16:50 ` Daniel Vetter
2018-04-06 6:10 ` [Intel-gfx] " Tomi Valkeinen
2018-04-09 8:41 ` Daniel Vetter [this message]
2018-04-16 13:29 ` Tomi Valkeinen
2018-04-05 15:13 ` [PATCH 12/13] drm: Stop updating plane->crtc/fb/old_fb on atomic drivers Ville Syrjala
2018-04-05 16:58 ` Daniel Vetter
2018-04-05 15:14 ` [PATCH 13/13] drm: Add local 'plane' variable for tmp->primary Ville Syrjala
2018-04-05 16:59 ` Daniel Vetter
2018-04-05 16:33 ` [PATCH 01/13] drm/msm: Stop consulting plane->fb/crtc Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409084115.GP31310@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox