From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [RFC v4 21/25] drm/fb-helper: Add
 drm_fb_helper_fb_open/release()
Date: Mon, 16 Apr 2018 10:46:44 +0200
Message-ID: <20180416084644.GP31310@phenom.ffwll.local>
References: <20180414115318.14500-1-noralf@tronnes.org>
 <20180414115318.14500-22-noralf@tronnes.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20180414115318.14500-22-noralf@tronnes.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= <noralf@tronnes.org>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gU2F0LCBBcHIgMTQsIDIwMTggYXQgMDE6NTM6MTRQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz
IHdyb3RlOgo+IFRoZXNlIGhlbHBlcnMga2VlcCB0cmFjayBvZiBmYmRldiB1c2VycyBhbmQgZHJt
X2RyaXZlci5sYXN0X2Nsb3NlIHdpbGwKPiBvbmx5IHJlc3RvcmUgZmJkZXYgd2hlbiBhY3R1YWxs
eSBpbiB1c2UuIEFkZGl0aW9uYWxseSB0aGUgZGlzcGxheSBpcwo+IHR1cm5lZCBvZmYgd2hlbiB0
aGUgbGFzdCB1c2VyIGlzIGNsb3NpbmcuIGZiY29uIGlzIGEgdXNlciBpbiB0aGlzIGNvbnRleHQu
Cj4gCj4gSWYgc3RydWN0IGZiX29wcyBpcyBkZWZpbmVkIGluIGEgbGlicmFyeSwgZmJfb3Blbigp
IHRha2VzIGEgcmVmIG9uIHRoZQo+IGxpYnJhcnkgKGZiX29wcy5vd25lcikgaW5zdGVhZCBvZiB0
aGUgZHJpdmVyIG1vZHVsZS4gRml4IHRoYXQgYnkgZW5zdXJpbmcKPiB0aGF0IHRoZSBkcml2ZXIg
bW9kdWxlIGlzIHBpbm5lZC4KPiAKPiBUaGUgZnVuY3Rpb25zIGFyZSBub3QgYWRkZWQgdG8gdGhl
IERSTV9GQl9IRUxQRVJfREVGQVVMVF9PUFMoKSBtYWNybywKPiBiZWNhdXNlIHNvbWUgb2YgaXRz
IHVzZXJzIGRvIHNldCBmYl9vcGVuL3JlbGVhc2UgdGhlbXNlbHZlcy4KPiAKPiBTaWduZWQtb2Zm
LWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiAtLS0KPiAgZHJpdmVy
cy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyB8IDU0ICsrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKystCj4gIGluY2x1ZGUvZHJtL2RybV9mYl9oZWxwZXIuaCAgICAgfCAyOSAr
KysrKysrKysrKysrKysrKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgODIgaW5zZXJ0aW9ucygr
KSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Zi
X2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+IGluZGV4IDk4ZTVi
YzkyYzlmMi4uYjExMjRjMDhiMWVkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f
ZmJfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gQEAg
LTE3Nyw3ICsxNzcsNyBAQCBpbnQgZHJtX2ZiX2hlbHBlcl9yZXN0b3JlX2ZiZGV2X21vZGVfdW5s
b2NrZWQoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcikKPiAgCWlmICghZHJtX2ZiZGV2
X2VtdWxhdGlvbiB8fCAhZmJfaGVscGVyKQo+ICAJCXJldHVybiAtRU5PREVWOwo+ICAKPiAtCWlm
IChSRUFEX09OQ0UoZmJfaGVscGVyLT5kZWZlcnJlZF9zZXR1cCkpCj4gKwlpZiAoUkVBRF9PTkNF
KGZiX2hlbHBlci0+ZGVmZXJyZWRfc2V0dXApIHx8ICFSRUFEX09OQ0UoZmJfaGVscGVyLT5vcGVu
X2NvdW50KSkKPiAgCQlyZXR1cm4gMDsKPiAgCj4gIAltdXRleF9sb2NrKCZmYl9oZWxwZXItPmxv
Y2spOwo+IEBAIC0zNjgsNiArMzY4LDcgQEAgdm9pZCBkcm1fZmJfaGVscGVyX3ByZXBhcmUoc3Ry
dWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgCUlO
SVRfV09SSygmaGVscGVyLT5kaXJ0eV93b3JrLCBkcm1fZmJfaGVscGVyX2RpcnR5X3dvcmspOwo+
ICAJaGVscGVyLT5kaXJ0eV9jbGlwLngxID0gaGVscGVyLT5kaXJ0eV9jbGlwLnkxID0gfjA7Cj4g
IAltdXRleF9pbml0KCZoZWxwZXItPmxvY2spOwo+ICsJaGVscGVyLT5vcGVuX2NvdW50ID0gMTsK
PiAgCWhlbHBlci0+ZnVuY3MgPSBmdW5jczsKPiAgCWhlbHBlci0+ZGV2ID0gZGV2Owo+ICB9Cj4g
QEAgLTYyMCw2ICs2MjEsNTMgQEAgaW50IGRybV9mYl9oZWxwZXJfZGVmaW9faW5pdChzdHJ1Y3Qg
ZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKQo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2ZiX2hl
bHBlcl9kZWZpb19pbml0KTsKPiAgCj4gKy8qKgo+ICsgKiBkcm1fZmJfaGVscGVyX2ZiX29wZW4g
LSBpbXBsZW1lbnRhdGlvbiBmb3IgJmZiX29wcy5mYl9vcGVuCj4gKyAqIEBpbmZvOiBmYmRldiBy
ZWdpc3RlcmVkIGJ5IHRoZSBoZWxwZXIKPiArICogQHVzZXI6IDE9dXNlcnNwYWNlLCAwPWZiY29u
Cj4gKyAqCj4gKyAqIEluY3JlYXNlIGZiZGV2IHVzZSBjb3VudC4KPiArICogSWYgJmZiX29wcyBp
cyB3cmFwcGVkIGluIGEgbGlicmFyeSwgcGluIHRoZSBkcml2ZXIgbW9kdWxlLgo+ICsgKi8KPiAr
aW50IGRybV9mYl9oZWxwZXJfZmJfb3BlbihzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgaW50IHVzZXIp
Cj4gK3sKPiArCXN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIgPSBpbmZvLT5wYXI7Cj4g
KwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZmJfaGVscGVyLT5kZXY7Cj4gKwo+ICsJaWYgKGlu
Zm8tPmZib3BzLT5vd25lciAhPSBkZXYtPmRyaXZlci0+Zm9wcy0+b3duZXIpIHsKPiArCQlpZiAo
IXRyeV9tb2R1bGVfZ2V0KGRldi0+ZHJpdmVyLT5mb3BzLT5vd25lcikpCj4gKwkJCXJldHVybiAt
RU5PREVWOwo+ICsJfQo+ICsKPiArCWZiX2hlbHBlci0+b3Blbl9jb3VudCsrOwo+ICsKPiArCXJl
dHVybiAwOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2ZiX2hlbHBlcl9mYl9vcGVuKTsKPiAr
Cj4gKy8qKgo+ICsgKiBkcm1fZmJfaGVscGVyX2ZiX3JlbGVhc2UgLSBpbXBsZW1lbnRhdGlvbiBm
b3IgJmZiX29wcy5mYl9yZWxlYXNlCj4gKyAqIEBpbmZvOiBmYmRldiByZWdpc3RlcmVkIGJ5IHRo
ZSBoZWxwZXIKPiArICogQHVzZXI6IDE9dXNlcnNwYWNlLCAwPWZiY29uCj4gKyAqCj4gKyAqIERl
Y3JlYXNlIGZiZGV2IHVzZSBjb3VudCBhbmQgdHVybiBvZmYgaWYgdGhlcmUgYXJlIG5vIHVzZXJz
IGxlZnQuCj4gKyAqIElmICZmYl9vcHMgaXMgd3JhcHBlZCBpbiBhIGxpYnJhcnksIHVucGluIHRo
ZSBkcml2ZXIgbW9kdWxlLgo+ICsgKi8KPiAraW50IGRybV9mYl9oZWxwZXJfZmJfcmVsZWFzZShz
dHJ1Y3QgZmJfaW5mbyAqaW5mbywgaW50IHVzZXIpCj4gK3sKPiArCXN0cnVjdCBkcm1fZmJfaGVs
cGVyICpmYl9oZWxwZXIgPSBpbmZvLT5wYXI7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0g
ZmJfaGVscGVyLT5kZXY7Cj4gKwo+ICsJaWYgKCEoLS1mYl9oZWxwZXItPm9wZW5fY291bnQpKQo+
ICsJCWRybV9mYl9oZWxwZXJfZHBtcyhpbmZvLCBEUk1fTU9ERV9EUE1TX09GRik7Cj4gKwo+ICsJ
aWYgKGluZm8tPmZib3BzLT5vd25lciAhPSBkZXYtPmRyaXZlci0+Zm9wcy0+b3duZXIpCj4gKwkJ
bW9kdWxlX3B1dChkZXYtPmRyaXZlci0+Zm9wcy0+b3duZXIpOwo+ICsKPiArCXJldHVybiAwOwo+
ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2ZiX2hlbHBlcl9mYl9yZWxlYXNlKTsKPiArCj4gIC8q
Kgo+ICAgKiBkcm1fZmJfaGVscGVyX3N5c19yZWFkIC0gd3JhcHBlciBhcm91bmQgZmJfc3lzX3Jl
YWQKPiAgICogQGluZm86IGZiX2luZm8gc3RydWN0IHBvaW50ZXIKPiBAQCAtMTQzNiw2ICsxNDg0
LDEwIEBAIHN0YXRpYyBpbnQgZHJtX2ZiX2hlbHBlcl9zaW5nbGVfZmJfcHJvYmUoc3RydWN0IGRy
bV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKPiAgCWlmIChyZXQgPCAwKQo+ICAJCXJldHVybiByZXQ7
Cj4gIAo+ICsJLyogQmxvY2sgcmVzdG9yZSB3aXRob3V0IHVzZXJzIGlmIHdlIGRvIHRyYWNrIGl0
ICovCj4gKwlpZiAoZmJfaGVscGVyLT5mYmRldi0+ZmJvcHMtPmZiX29wZW4gPT0gZHJtX2ZiX2hl
bHBlcl9mYl9vcGVuKQo+ICsJCWZiX2hlbHBlci0+b3Blbl9jb3VudCA9IDA7CgpTaW5jZSB3ZSBr
emNhbGxvYywgaXNuJ3QgdGhpcyBlbnRpcmVseSByZWR1bmRhbnQ/IExvb2tzIGNvbmZ1c2luZyB0
byBtZSBhdApsZWFzdC4KCk90aGVyd2lzZSBsb29rcyBhbGwgcmVhc29uYWJsZS4KLURhbmllbAoK
Cj4gKwo+ICAJc3RyY3B5KGZiX2hlbHBlci0+ZmItPmNvbW0sICJbZmJjb25dIik7Cj4gIAlyZXR1
cm4gMDsKPiAgfQo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmggYi9p
bmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmgKPiBpbmRleCA1ZjY2ZjI1M2E5N2IuLjMzMDk4Mzk3
NWQ1ZSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmgKPiArKysgYi9p
bmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmgKPiBAQCAtMTg0LDYgKzE4NCwyMiBAQCBzdHJ1Y3Qg
ZHJtX2ZiX2hlbHBlciB7Cj4gIAkgKiBTZWUgYWxzbzogQGRlZmVycmVkX3NldHVwCj4gIAkgKi8K
PiAgCWludCBwcmVmZXJyZWRfYnBwOwo+ICsKPiArCS8qKgo+ICsJICogQG9wZW5fY291bnQ6Cj4g
KwkgKgo+ICsJICogS2VlcHMgdHJhY2sgb2YgZmJkZXYgdXNlIHRvIGtub3cgd2hlbiB0byBub3Qg
cmVzdG9yZSBmYmRldiBhbmQgdG8KPiArCSAqIGRpc2FibGUgdGhlIHBpcGVsaW5lIHdoZW4gdGhl
IGxhc3QgdXNlciBpcyBnb25lLgo+ICsJICoKPiArCSAqIERyaXZlcnMgdGhhdCB1c2UgZHJtX2Zi
X2hlbHBlcl9mYl9vcGVuKCkgYXMgdGhlaXIgXC5mYl9vcGVuCj4gKwkgKiBjYWxsYmFjayB3aWxs
IGdldCBhbiBpbml0aWFsIHZhbHVlIG9mIDAgYW5kIGdldCByZXN0b3JlIGJhc2VkIG9uCj4gKwkg
KiBhY3R1YWwgdXNlLiBPdGhlcnMgd2lsbCBnZXQgYW4gaW5pdGlhbCB2YWx1ZSBvZiAxIHdoaWNo
IG1lYW5zIHRoYXQKPiArCSAqIGZiZGV2IHdpbGwgYWx3YXlzIGJlIHJlc3RvcmVkLiBEcml2ZXJz
IHRoYXQgY2FsbAo+ICsJICogZHJtX2ZiX2hlbHBlcl9mYl9vcGVuKCkgaW4gdGhlaXIgXC5mYl9v
cGVuLCB0aHVzIG5lZWRzIHRvIHNldCB0aGUKPiArCSAqIGluaXRpYWwgdmFsdWUgdG8gMCB0aGVt
c2VsdmVzIGluIHRoZWlyICZkcm1fZmJfaGVscGVyX2Z1bmNzLT5mYl9wcm9iZQo+ICsJICogY2Fs
bGJhY2suCj4gKwkgKi8KPiArCXVuc2lnbmVkIGludCBvcGVuX2NvdW50Owo+ICB9Owo+ICAKPiAg
LyoqCj4gQEAgLTIzMCw2ICsyNDYsOSBAQCB2b2lkIGRybV9mYl9oZWxwZXJfZGVmZXJyZWRfaW8o
c3RydWN0IGZiX2luZm8gKmluZm8sCj4gIAkJCSAgICAgICBzdHJ1Y3QgbGlzdF9oZWFkICpwYWdl
bGlzdCk7Cj4gIGludCBkcm1fZmJfaGVscGVyX2RlZmlvX2luaXQoc3RydWN0IGRybV9mYl9oZWxw
ZXIgKmZiX2hlbHBlcik7Cj4gIAo+ICtpbnQgZHJtX2ZiX2hlbHBlcl9mYl9vcGVuKHN0cnVjdCBm
Yl9pbmZvICppbmZvLCBpbnQgdXNlcik7Cj4gK2ludCBkcm1fZmJfaGVscGVyX2ZiX3JlbGVhc2Uo
c3RydWN0IGZiX2luZm8gKmluZm8sIGludCB1c2VyKTsKPiArCj4gIHNzaXplX3QgZHJtX2ZiX2hl
bHBlcl9zeXNfcmVhZChzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgY2hhciBfX3VzZXIgKmJ1ZiwKPiAg
CQkJICAgICAgIHNpemVfdCBjb3VudCwgbG9mZl90ICpwcG9zKTsKPiAgc3NpemVfdCBkcm1fZmJf
aGVscGVyX3N5c193cml0ZShzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgY29uc3QgY2hhciBfX3VzZXIg
KmJ1ZiwKPiBAQCAtMzc2LDYgKzM5NSwxNiBAQCBzdGF0aWMgaW5saW5lIGludCBkcm1fZmJfaGVs
cGVyX2RlZmlvX2luaXQoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcikKPiAgCXJldHVy
biAtRU5PREVWOwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW5saW5lIGludCBkcm1fZmJfaGVscGVyX2Zi
X29wZW4oc3RydWN0IGZiX2luZm8gKmluZm8sIGludCB1c2VyKQo+ICt7Cj4gKwlyZXR1cm4gLUVO
T0RFVjsKPiArfQo+ICsKPiArc3RhdGljIGlubGluZSBpbnQgZHJtX2ZiX2hlbHBlcl9mYl9yZWxl
YXNlKHN0cnVjdCBmYl9pbmZvICppbmZvLCBpbnQgdXNlcikKPiArewo+ICsJcmV0dXJuIC1FTk9E
RVY7Cj4gK30KPiArCj4gIHN0YXRpYyBpbmxpbmUgc3NpemVfdCBkcm1fZmJfaGVscGVyX3N5c19y
ZWFkKHN0cnVjdCBmYl9pbmZvICppbmZvLAo+ICAJCQkJCSAgICAgY2hhciBfX3VzZXIgKmJ1Ziwg
c2l6ZV90IGNvdW50LAo+ICAJCQkJCSAgICAgbG9mZl90ICpwcG9zKQo+IC0tIAo+IDIuMTUuMQo+
IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50
ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBo
dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoK
LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0
dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr
dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu
dGVsLWdmeAo=