From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH hwc v2 12/18] drm_hwcomposer: Add utility function to create an initialized composition Date: Tue, 17 Apr 2018 12:37:15 -0400 Message-ID: <20180417163715.GH73214@art_vandelay> References: <1523460149-1740-1-git-send-email-alexandru-cosmin.gheorghe@arm.com> <1523460149-1740-13-git-send-email-alexandru-cosmin.gheorghe@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb0-x243.google.com (mail-yb0-x243.google.com [IPv6:2607:f8b0:4002:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 579B36E0F8 for ; Tue, 17 Apr 2018 16:37:17 +0000 (UTC) Received: by mail-yb0-x243.google.com with SMTP id b14-v6so8815756ybk.1 for ; Tue, 17 Apr 2018 09:37:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1523460149-1740-13-git-send-email-alexandru-cosmin.gheorghe@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru Gheorghe Cc: ayan.halder@arm.com, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, nd@arm.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMTEsIDIwMTggYXQgMDQ6MjI6MjNQTSArMDEwMCwgQWxleGFuZHJ1IEdoZW9y Z2hlIHdyb3RlOgo+IFRoZXJlIGlzIGEgbG90IG9mIGJvaWxlcnBsYXRlIGZvciBjcmVhdGluZyBh biBpbml0aWFsaXplZAo+IGRybWRpc3BsYXljb21wb3NpdGlvbi4gVGhpcyBwYXRjaCBnYXRoZXJz IHRoYXQgaW4gYSBzZXBhcmF0ZSBtZXRob2QuCj4gCj4gU2lnbmVkLW9mZi1ieTogQWxleGFuZHJ1 IEdoZW9yZ2hlIDxhbGV4YW5kcnUtY29zbWluLmdoZW9yZ2hlQGFybS5jb20+Cj4gLS0tCj4gIGRy bWRpc3BsYXljb21wb3NpdG9yLmNwcCB8IDIzICsrKysrKysrKysrKysrKysrKysrKysrCj4gIGRy bWRpc3BsYXljb21wb3NpdG9yLmggICB8ICAyICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjUgaW5z ZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcm1kaXNwbGF5Y29tcG9zaXRvci5jcHAgYi9k cm1kaXNwbGF5Y29tcG9zaXRvci5jcHAKPiBpbmRleCBlNTU2ZTg2Li42ZTViZTI0IDEwMDY0NAo+ IC0tLSBhL2RybWRpc3BsYXljb21wb3NpdG9yLmNwcAo+ICsrKyBiL2RybWRpc3BsYXljb21wb3Np dG9yLmNwcAo+IEBAIC0yMjEsNiArMjIxLDcgQEAgaW50IERybURpc3BsYXlDb21wb3NpdG9yOjpJ bml0KERybVJlc291cmNlcyAqZHJtLCBpbnQgZGlzcGxheSkgewo+ICAgICAgQUxPR0UoIkZhaWxl ZCB0byBpbml0aWFsaXplIGRybSBjb21wb3NpdG9yIGxvY2sgJWRcbiIsIHJldCk7Cj4gICAgICBy ZXR1cm4gcmV0Owo+ICAgIH0KPiArICBwbGFubmVyXyA9IFBsYW5uZXI6OkNyZWF0ZUluc3RhbmNl KGRybSk7CgpXaGF0J3MgdGhpcz8KCj4gIAo+ICAgIGluaXRpYWxpemVkXyA9IHRydWU7Cj4gICAg cmV0dXJuIDA7Cj4gQEAgLTIzMSw2ICsyMzIsMjggQEAgc3RkOjp1bmlxdWVfcHRyPERybURpc3Bs YXlDb21wb3NpdGlvbj4gRHJtRGlzcGxheUNvbXBvc2l0b3I6OkNyZWF0ZUNvbXBvc2l0aW9uKCkK PiAgICByZXR1cm4gc3RkOjp1bmlxdWVfcHRyPERybURpc3BsYXlDb21wb3NpdGlvbj4obmV3IERy bURpc3BsYXlDb21wb3NpdGlvbigpKTsKPiAgfQo+ICAKPiArc3RkOjp1bmlxdWVfcHRyPERybURp c3BsYXlDb21wb3NpdGlvbj4KPiArRHJtRGlzcGxheUNvbXBvc2l0b3I6OkNyZWF0ZUluaXRpYWxp emVkQ29tcG9zaXRpb24oKSBjb25zdCB7Cj4gKyAgRHJtQ3J0YyAqY3J0YyA9IGRybV8tPkdldENy dGNGb3JEaXNwbGF5KGRpc3BsYXlfKTsKPiArICBpZiAoIWNydGMpIHsKPiArICAgIEFMT0dFKCJG YWlsZWQgdG8gZmluZCBjcnRjIGZvciBkaXNwbGF5ID0gJWQiLCBkaXNwbGF5Xyk7Cj4gKyAgICBy ZXR1cm4gc3RkOjp1bmlxdWVfcHRyPERybURpc3BsYXlDb21wb3NpdGlvbj4oKTsKPiArICB9Cj4g KyAgc3RkOjp1bmlxdWVfcHRyPERybURpc3BsYXlDb21wb3NpdGlvbj4gY29tcCA9IENyZWF0ZUNv bXBvc2l0aW9uKCk7Cj4gKyAgc3RkOjpzaGFyZWRfcHRyPEltcG9ydGVyPiBpbXBvcnRlciA9Cj4g KyAgICAgIGRybV8tPnJlc291cmNlX21hbmFnZXIoKS0+R2V0SW1wb3J0ZXIoZGlzcGxheV8pOwo+ ICsgIGlmICghaW1wb3J0ZXIpIHsKPiArICAgIEFMT0dFKCJGYWlsZWQgdG8gZmluZCByZXNvdXJj ZXMgZm9yIGRpc3BsYXkgPSAlZCIsIGRpc3BsYXlfKTsKPiArICAgIHJldHVybiBzdGQ6OnVuaXF1 ZV9wdHI8RHJtRGlzcGxheUNvbXBvc2l0aW9uPigpOwo+ICsgIH0KPiArICBpbnQgcmV0ID0gY29t cC0+SW5pdChkcm1fLCBjcnRjLCBpbXBvcnRlci5nZXQoKSwgcGxhbm5lcl8uZ2V0KCksIDApOwo+ ICsgIGlmIChyZXQpIHsKPiArICAgIEFMT0dFKCJGYWlsZWQgdG8gaW5pdCBjb21wb3NpdGlvbiBm b3IgZGlzcGxheSA9ICVkIiwgZGlzcGxheV8pOwo+ICsgICAgcmV0dXJuIHN0ZDo6dW5pcXVlX3B0 cjxEcm1EaXNwbGF5Q29tcG9zaXRpb24+KCk7Cj4gKyAgfQo+ICsgIHJldHVybiBjb21wOwo+ICt9 Cj4gKwoKVGhpcyBzZWVtcyBzdWZmaWNpZW50bHkgc21hbGwgdGhhdCB5b3UgY2FuIHNxdWFzaCBp dCBpbnRvIHRoZSBwYXRjaCB0aGF0IHVzZXMKaXQuIFRoZSBzYW1lIGNhbiBiZSBzYWlkIGZvciBz b21lIG9mIHRoZSBvdGhlciAiQWRkIGZ1bmN0aW9uIHRvIGRvIFgiIHdoaWNoCmRvbid0IHVzZSB0 aGUgZnVuY3Rpb24uCgo+ICBzdGQ6OnR1cGxlPHVpbnQzMl90LCB1aW50MzJfdCwgaW50Pgo+ICBE cm1EaXNwbGF5Q29tcG9zaXRvcjo6R2V0QWN0aXZlTW9kZVJlc29sdXRpb24oKSB7Cj4gICAgRHJt Q29ubmVjdG9yICpjb25uZWN0b3IgPSBkcm1fLT5HZXRDb25uZWN0b3JGb3JEaXNwbGF5KGRpc3Bs YXlfKTsKPiBkaWZmIC0tZ2l0IGEvZHJtZGlzcGxheWNvbXBvc2l0b3IuaCBiL2RybWRpc3BsYXlj b21wb3NpdG9yLmgKPiBpbmRleCBmMTk2NWZiLi5jY2FmZmI0IDEwMDY0NAo+IC0tLSBhL2RybWRp c3BsYXljb21wb3NpdG9yLmgKPiArKysgYi9kcm1kaXNwbGF5Y29tcG9zaXRvci5oCj4gQEAgLTg3 LDYgKzg3LDcgQEAgY2xhc3MgRHJtRGlzcGxheUNvbXBvc2l0b3Igewo+ICAgIGludCBJbml0KERy bVJlc291cmNlcyAqZHJtLCBpbnQgZGlzcGxheSk7Cj4gIAo+ICAgIHN0ZDo6dW5pcXVlX3B0cjxE cm1EaXNwbGF5Q29tcG9zaXRpb24+IENyZWF0ZUNvbXBvc2l0aW9uKCkgY29uc3Q7Cj4gKyAgc3Rk Ojp1bmlxdWVfcHRyPERybURpc3BsYXlDb21wb3NpdGlvbj4gQ3JlYXRlSW5pdGlhbGl6ZWRDb21w b3NpdGlvbigpIGNvbnN0Owo+ICAgIGludCBBcHBseUNvbXBvc2l0aW9uKHN0ZDo6dW5pcXVlX3B0 cjxEcm1EaXNwbGF5Q29tcG9zaXRpb24+IGNvbXBvc2l0aW9uKTsKPiAgICBpbnQgQ29tcG9zaXRl KCk7Cj4gICAgaW50IFNxdWFzaEFsbCgpOwo+IEBAIC0xNTUsNiArMTU2LDcgQEAgY2xhc3MgRHJt RGlzcGxheUNvbXBvc2l0b3Igewo+ICAgIC8vIHdlIG5lZWQgdG8gcmVzZXQgdGhlbSBvbiBldmVy eSBEdW1wKCkgY2FsbC4KPiAgICBtdXRhYmxlIHVpbnQ2NF90IGR1bXBfZnJhbWVzX2NvbXBvc2l0 ZWRfOwo+ICAgIG11dGFibGUgdWludDY0X3QgZHVtcF9sYXN0X3RpbWVzdGFtcF9uc187Cj4gKyAg c3RkOjp1bmlxdWVfcHRyPFBsYW5uZXI+IHBsYW5uZXJfOwo+ICB9Owo+ICB9Cj4gIAo+IC0tIAo+ IDIuNy40Cj4gCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hy b21pdW0gT1MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==