From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH hwc v2 14/18] drm_hwcomposer: Fix race in ApplyFrame Date: Tue, 17 Apr 2018 13:02:18 -0400 Message-ID: <20180417170218.GJ73214@art_vandelay> References: <1523460149-1740-1-git-send-email-alexandru-cosmin.gheorghe@arm.com> <1523460149-1740-15-git-send-email-alexandru-cosmin.gheorghe@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb0-x243.google.com (mail-yb0-x243.google.com [IPv6:2607:f8b0:4002:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A2896E14F for ; Tue, 17 Apr 2018 17:02:21 +0000 (UTC) Received: by mail-yb0-x243.google.com with SMTP id k199-v6so8828267ybk.12 for ; Tue, 17 Apr 2018 10:02:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1523460149-1740-15-git-send-email-alexandru-cosmin.gheorghe@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru Gheorghe Cc: ayan.halder@arm.com, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, nd@arm.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMTEsIDIwMTggYXQgMDQ6MjI6MjVQTSArMDEwMCwgQWxleGFuZHJ1IEdoZW9y Z2hlIHdyb3RlOgo+IEFwcGx5RnJhbWUgaG9sZHMgdGhlIGxvY2sganVzdCB3aGVuIGl0IHN3YXBz IHRoZSB2YWx1ZSBvZgo+IGFjdGl2ZV9jb21wb3NpdGlvbl8sIGluIGEgbXVsdGl0aHJlYWQgY29u dGV4dCB3ZSBjb3VsZCBlbmQgdXAgaW4gYQo+IHNpdHVhdGlvbiB3aGVyZSBzb21ldGhpbmcgaXMg c2hvd24gb24gdGhlIHNjcmVlbiwgYnV0IHNvbWV0aGluZyBlbHNlCj4gaXMgc2V0IGluIGFjdGl2 ZV9jb21wb3NpdGlvbl8uIEZpeCBpdCBieSBob2xkaW5nIHRoZSBsb2NrIGR1cmluZwo+IENvbW1p dEZyYW1lLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFsZXhhbmRydSBHaGVvcmdoZSA8YWxleGFuZHJ1 LWNvc21pbi5naGVvcmdoZUBhcm0uY29tPgo+IC0tLQo+ICBkcm1kaXNwbGF5Y29tcG9zaXRvci5j cHAgfCA0MCArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRybWRp c3BsYXljb21wb3NpdG9yLmggICB8ICAyICstCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0 aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RybWRpc3BsYXljb21w b3NpdG9yLmNwcCBiL2RybWRpc3BsYXljb21wb3NpdG9yLmNwcAo+IGluZGV4IGFmZDNiMDUuLjU3 NjUzOWIgMTAwNjQ0Cj4gLS0tIGEvZHJtZGlzcGxheWNvbXBvc2l0b3IuY3BwCj4gKysrIGIvZHJt ZGlzcGxheWNvbXBvc2l0b3IuY3BwCj4gQEAgLTc5MSwxMSArNzkxLDYgQEAgc3RkOjp0dXBsZTxp bnQsIHVpbnQzMl90PiBEcm1EaXNwbGF5Q29tcG9zaXRvcjo6Q3JlYXRlTW9kZUJsb2IoCj4gIH0K PiAgCj4gIHZvaWQgRHJtRGlzcGxheUNvbXBvc2l0b3I6OkNsZWFyRGlzcGxheSgpIHsKPiAtICBB dXRvTG9jayBsb2NrKCZsb2NrXywgImNvbXBvc2l0b3IiKTsKPiAtICBpbnQgcmV0ID0gbG9jay5M b2NrKCk7Cj4gLSAgaWYgKHJldCkKPiAtICAgIHJldHVybjsKPiAtCj4gICAgaWYgKCFhY3RpdmVf Y29tcG9zaXRpb25fKQo+ICAgICAgcmV0dXJuOwo+ICAKPiBAQCAtODA4LDExICs4MDMsMjUgQEAg dm9pZCBEcm1EaXNwbGF5Q29tcG9zaXRvcjo6Q2xlYXJEaXNwbGF5KCkgewo+ICB9Cj4gIAo+ICB2 b2lkIERybURpc3BsYXlDb21wb3NpdG9yOjpBcHBseUZyYW1lKAo+IC0gICAgc3RkOjp1bmlxdWVf cHRyPERybURpc3BsYXlDb21wb3NpdGlvbj4gY29tcG9zaXRpb24sIGludCBzdGF0dXMpIHsKPiAr ICAgIHN0ZDo6dW5pcXVlX3B0cjxEcm1EaXNwbGF5Q29tcG9zaXRpb24+IGNvbXBvc2l0aW9uLCBp bnQgc3RhdHVzLAo+ICsgICAgYm9vbCB3cml0ZWJhY2spIHsKClRoZSB3cml0ZWJhY2sgYXJndW1l bnQgYWRkaXRpb24gc2VlbXMgdW5yZWxhdGVkIHRvIHRoaXMgY2hhbmdlLgoKPiArICBBdXRvTG9j ayBsb2NrKCZsb2NrXywgX19GVU5DVElPTl9fKTsKPiArICBpZiAobG9jay5Mb2NrKCkpCj4gKyAg ICByZXR1cm47Cj4gICAgaW50IHJldCA9IHN0YXR1czsKPiAtCj4gLSAgaWYgKCFyZXQpCj4gKyAg aWYgKCFyZXQpIHsKPiArICAgIGlmICh3cml0ZWJhY2sgJiYgIUNvdW50ZG93bkV4cGlyZWQoKSkg ewo+ICsgICAgICBBTE9HRSgiQWJvcnQgcGxheWluZyBiYWNrIHNjZW5lIik7Cj4gKyAgICAgIHJl dHVybjsKPiArICAgIH0KPiAgICAgIHJldCA9IENvbW1pdEZyYW1lKGNvbXBvc2l0aW9uLmdldCgp LCBmYWxzZSk7Cj4gKyAgICBpZiAoIXJldCkgewo+ICsgICAgICArK2R1bXBfZnJhbWVzX2NvbXBv c2l0ZWRfOwo+ICsgICAgICBpZiAoYWN0aXZlX2NvbXBvc2l0aW9uXykKPiArICAgICAgICBhY3Rp dmVfY29tcG9zaXRpb25fLT5TaWduYWxDb21wb3NpdGlvbkRvbmUoKTsKPiArICAgICAgYWN0aXZl X2NvbXBvc2l0aW9uXy5zd2FwKGNvbXBvc2l0aW9uKTsKCldoeSBtb3ZlIHRoaXMgc3R1ZmY/Cgo+ ICsgICAgfQo+ICsgIH0KPiAgCj4gICAgaWYgKHJldCkgewo+ICAgICAgQUxPR0UoIkNvbXBvc2l0 ZSBmYWlsZWQgZm9yIGRpc3BsYXkgJWQiLCBkaXNwbGF5Xyk7Cj4gQEAgLTgyMSwyMSArODMwLDYg QEAgdm9pZCBEcm1EaXNwbGF5Q29tcG9zaXRvcjo6QXBwbHlGcmFtZSgKPiAgICAgIENsZWFyRGlz cGxheSgpOwo+ICAgICAgcmV0dXJuOwo+ICAgIH0KPiAtICArK2R1bXBfZnJhbWVzX2NvbXBvc2l0 ZWRfOwo+IC0KPiAtICBpZiAoYWN0aXZlX2NvbXBvc2l0aW9uXykKPiAtICAgIGFjdGl2ZV9jb21w b3NpdGlvbl8tPlNpZ25hbENvbXBvc2l0aW9uRG9uZSgpOwo+IC0KPiAtICByZXQgPSBwdGhyZWFk X211dGV4X2xvY2soJmxvY2tfKTsKPiAtICBpZiAocmV0KQo+IC0gICAgQUxPR0UoIkZhaWxlZCB0 byBhY3F1aXJlIGxvY2sgZm9yIGFjdGl2ZV9jb21wb3NpdGlvbiBzd2FwIik7Cj4gLQo+IC0gIGFj dGl2ZV9jb21wb3NpdGlvbl8uc3dhcChjb21wb3NpdGlvbik7Cj4gLQo+IC0gIGlmICghcmV0KQo+ IC0gICAgcmV0ID0gcHRocmVhZF9tdXRleF91bmxvY2soJmxvY2tfKTsKPiAtICBpZiAocmV0KQo+ IC0gICAgQUxPR0UoIkZhaWxlZCB0byByZWxlYXNlIGxvY2sgZm9yIGFjdGl2ZV9jb21wb3NpdGlv biBzd2FwIik7Cj4gIH0KPiAgCj4gIGludCBEcm1EaXNwbGF5Q29tcG9zaXRvcjo6QXBwbHlDb21w b3NpdGlvbigKPiBkaWZmIC0tZ2l0IGEvZHJtZGlzcGxheWNvbXBvc2l0b3IuaCBiL2RybWRpc3Bs YXljb21wb3NpdG9yLmgKPiBpbmRleCAwZjhkYWFkLi5iMzVlZjcwIDEwMDY0NAo+IC0tLSBhL2Ry bWRpc3BsYXljb21wb3NpdG9yLmgKPiArKysgYi9kcm1kaXNwbGF5Y29tcG9zaXRvci5oCj4gQEAg LTEyNyw3ICsxMjcsNyBAQCBjbGFzcyBEcm1EaXNwbGF5Q29tcG9zaXRvciB7Cj4gIAo+ICAgIHZv aWQgQ2xlYXJEaXNwbGF5KCk7Cj4gICAgdm9pZCBBcHBseUZyYW1lKHN0ZDo6dW5pcXVlX3B0cjxE cm1EaXNwbGF5Q29tcG9zaXRpb24+IGNvbXBvc2l0aW9uLAo+IC0gICAgICAgICAgICAgICAgICBp bnQgc3RhdHVzKTsKPiArICAgICAgICAgICAgICAgICAgaW50IHN0YXR1cywgYm9vbCB3cml0ZWJh Y2sgPSBmYWxzZSk7Cj4gIAo+ICAgIHN0ZDo6dHVwbGU8aW50LCB1aW50MzJfdD4gQ3JlYXRlTW9k ZUJsb2IoY29uc3QgRHJtTW9kZSAmbW9kZSk7Cj4gIAo+IC0tIAo+IDIuNy40Cj4gCgotLSAKU2Vh biBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==