From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandru-Cosmin Gheorghe Subject: Re: [PATCH hwc v2 12/18] drm_hwcomposer: Add utility function to create an initialized composition Date: Wed, 18 Apr 2018 11:29:48 +0100 Message-ID: <20180418102948.GC10633@e114479-lin.cambridge.arm.com> References: <1523460149-1740-1-git-send-email-alexandru-cosmin.gheorghe@arm.com> <1523460149-1740-13-git-send-email-alexandru-cosmin.gheorghe@arm.com> <20180417163715.GH73214@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on060f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe02::60f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34E556E55F for ; Wed, 18 Apr 2018 10:29:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180417163715.GH73214@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: nd@arm.com, ayan.halder@arm.com, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBcHIgMTcsIDIwMTggYXQgMTI6Mzc6MTVQTSAtMDQwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IE9uIFdlZCwgQXByIDExLCAyMDE4IGF0IDA0OjIyOjIzUE0gKzAxMDAsIEFsZXhhbmRydSBH aGVvcmdoZSB3cm90ZToKPiA+IFRoZXJlIGlzIGEgbG90IG9mIGJvaWxlcnBsYXRlIGZvciBjcmVh dGluZyBhbiBpbml0aWFsaXplZAo+ID4gZHJtZGlzcGxheWNvbXBvc2l0aW9uLiBUaGlzIHBhdGNo IGdhdGhlcnMgdGhhdCBpbiBhIHNlcGFyYXRlIG1ldGhvZC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1i eTogQWxleGFuZHJ1IEdoZW9yZ2hlIDxhbGV4YW5kcnUtY29zbWluLmdoZW9yZ2hlQGFybS5jb20+ Cj4gPiAtLS0KPiA+ICBkcm1kaXNwbGF5Y29tcG9zaXRvci5jcHAgfCAyMyArKysrKysrKysrKysr KysrKysrKysrKwo+ID4gIGRybWRpc3BsYXljb21wb3NpdG9yLmggICB8ICAyICsrCj4gPiAgMiBm aWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcm1k aXNwbGF5Y29tcG9zaXRvci5jcHAgYi9kcm1kaXNwbGF5Y29tcG9zaXRvci5jcHAKPiA+IGluZGV4 IGU1NTZlODYuLjZlNWJlMjQgMTAwNjQ0Cj4gPiAtLS0gYS9kcm1kaXNwbGF5Y29tcG9zaXRvci5j cHAKPiA+ICsrKyBiL2RybWRpc3BsYXljb21wb3NpdG9yLmNwcAo+ID4gQEAgLTIyMSw2ICsyMjEs NyBAQCBpbnQgRHJtRGlzcGxheUNvbXBvc2l0b3I6OkluaXQoRHJtUmVzb3VyY2VzICpkcm0sIGlu dCBkaXNwbGF5KSB7Cj4gPiAgICAgIEFMT0dFKCJGYWlsZWQgdG8gaW5pdGlhbGl6ZSBkcm0gY29t cG9zaXRvciBsb2NrICVkXG4iLCByZXQpOwo+ID4gICAgICByZXR1cm4gcmV0Owo+ID4gICAgfQo+ ID4gKyAgcGxhbm5lcl8gPSBQbGFubmVyOjpDcmVhdGVJbnN0YW5jZShkcm0pOwo+IAo+IFdoYXQn cyB0aGlzPwoKV2UgbmVlZCBhIHBsYW5uZXIgZm9yIHRoZSBmdW5jdGlvbiBiZWxsb3csIEkgY291 bGQgcmUtd3JpdGUgdGhpcyB0byBiZQphbiBhcmd1bWVudCBvZiBDcmVhdGVDb21wb3NpdGlvbiBp ZiB5b3UgdGhpbmsgdGhhdCBoZWxwcy4KCj4gCj4gPiAgCj4gPiAgICBpbml0aWFsaXplZF8gPSB0 cnVlOwo+ID4gICAgcmV0dXJuIDA7Cj4gPiBAQCAtMjMxLDYgKzIzMiwyOCBAQCBzdGQ6OnVuaXF1 ZV9wdHI8RHJtRGlzcGxheUNvbXBvc2l0aW9uPiBEcm1EaXNwbGF5Q29tcG9zaXRvcjo6Q3JlYXRl Q29tcG9zaXRpb24oKQo+ID4gICAgcmV0dXJuIHN0ZDo6dW5pcXVlX3B0cjxEcm1EaXNwbGF5Q29t cG9zaXRpb24+KG5ldyBEcm1EaXNwbGF5Q29tcG9zaXRpb24oKSk7Cj4gPiAgfQo+ID4gIAo+ID4g K3N0ZDo6dW5pcXVlX3B0cjxEcm1EaXNwbGF5Q29tcG9zaXRpb24+Cj4gPiArRHJtRGlzcGxheUNv bXBvc2l0b3I6OkNyZWF0ZUluaXRpYWxpemVkQ29tcG9zaXRpb24oKSBjb25zdCB7Cj4gPiArICBE cm1DcnRjICpjcnRjID0gZHJtXy0+R2V0Q3J0Y0ZvckRpc3BsYXkoZGlzcGxheV8pOwo+ID4gKyAg aWYgKCFjcnRjKSB7Cj4gPiArICAgIEFMT0dFKCJGYWlsZWQgdG8gZmluZCBjcnRjIGZvciBkaXNw bGF5ID0gJWQiLCBkaXNwbGF5Xyk7Cj4gPiArICAgIHJldHVybiBzdGQ6OnVuaXF1ZV9wdHI8RHJt RGlzcGxheUNvbXBvc2l0aW9uPigpOwo+ID4gKyAgfQo+ID4gKyAgc3RkOjp1bmlxdWVfcHRyPERy bURpc3BsYXlDb21wb3NpdGlvbj4gY29tcCA9IENyZWF0ZUNvbXBvc2l0aW9uKCk7Cj4gPiArICBz dGQ6OnNoYXJlZF9wdHI8SW1wb3J0ZXI+IGltcG9ydGVyID0KPiA+ICsgICAgICBkcm1fLT5yZXNv dXJjZV9tYW5hZ2VyKCktPkdldEltcG9ydGVyKGRpc3BsYXlfKTsKPiA+ICsgIGlmICghaW1wb3J0 ZXIpIHsKPiA+ICsgICAgQUxPR0UoIkZhaWxlZCB0byBmaW5kIHJlc291cmNlcyBmb3IgZGlzcGxh eSA9ICVkIiwgZGlzcGxheV8pOwo+ID4gKyAgICByZXR1cm4gc3RkOjp1bmlxdWVfcHRyPERybURp c3BsYXlDb21wb3NpdGlvbj4oKTsKPiA+ICsgIH0KPiA+ICsgIGludCByZXQgPSBjb21wLT5Jbml0 KGRybV8sIGNydGMsIGltcG9ydGVyLmdldCgpLCBwbGFubmVyXy5nZXQoKSwgMCk7Cj4gPiArICBp ZiAocmV0KSB7Cj4gPiArICAgIEFMT0dFKCJGYWlsZWQgdG8gaW5pdCBjb21wb3NpdGlvbiBmb3Ig ZGlzcGxheSA9ICVkIiwgZGlzcGxheV8pOwo+ID4gKyAgICByZXR1cm4gc3RkOjp1bmlxdWVfcHRy PERybURpc3BsYXlDb21wb3NpdGlvbj4oKTsKPiA+ICsgIH0KPiA+ICsgIHJldHVybiBjb21wOwo+ ID4gK30KPiA+ICsKPiAKPiBUaGlzIHNlZW1zIHN1ZmZpY2llbnRseSBzbWFsbCB0aGF0IHlvdSBj YW4gc3F1YXNoIGl0IGludG8gdGhlIHBhdGNoIHRoYXQgdXNlcwo+IGl0LiBUaGUgc2FtZSBjYW4g YmUgc2FpZCBmb3Igc29tZSBvZiB0aGUgb3RoZXIgIkFkZCBmdW5jdGlvbiB0byBkbyBYIiB3aGlj aAo+IGRvbid0IHVzZSB0aGUgZnVuY3Rpb24uCj4gCj4gPiAgc3RkOjp0dXBsZTx1aW50MzJfdCwg dWludDMyX3QsIGludD4KPiA+ICBEcm1EaXNwbGF5Q29tcG9zaXRvcjo6R2V0QWN0aXZlTW9kZVJl c29sdXRpb24oKSB7Cj4gPiAgICBEcm1Db25uZWN0b3IgKmNvbm5lY3RvciA9IGRybV8tPkdldENv bm5lY3RvckZvckRpc3BsYXkoZGlzcGxheV8pOwo+ID4gZGlmZiAtLWdpdCBhL2RybWRpc3BsYXlj b21wb3NpdG9yLmggYi9kcm1kaXNwbGF5Y29tcG9zaXRvci5oCj4gPiBpbmRleCBmMTk2NWZiLi5j Y2FmZmI0IDEwMDY0NAo+ID4gLS0tIGEvZHJtZGlzcGxheWNvbXBvc2l0b3IuaAo+ID4gKysrIGIv ZHJtZGlzcGxheWNvbXBvc2l0b3IuaAo+ID4gQEAgLTg3LDYgKzg3LDcgQEAgY2xhc3MgRHJtRGlz cGxheUNvbXBvc2l0b3Igewo+ID4gICAgaW50IEluaXQoRHJtUmVzb3VyY2VzICpkcm0sIGludCBk aXNwbGF5KTsKPiA+ICAKPiA+ICAgIHN0ZDo6dW5pcXVlX3B0cjxEcm1EaXNwbGF5Q29tcG9zaXRp b24+IENyZWF0ZUNvbXBvc2l0aW9uKCkgY29uc3Q7Cj4gPiArICBzdGQ6OnVuaXF1ZV9wdHI8RHJt RGlzcGxheUNvbXBvc2l0aW9uPiBDcmVhdGVJbml0aWFsaXplZENvbXBvc2l0aW9uKCkgY29uc3Q7 Cj4gPiAgICBpbnQgQXBwbHlDb21wb3NpdGlvbihzdGQ6OnVuaXF1ZV9wdHI8RHJtRGlzcGxheUNv bXBvc2l0aW9uPiBjb21wb3NpdGlvbik7Cj4gPiAgICBpbnQgQ29tcG9zaXRlKCk7Cj4gPiAgICBp bnQgU3F1YXNoQWxsKCk7Cj4gPiBAQCAtMTU1LDYgKzE1Niw3IEBAIGNsYXNzIERybURpc3BsYXlD b21wb3NpdG9yIHsKPiA+ICAgIC8vIHdlIG5lZWQgdG8gcmVzZXQgdGhlbSBvbiBldmVyeSBEdW1w KCkgY2FsbC4KPiA+ICAgIG11dGFibGUgdWludDY0X3QgZHVtcF9mcmFtZXNfY29tcG9zaXRlZF87 Cj4gPiAgICBtdXRhYmxlIHVpbnQ2NF90IGR1bXBfbGFzdF90aW1lc3RhbXBfbnNfOwo+ID4gKyAg c3RkOjp1bmlxdWVfcHRyPFBsYW5uZXI+IHBsYW5uZXJfOwo+ID4gIH07Cj4gPiAgfQo+ID4gIAo+ ID4gLS0gCj4gPiAyLjcuNAo+ID4gCj4gCj4gLS0gCj4gU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdp bmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKCi0tIApDaGVlcnMsCkFsZXggRwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK