From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: udl: Destroy framebuffer only if it was initialized Date: Tue, 24 Apr 2018 15:04:45 +0200 Message-ID: <20180424130445.GD31310@phenom.ffwll.local> References: <20180420115001.161745-1-lndmrk@chromium.org> <20180420135532.GH73214@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E8386E3E6 for ; Tue, 24 Apr 2018 13:04:49 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id i3so728126wmf.3 for ; Tue, 24 Apr 2018 06:04:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180420135532.GH73214@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Dave Airlie , Emil Lundmark , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMjAsIDIwMTggYXQgMDk6NTU6MzJBTSAtMDQwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IE9uIEZyaSwgQXByIDIwLCAyMDE4IGF0IDAxOjUwOjAxUE0gKzAyMDAsIEVtaWwgTHVuZG1h cmsgd3JvdGU6Cj4gPiBUaGlzIGZpeGVzIGEgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlIHRoYXQg Y2FuIGhhcHBlbiBpZiB0aGUgVURMCj4gPiBkcml2ZXIgaXMgdW5sb2FkZWQgYmVmb3JlIHRoZSBm cmFtZWJ1ZmZlciBpcyBpbml0aWFsaXplZC4gVGhpcyBjYW4KPiA+IGhhcHBlbiBlLmcuIGlmIHRo ZSBVU0IgZGV2aWNlIGlzIHVucGx1Z2dlZCByaWdodCBhZnRlciBpdCB3YXMgcGx1Z2dlZAo+ID4g aW4uCj4gPiAKPiAKPiBKRllJLCBpbiBmdXR1cmUsIGlmIHNvbWVvbmUgbWFrZXMgYSBzdWdnZXN0 aW9uIG9uIGhvdyB0byBmaXggYSBidWcsIGl0J3MgZ29vZAo+IHByYWN0aWNlIHRvIGFkZCBhIFN1 Z2dlc3RlZC1ieSB0YWcgdG8gZ2l2ZSBjcmVkaXQuCj4gCj4gUmV2aWV3ZWQtYnk6IFNlYW4gUGF1 bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgoKSSB0aGluayBhIGJpdCBtb3JlIGRldGFpbCBpbiB0 aGUgY29tbWl0IG1lc3NhZ2Ugb24gd2h5IHRoaXMgaXMgZXZlbgpwb3NzaWJsZSB3b3VsZCBiZSBn b29kLiBJIHRoaW5rIGl0IGNhbiBvbmx5IGhhcHBlbiB3aGVuIHlvdSBvbmx5IHBsdWcgaW4KdGhl IHVkbCwgd2l0aG91dCBhbnl0aGluZyBjb25uZWN0ZWQuCgpJbiB0aGF0IGNhc2UgZmJkZXYgc2V0 dXAgd2lsbCBiZSBkZWxheWVkIHVudGlsIHNvbWV0aGluZyBzaG93cyB1cCAoc28gd2UKZG9uJ3Qg cGluIGEgdG9vIHNtYWxsIGZiIGZvciBpdCwgYSBmZWF0dXJlIHJlcXVlc3RlZCBieSBzb2MgcGVv cGxlKS4gVGhpcwpjYW4gZWFzaWx5IGJlIHRlc3RlZDoKRmlyc3Q6Ci0gcGx1ZyBpbiB1ZGwgZGV2 aWNlCi0gd2FpdCBhIG1pbnV0ZSBvciBzbyAodG8gbWFrZSBpdCBjbGVhciBpdCdzIG5vdCBhIHJh Y2UpCi0gdW5wbHVnCgpBbmQgdGhlbjoKLSBwbHVnIGluIGFuIHVkbCBkZXZpY2UsIGJ1dCB3aXRo IHNvbWV0aGluZyBjb25uZWN0ZWQuCi0gdW5wbHVnIHJpZ2h0IGF3YXkuCgpJIGV4cGVjdCB0aGF0 IGluIHRoZSBmaXJzdCBjYXNlIHlvdSdsbCBhbHdheXMgYmxvdyB1cCwgYnV0IGluIHRoZSAybmQg b25lCnlvdSdsbCBuZXZlciBibG93IHVwIChubyBtYXR0ZXIgaG93IGZhc3QgeW91IHVucGx1Zyku CgpDaGVlcnMsIERhbmllbAoKCgo+IAo+ID4gU2lnbmVkLW9mZi1ieTogRW1pbCBMdW5kbWFyayA8 bG5kbXJrQGNocm9taXVtLm9yZz4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS91ZGwvdWRs X2ZiLmMgfCA4ICsrKysrLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwg MyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS91ZGwv dWRsX2ZiLmMgYi9kcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9mYi5jCj4gPiBpbmRleCAyZWJkYzZk NWE3NmUuLjU3NTRlMzdmNzQxYiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS91ZGwv dWRsX2ZiLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS91ZGwvdWRsX2ZiLmMKPiA+IEBAIC00 MjYsOSArNDI2LDExIEBAIHN0YXRpYyB2b2lkIHVkbF9mYmRldl9kZXN0cm95KHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsCj4gPiAgewo+ID4gIAlkcm1fZmJfaGVscGVyX3VucmVnaXN0ZXJfZmJpKCZ1 ZmJkZXYtPmhlbHBlcik7Cj4gPiAgCWRybV9mYl9oZWxwZXJfZmluaSgmdWZiZGV2LT5oZWxwZXIp Owo+ID4gLQlkcm1fZnJhbWVidWZmZXJfdW5yZWdpc3Rlcl9wcml2YXRlKCZ1ZmJkZXYtPnVmYi5i YXNlKTsKPiA+IC0JZHJtX2ZyYW1lYnVmZmVyX2NsZWFudXAoJnVmYmRldi0+dWZiLmJhc2UpOwo+ ID4gLQlkcm1fZ2VtX29iamVjdF9wdXRfdW5sb2NrZWQoJnVmYmRldi0+dWZiLm9iai0+YmFzZSk7 Cj4gPiArCWlmICh1ZmJkZXYtPnVmYi5vYmopIHsKPiA+ICsJCWRybV9mcmFtZWJ1ZmZlcl91bnJl Z2lzdGVyX3ByaXZhdGUoJnVmYmRldi0+dWZiLmJhc2UpOwo+ID4gKwkJZHJtX2ZyYW1lYnVmZmVy X2NsZWFudXAoJnVmYmRldi0+dWZiLmJhc2UpOwo+ID4gKwkJZHJtX2dlbV9vYmplY3RfcHV0X3Vu bG9ja2VkKCZ1ZmJkZXYtPnVmYi5vYmotPmJhc2UpOwo+ID4gKwl9Cj4gPiAgfQo+ID4gIAo+ID4g IGludCB1ZGxfZmJkZXZfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gLS0gCj4gPiAy LjE3LjAuNDg0LmcwYzg3MjYzMThjLWdvb2cKPiA+IAo+IAo+IC0tIAo+IFNlYW4gUGF1bCwgU29m dHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4g ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0 d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==