* [PATCH] Intel: Add a Kaby Lake PCI ID
@ 2018-04-23 22:08 matthew.s.atwood
2018-04-24 17:42 ` Rodrigo Vivi
0 siblings, 1 reply; 8+ messages in thread
From: matthew.s.atwood @ 2018-04-23 22:08 UTC (permalink / raw)
To: dri-devel; +Cc: Matt Atwood
From: Matt Atwood <matthew.s.atwood@intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
intel/intel_chipset.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
index 01d250e..6b8fd1d 100644
--- a/intel/intel_chipset.h
+++ b/intel/intel_chipset.h
@@ -203,6 +203,7 @@
#define PCI_CHIP_KABYLAKE_ULX_GT2 0x591E
#define PCI_CHIP_KABYLAKE_DT_GT2 0x5912
#define PCI_CHIP_KABYLAKE_M_GT2 0x5917
+#define PCI_CHIP_KABYLAKE_M_GT2 0x591C
#define PCI_CHIP_KABYLAKE_DT_GT1 0x5902
#define PCI_CHIP_KABYLAKE_HALO_GT2 0x591B
#define PCI_CHIP_KABYLAKE_HALO_GT4 0x593B
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Intel: Add a Kaby Lake PCI ID
2018-04-23 22:08 [PATCH] Intel: Add a Kaby Lake PCI ID matthew.s.atwood
@ 2018-04-24 17:42 ` Rodrigo Vivi
2018-04-24 17:46 ` Rodrigo Vivi
0 siblings, 1 reply; 8+ messages in thread
From: Rodrigo Vivi @ 2018-04-24 17:42 UTC (permalink / raw)
To: matthew.s.atwood; +Cc: dri-devel
On Mon, Apr 23, 2018 at 03:08:31PM -0700, matthew.s.atwood@intel.com wrote:
> From: Matt Atwood <matthew.s.atwood@intel.com>
Based on kernel commit '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
(I'm adding this and pushing. Thanks for the patch)
>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> intel/intel_chipset.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
> index 01d250e..6b8fd1d 100644
> --- a/intel/intel_chipset.h
> +++ b/intel/intel_chipset.h
> @@ -203,6 +203,7 @@
> #define PCI_CHIP_KABYLAKE_ULX_GT2 0x591E
> #define PCI_CHIP_KABYLAKE_DT_GT2 0x5912
> #define PCI_CHIP_KABYLAKE_M_GT2 0x5917
> +#define PCI_CHIP_KABYLAKE_M_GT2 0x591C
> #define PCI_CHIP_KABYLAKE_DT_GT1 0x5902
> #define PCI_CHIP_KABYLAKE_HALO_GT2 0x591B
> #define PCI_CHIP_KABYLAKE_HALO_GT4 0x593B
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Intel: Add a Kaby Lake PCI ID
2018-04-24 17:42 ` Rodrigo Vivi
@ 2018-04-24 17:46 ` Rodrigo Vivi
2018-04-24 17:55 ` matthew.s.atwood
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2018-04-24 17:46 UTC (permalink / raw)
To: matthew.s.atwood; +Cc: dri-devel
On Tue, Apr 24, 2018 at 10:42:26AM -0700, Rodrigo Vivi wrote:
> On Mon, Apr 23, 2018 at 03:08:31PM -0700, matthew.s.atwood@intel.com wrote:
> > From: Matt Atwood <matthew.s.atwood@intel.com>
>
> Based on kernel commit '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
>
> (I'm adding this and pushing. Thanks for the patch)
>
> >
> > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
ops... I take it back... sorry
I just reviewed the id and had match the
spec and kernel patch, but I had forgotten here we need a different
identifier for this platform.
You are just redefining the existent one. You need to define a new
one and add enable it.
>
> > ---
> > intel/intel_chipset.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
> > index 01d250e..6b8fd1d 100644
> > --- a/intel/intel_chipset.h
> > +++ b/intel/intel_chipset.h
> > @@ -203,6 +203,7 @@
> > #define PCI_CHIP_KABYLAKE_ULX_GT2 0x591E
> > #define PCI_CHIP_KABYLAKE_DT_GT2 0x5912
> > #define PCI_CHIP_KABYLAKE_M_GT2 0x5917
> > +#define PCI_CHIP_KABYLAKE_M_GT2 0x591C
> > #define PCI_CHIP_KABYLAKE_DT_GT1 0x5902
> > #define PCI_CHIP_KABYLAKE_HALO_GT2 0x591B
> > #define PCI_CHIP_KABYLAKE_HALO_GT4 0x593B
> > --
> > 2.7.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] Intel: Add a Kaby Lake PCI ID
2018-04-24 17:46 ` Rodrigo Vivi
@ 2018-04-24 17:55 ` matthew.s.atwood
2018-04-24 18:18 ` Rodrigo Vivi
2018-04-24 19:05 ` matthew.s.atwood
2018-04-24 19:42 ` matthew.s.atwood
2 siblings, 1 reply; 8+ messages in thread
From: matthew.s.atwood @ 2018-04-24 17:55 UTC (permalink / raw)
To: dri-devel, rodrigo.vivi; +Cc: Matt Atwood
From: Matt Atwood <matthew.s.atwood@intel.com>
v2: name change M -> ULX, add enumeration in KBL ULX
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
intel/intel_chipset.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
index 01d250e..f479bc4 100644
--- a/intel/intel_chipset.h
+++ b/intel/intel_chipset.h
@@ -200,7 +200,8 @@
#define PCI_CHIP_KABYLAKE_ULT_GT2F 0x5921
#define PCI_CHIP_KABYLAKE_ULX_GT1_5 0x5915
#define PCI_CHIP_KABYLAKE_ULX_GT1 0x590E
-#define PCI_CHIP_KABYLAKE_ULX_GT2 0x591E
+#define PCI_CHIP_KABYLAKE_ULX_GT2_0 0x591E
+#define PCI_CHIP_KABYLAKE_ULX_GT2_1 0x591C
#define PCI_CHIP_KABYLAKE_DT_GT2 0x5912
#define PCI_CHIP_KABYLAKE_M_GT2 0x5917
#define PCI_CHIP_KABYLAKE_DT_GT1 0x5902
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Intel: Add a Kaby Lake PCI ID
2018-04-24 17:55 ` matthew.s.atwood
@ 2018-04-24 18:18 ` Rodrigo Vivi
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2018-04-24 18:18 UTC (permalink / raw)
To: matthew.s.atwood; +Cc: dri-devel
On Tue, Apr 24, 2018 at 10:55:05AM -0700, matthew.s.atwood@intel.com wrote:
> From: Matt Atwood <matthew.s.atwood@intel.com>
please add the message:
Based on kernel commit '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
>
> v2: name change M -> ULX, add enumeration in KBL ULX
>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> ---
> intel/intel_chipset.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
> index 01d250e..f479bc4 100644
> --- a/intel/intel_chipset.h
> +++ b/intel/intel_chipset.h
> @@ -200,7 +200,8 @@
> #define PCI_CHIP_KABYLAKE_ULT_GT2F 0x5921
> #define PCI_CHIP_KABYLAKE_ULX_GT1_5 0x5915
> #define PCI_CHIP_KABYLAKE_ULX_GT1 0x590E
> -#define PCI_CHIP_KABYLAKE_ULX_GT2 0x591E
> +#define PCI_CHIP_KABYLAKE_ULX_GT2_0 0x591E
> +#define PCI_CHIP_KABYLAKE_ULX_GT2_1 0x591C
> #define PCI_CHIP_KABYLAKE_DT_GT2 0x5912
> #define PCI_CHIP_KABYLAKE_M_GT2 0x5917
> #define PCI_CHIP_KABYLAKE_DT_GT1 0x5902
The define itself isn't enough... you still missed the enable part:
#define IS_KBL_GT2(devid) ((devid) == PCI_CHIP_KABYLAKE_ULX_GT2_...
sorry for not being clear about the "enable" part on previous review.
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Intel: Add a Kaby Lake PCI ID
2018-04-24 17:46 ` Rodrigo Vivi
2018-04-24 17:55 ` matthew.s.atwood
@ 2018-04-24 19:05 ` matthew.s.atwood
2018-04-24 19:42 ` matthew.s.atwood
2 siblings, 0 replies; 8+ messages in thread
From: matthew.s.atwood @ 2018-04-24 19:05 UTC (permalink / raw)
To: dri-devel, rodrigo.vivi; +Cc: Matt Atwood
From: Matt Atwood <matthew.s.atwood@intel.com>
Based on kernel commit '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
v2: name change M -> ULX, add enumeration in KBL ULX
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
intel/intel_chipset.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
index 01d250e..f479bc4 100644
--- a/intel/intel_chipset.h
+++ b/intel/intel_chipset.h
@@ -200,7 +200,8 @@
#define PCI_CHIP_KABYLAKE_ULT_GT2F 0x5921
#define PCI_CHIP_KABYLAKE_ULX_GT1_5 0x5915
#define PCI_CHIP_KABYLAKE_ULX_GT1 0x590E
-#define PCI_CHIP_KABYLAKE_ULX_GT2 0x591E
+#define PCI_CHIP_KABYLAKE_ULX_GT2_0 0x591E
+#define PCI_CHIP_KABYLAKE_ULX_GT2_1 0x591C
#define PCI_CHIP_KABYLAKE_DT_GT2 0x5912
#define PCI_CHIP_KABYLAKE_M_GT2 0x5917
#define PCI_CHIP_KABYLAKE_DT_GT1 0x5902
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] Intel: Add a Kaby Lake PCI ID
2018-04-24 17:46 ` Rodrigo Vivi
2018-04-24 17:55 ` matthew.s.atwood
2018-04-24 19:05 ` matthew.s.atwood
@ 2018-04-24 19:42 ` matthew.s.atwood
2018-04-24 20:06 ` Rodrigo Vivi
2 siblings, 1 reply; 8+ messages in thread
From: matthew.s.atwood @ 2018-04-24 19:42 UTC (permalink / raw)
To: dri-devel, rodrigo.vivi; +Cc: Matt Atwood
From: Matt Atwood <matthew.s.atwood@intel.com>
Based on kernel commit '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
v2: name change M -> ULX, add enumeration in KBL ULX
v3: add entry to IS_KABYLAKE
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
intel/intel_chipset.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
index 01d250e..ba2e3ac 100644
--- a/intel/intel_chipset.h
+++ b/intel/intel_chipset.h
@@ -200,7 +200,8 @@
#define PCI_CHIP_KABYLAKE_ULT_GT2F 0x5921
#define PCI_CHIP_KABYLAKE_ULX_GT1_5 0x5915
#define PCI_CHIP_KABYLAKE_ULX_GT1 0x590E
-#define PCI_CHIP_KABYLAKE_ULX_GT2 0x591E
+#define PCI_CHIP_KABYLAKE_ULX_GT2_0 0x591E
+#define PCI_CHIP_KABYLAKE_ULX_GT2_1 0x591C
#define PCI_CHIP_KABYLAKE_DT_GT2 0x5912
#define PCI_CHIP_KABYLAKE_M_GT2 0x5917
#define PCI_CHIP_KABYLAKE_DT_GT1 0x5902
@@ -455,7 +456,8 @@
#define IS_KBL_GT2(devid) ((devid) == PCI_CHIP_KABYLAKE_ULT_GT2 || \
(devid) == PCI_CHIP_KABYLAKE_ULT_GT2F || \
- (devid) == PCI_CHIP_KABYLAKE_ULX_GT2 || \
+ (devid) == PCI_CHIP_KABYLAKE_ULX_GT2_0 || \
+ (devid) == PCI_CHIP_KABYLAKE_ULX_GT2_1 || \
(devid) == PCI_CHIP_KABYLAKE_DT_GT2 || \
(devid) == PCI_CHIP_KABYLAKE_M_GT2 || \
(devid) == PCI_CHIP_KABYLAKE_HALO_GT2 || \
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] Intel: Add a Kaby Lake PCI ID
2018-04-24 19:42 ` matthew.s.atwood
@ 2018-04-24 20:06 ` Rodrigo Vivi
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2018-04-24 20:06 UTC (permalink / raw)
To: matthew.s.atwood; +Cc: dri-devel
On Tue, Apr 24, 2018 at 12:42:39PM -0700, matthew.s.atwood@intel.com wrote:
> From: Matt Atwood <matthew.s.atwood@intel.com>
>
> Based on kernel commit '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
>
> v2: name change M -> ULX, add enumeration in KBL ULX
> v3: add entry to IS_KABYLAKE
reviewed and pushed. Thanks for the patch.
>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> ---
> intel/intel_chipset.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
> index 01d250e..ba2e3ac 100644
> --- a/intel/intel_chipset.h
> +++ b/intel/intel_chipset.h
> @@ -200,7 +200,8 @@
> #define PCI_CHIP_KABYLAKE_ULT_GT2F 0x5921
> #define PCI_CHIP_KABYLAKE_ULX_GT1_5 0x5915
> #define PCI_CHIP_KABYLAKE_ULX_GT1 0x590E
> -#define PCI_CHIP_KABYLAKE_ULX_GT2 0x591E
> +#define PCI_CHIP_KABYLAKE_ULX_GT2_0 0x591E
> +#define PCI_CHIP_KABYLAKE_ULX_GT2_1 0x591C
> #define PCI_CHIP_KABYLAKE_DT_GT2 0x5912
> #define PCI_CHIP_KABYLAKE_M_GT2 0x5917
> #define PCI_CHIP_KABYLAKE_DT_GT1 0x5902
> @@ -455,7 +456,8 @@
>
> #define IS_KBL_GT2(devid) ((devid) == PCI_CHIP_KABYLAKE_ULT_GT2 || \
> (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F || \
> - (devid) == PCI_CHIP_KABYLAKE_ULX_GT2 || \
> + (devid) == PCI_CHIP_KABYLAKE_ULX_GT2_0 || \
> + (devid) == PCI_CHIP_KABYLAKE_ULX_GT2_1 || \
> (devid) == PCI_CHIP_KABYLAKE_DT_GT2 || \
> (devid) == PCI_CHIP_KABYLAKE_M_GT2 || \
> (devid) == PCI_CHIP_KABYLAKE_HALO_GT2 || \
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-04-24 20:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-23 22:08 [PATCH] Intel: Add a Kaby Lake PCI ID matthew.s.atwood
2018-04-24 17:42 ` Rodrigo Vivi
2018-04-24 17:46 ` Rodrigo Vivi
2018-04-24 17:55 ` matthew.s.atwood
2018-04-24 18:18 ` Rodrigo Vivi
2018-04-24 19:05 ` matthew.s.atwood
2018-04-24 19:42 ` matthew.s.atwood
2018-04-24 20:06 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).