dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Keith Packard <keithp@keithp.com>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm: Don't EXPORT drm_add/reset_display_info
Date: Tue, 24 Apr 2018 23:30:34 +0200	[thread overview]
Message-ID: <20180424213034.GF25142@phenom.ffwll.local> (raw)
In-Reply-To: <20180424172936.GD23723@intel.com>

On Tue, Apr 24, 2018 at 08:29:36PM +0300, Ville Syrjälä wrote:
> On Tue, Apr 24, 2018 at 04:22:42PM +0200, Daniel Vetter wrote:
> > Only used within drm.ko, no need to tempt drivers.
> > 
> > Cc: Keith Packard <keithp@keithp.com>
> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks for review, applied.
-Daniel
> 
> > ---
> >  drivers/gpu/drm/drm_crtc_internal.h | 2 ++
> >  drivers/gpu/drm/drm_edid.c          | 2 --
> >  include/drm/drm_edid.h              | 2 --
> >  3 files changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
> > index 3c2b82865ad2..5d307b23a4e6 100644
> > --- a/drivers/gpu/drm/drm_crtc_internal.h
> > +++ b/drivers/gpu/drm/drm_crtc_internal.h
> > @@ -220,3 +220,5 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev,
> >  
> >  /* drm_edid.c */
> >  void drm_mode_fixup_1366x768(struct drm_display_mode *mode);
> > +void drm_reset_display_info(struct drm_connector *connector);
> > +u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid);
> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> > index 134069f36482..61dd9a2fbe5b 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -4454,7 +4454,6 @@ drm_reset_display_info(struct drm_connector *connector)
> >  
> >  	info->non_desktop = 0;
> >  }
> > -EXPORT_SYMBOL_GPL(drm_reset_display_info);
> >  
> >  u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid)
> >  {
> > @@ -4538,7 +4537,6 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi
> >  		info->color_formats |= DRM_COLOR_FORMAT_YCRCB422;
> >  	return quirks;
> >  }
> > -EXPORT_SYMBOL_GPL(drm_add_display_info);
> >  
> >  static int validate_displayid(u8 *displayid, int length, int idx)
> >  {
> > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
> > index 8d89a9c3748d..b25d12ef120a 100644
> > --- a/include/drm/drm_edid.h
> > +++ b/include/drm/drm_edid.h
> > @@ -465,8 +465,6 @@ struct edid *drm_get_edid(struct drm_connector *connector,
> >  struct edid *drm_get_edid_switcheroo(struct drm_connector *connector,
> >  				     struct i2c_adapter *adapter);
> >  struct edid *drm_edid_duplicate(const struct edid *edid);
> > -void drm_reset_display_info(struct drm_connector *connector);
> > -u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid);
> >  int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid);
> >  
> >  u8 drm_match_cea_mode(const struct drm_display_mode *to_match);
> > -- 
> > 2.16.2
> 
> -- 
> Ville Syrjälä
> Intel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2018-04-24 21:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 14:22 [PATCH] drm: Don't EXPORT drm_add/reset_display_info Daniel Vetter
2018-04-24 17:29 ` Ville Syrjälä
2018-04-24 21:30   ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424213034.GF25142@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=keithp@keithp.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox