Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 310

From: Daniel Vetter <daniel@ffwll.ch>
To: Hans de Goede <hdegoede@redhat.com>
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 310
Date: Wed, 25 Apr 2018 09:05:31 +0200	[thread overview]
Message-ID: <20180425070530.GI25142@phenom.ffwll.local> (raw)
In-Reply-To: <e9077581-c0f0-feaa-34a4-2677b520b28c@redhat.com>

On Tue, Apr 24, 2018 at 02:24:59PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 24-04-18 14:18, Daniel Vetter wrote:
> > On Tue, Apr 24, 2018 at 12:26:04PM +0200, Maarten Lankhorst wrote:
> > > Op 24-04-18 om 12:09 schreef Hans de Goede:
> > > > Hi,
> > > > 
> > > > On 18-04-18 14:36, Hans de Goede wrote:
> > > > > Some production batches of the Lenovo Ideapad Mixx 310 laptop use
> > > > > a portrait LCD panel, add a quirk for this.
> > > > > 
> > > > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > > > 
> > > > Ping?
> > > > 
> > > > Can I please get an ack for these 2 trivial patches to that I can
> > > > push them to drm-misc-next ?
> > > > 
> > > > Thanks & Regards,
> > > I don't have the hw, but patches look sane..
> > > 
> > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > 
> > For quirks, bugzilla/reporter/any other evidence why we need it would be
> > really good. If you haven't pushed yet, pls add that.
> 
> Sorry, too late.  I must admit I'm a bit of a hoarder when it
> comes to BYT / CHT hardware (as I spend my spare time on trying
> to make those work properly with Linux) and I own all devices
> currently listed, except for the GPD Pocket which I borrowed
> from a friend for a while to get it supported properly under
> Linux.
> 
> But I'm currently emailing with someone who has a device with
> a non-upright mounted LCD-panel which will need a quirk too,
> which will be the first device I don't have access to myself.

Ah ok, as long as all we need to figure this out is nag you I think it's
ok. We've had plenty of cases in the past where it looked like quirk
entries just papered over a driver bug (which we discovered much later),
so it's good if there's some way to get hold of the original reporters
again. Even if chances are generally slim.

> I will add his email address as a comment to the entry when I
> submit the patch for that.

Commit message is prefectly fine.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel