Re: [PATCH] drm/bridge: cdns: Mark runtime PM operations as maybe unused

From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/bridge: cdns: Mark runtime PM operations as maybe unused
Date: Thu, 26 Apr 2018 17:15:03 +0200	[thread overview]
Message-ID: <20180426151503.GG31888@ulmo> (raw)
In-Reply-To: <20180426142103.GD12521@phenom.ffwll.local>

[-- Attachment #1.1: Type: text/plain, Size: 978 bytes --]

On Thu, Apr 26, 2018 at 04:21:04PM +0200, Daniel Vetter wrote:
> On Thu, Apr 26, 2018 at 03:58:53PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > Building the driver in a configuration with !PM currently causes a
> > warning about these operations being unused. Mark them as such to shut
> > up the compiler.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> I'd so love if we could use LTO (or at least link time garbage collection
> of functions/heap allocations) instead of tons of #ifdef (even in macros)
> and __maybe_unused.

I had discussed this with Arnd Bergmann a long time ago and neither of
us could figure out a way to make that work in this case, so we agreed
that __maybe_unused was the preferred way forward until somebody would
figure out a better way.

> Patch looks fine itself.
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thanks, applied to drm-misc-next.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel