dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Paul <seanpaul@chromium.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH] drm/msm: Don't setup control node debugfs files
Date: Thu, 3 May 2018 11:16:55 -0400	[thread overview]
Message-ID: <20180503151655.GE73214@art_vandelay> (raw)
In-Reply-To: <20180503093107.25955-1-daniel.vetter@ffwll.ch>

On Thu, May 03, 2018 at 11:31:07AM +0200, Daniel Vetter wrote:
> It's going away.
> 
> v2: Try harder to find them all.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Still
Reviewed-by: Sean Paul <seanpaul@chromium.org>

> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Jordan Crouse <jcrouse@codeaurora.org>
> Cc: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> Cc: Archit Taneja <architt@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/msm/adreno/adreno_device.c | 1 -
>  drivers/gpu/drm/msm/msm_debugfs.c          | 3 ---
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
> index 8e0cb161754b..0ae5ace65462 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_device.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
> @@ -168,7 +168,6 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev)
>  	if (gpu->funcs->debugfs_init) {
>  		gpu->funcs->debugfs_init(gpu, dev->primary);
>  		gpu->funcs->debugfs_init(gpu, dev->render);
> -		gpu->funcs->debugfs_init(gpu, dev->control);
>  	}
>  #endif
>  
> diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c
> index ba74cb4f94df..1ff3fda245d1 100644
> --- a/drivers/gpu/drm/msm/msm_debugfs.c
> +++ b/drivers/gpu/drm/msm/msm_debugfs.c
> @@ -140,9 +140,6 @@ int msm_debugfs_late_init(struct drm_device *dev)
>  	if (ret)
>  		return ret;
>  	ret = late_init_minor(dev->render);
> -	if (ret)
> -		return ret;
> -	ret = late_init_minor(dev->control);
>  	return ret;
>  }
>  
> -- 
> 2.17.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-05-03 15:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20  6:51 [PATCH 1/4] drm: Drop DRM_CONTROL_ALLOW from ioctls Daniel Vetter
2018-04-20  6:51 ` [PATCH 2/4] drm/i915: Drop DRM_CONTROL_ALLOW Daniel Vetter
2018-04-23  8:26   ` Joonas Lahtinen
2018-05-02 15:02   ` Sean Paul
2018-04-20  6:51 ` [PATCH 3/4] drm/vmwgfx: " Daniel Vetter
2018-04-20 17:56   ` Thomas Hellstrom
2018-04-24 13:01     ` Daniel Vetter
2018-04-24 13:25       ` Thomas Hellstrom
2018-05-02 15:03   ` Sean Paul
2018-04-20  6:51 ` [PATCH 4/4] drm: remove all control node code Daniel Vetter
2018-05-02 20:10   ` Sean Paul
2018-05-03  9:28     ` Daniel Vetter
2018-05-03  9:32       ` Daniel Vetter
2018-04-25  9:07 ` [PATCH] drm/msm: Don't setup control node debugfs files Daniel Vetter
2018-05-02 15:03   ` Sean Paul
2018-05-03  9:31   ` Daniel Vetter
2018-05-03 15:16     ` Sean Paul [this message]
2018-05-03 19:29       ` Daniel Vetter
2018-05-02 15:02 ` [PATCH 1/4] drm: Drop DRM_CONTROL_ALLOW from ioctls Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503151655.GE73214@art_vandelay \
    --to=seanpaul@chromium.org \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox