Re: [PATCH] Add SPDX idenitifier and clarify license

[Dirk Hohndel <dirk@hohndel.org>]

On Thu, May 03, 2018 at 10:03:32AM -0300, Fabio Estevam wrote:
> On Wed, May 2, 2018 at 10:46 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
> 
> > diff --git a/drivers/gpu/drm/ttm/ttm_agp_backend.c b/drivers/gpu/drm/ttm/ttm_agp_backend.c
> > index 7c2485fe88d8..ea4d59eb8966 100644
> > --- a/drivers/gpu/drm/ttm/ttm_agp_backend.c
> > +++ b/drivers/gpu/drm/ttm/ttm_agp_backend.c
> > @@ -1,3 +1,4 @@
> > +/* SPDX-License-Identifier: GPL-2.0 OR MIT */
> 
> According to Documentation/process/license-rules.rst the SPDX tag
> should start with // in .c files.

I saw that... but looking at what's there in C code:

hohndel@rrmbpvm:~/src/linux[VMware-license-cleanup]
$ git grep SPDX | grep \.c: | cut -d: -f2 | sort | grep ^// | wc
   5260   10519  142020
hohndel@rrmbpvm:~/src/linux[VMware-license-cleanup]
$ git grep SPDX | grep \.c: | cut -d: -f2 | sort | grep ^/\* | wc
   5397   10792  145680

(ok, that's close...)
But if you do the same analysis for header files...

hohndel@rrmbpvm:~/src/linux[VMware-license-cleanup]
$ git grep SPDX | grep \.h: | cut -d: -f2 | sort | grep ^// | wc
    549    1098   14823
hohndel@rrmbpvm:~/src/linux[VMware-license-cleanup]
$ git grep SPDX | grep \.h: | cut -d: -f2 | sort | grep ^/\* | wc
   7981   15962  215364

So a majority seems to go with the "more Linux C file style" /* as comment
marker... which is why I chose that...

/D
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel