From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Brezillon <boris.brezillon@bootlin.com>
Subject: Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats
Date: Mon, 7 May 2018 18:11:02 +0200
Message-ID: <20180507181102.47ea0060@bbrezillon>
References: <20180507121303.5610-1-boris.brezillon@bootlin.com>
        <87vabz1mu9.fsf@anholt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <stable-owner@vger.kernel.org>
In-Reply-To: <87vabz1mu9.fsf@anholt.net>
Sender: stable-owner@vger.kernel.org
To: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org, stable@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

On Mon, 07 May 2018 08:56:14 -0700
Eric Anholt <eric@anholt.net> wrote:

> Boris Brezillon <boris.brezillon@bootlin.com> writes:
> 
> > When using uni-planar formats (like RGB), the scaling parameters are
> > stored in plane 0, not plane 1.
> >
> > Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>  
> 
> Reviewed-by: Eric Anholt <eric@anholt.net>
> 
> Looking at the other branch, did I get the scl0/scl1 backwards?  HVS
> docs say for non-444 YCBCR: "In these cases Channel 0 performs Y/Alpha
> scaling and Channel 1 performs CB/CR scaling and should be configured as
> appropriate."

Didn't test, but I think rescaling of multi-planar format is correct.