[PATCH v2] drm: Allow CAP_DUMB_BUFFERS on !MODESET

[Ezequiel Garcia <ezequiel@collabora.com>]

It's perfectly possible to get dumb buffers out of drivers
that don't support modeset. This is the case of vgem,
which can be used to export dmabuf to run various tests.

Inspired by commit f3f4c4d68a28 ("drm: Allow CAP_PRIME on !MODESET").

Fixes: d5264ed3823a ("drm: Return -ENOTSUPP when called for KMS cap with a non-KMS driver")
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
Changes from v1:
 * Drop the bitwise-OR assignment op

 drivers/gpu/drm/drm_ioctl.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
index af782911c505..a5b879ce8f2c 100644
--- a/drivers/gpu/drm/drm_ioctl.c
+++ b/drivers/gpu/drm/drm_ioctl.c
@@ -244,6 +244,9 @@ static int drm_getcap(struct drm_device *dev, void *data, struct drm_file *file_
 	case DRM_CAP_SYNCOBJ:
 		req->value = drm_core_check_feature(dev, DRIVER_SYNCOBJ);
 		return 0;
+	case DRM_CAP_DUMB_BUFFER:
+		req->value = dev->driver->dumb_create ? 1 : 0;
+		return 0;
 	}
 
 	/* Other caps only work with KMS drivers */
@@ -251,10 +254,6 @@ static int drm_getcap(struct drm_device *dev, void *data, struct drm_file *file_
 		return -ENOTSUPP;
 
 	switch (req->capability) {
-	case DRM_CAP_DUMB_BUFFER:
-		if (dev->driver->dumb_create)
-			req->value = 1;
-		break;
 	case DRM_CAP_VBLANK_HIGH_CRTC:
 		req->value = 1;
 		break;
-- 
2.16.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel