From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 2/2] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4 Date: Tue, 8 May 2018 12:27:19 -0700 Message-ID: <20180508192719.GB2003@intel.com> References: <20180504221800.17830-1-matthew.s.atwood@intel.com> <20180504221800.17830-2-matthew.s.atwood@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180504221800.17830-2-matthew.s.atwood@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: matthew.s.atwood@intel.com Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, alexander.deucher@amd.com List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXkgMDQsIDIwMTggYXQgMDM6MTg6MDBQTSAtMDcwMCwgbWF0dGhldy5zLmF0d29v ZEBpbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogTWF0dCBBdHdvb2QgPG1hdHRoZXcucy5hdHdvb2RA aW50ZWwuY29tPgo+IAo+IERQX1RSQUlOSU5HX0FVWF9SRF9JTlRFUlZBTCB3aXRoIERQIDEuMyBz cGVjIGNoYW5nZWQgYml0IHNjaGVlbWUgZnJvbSA4Cj4gYml0cyB0byA3IGluIERQQ0QgMHgwMDBl LiBUaGUgOHRoIGJpdCBpcyB1c2VkIHRvIGlkZW50aWZ5IGV4dGVuZGVkCj4gcmVjZWl2ZXIgY2Fw YWJpbGl0aWVzLiBGb3IgcGFuZWxzIHRoYXQgdXNlIHRoaXMgbmV3IGZlYXR1cmUgd2FpdCBpbnRl cnZhbAo+IHdvdWxkIGJlIGluY3JlYXNlZCBieSA1MTIgbXMsIHdoZW4gc3BlYyBpcyBtYXggMTYg bXMuIFRoaXMgYmVoYXZpb3IgaXMKPiBkZXNjcmliZWQgaW4gdGFibGUgMi0xNTggb2YgRFAgMS40 IHNwZWMgYWRkcmVzcyAwMDAwZWguCj4gCj4gV2l0aCB0aGUgaW50cm9kdWN0aW9uIG9mIERQIDEu NCBzcGVjIG1haW4gbGluayBjbG9jayByZWNvdmVyeSB3YXMKPiBzdGFuZGFyZGl6ZWQgdG8gMTAw IHVzIHJlZ2FyZGxlc3Mgb2YgVFJBSU5JTkdfQVVYX1JEX0lOVEVSVkFMIHZhbHVlLgo+IAo+IFRv IGF2b2lkIGJyZWFraW5nIHBhbmVscyB0aGF0IGFyZSBub3Qgc3BlYyBjb21waWFudCB3ZSBub3cg d2FybiBvbgo+IGludmFsaWQgdmFsdWVzLgo+IAo+IFYyOiBjb21taXQgdGl0bGUvbWVzc2FnZSwg bWFza2luZyBhbGwgNyBiaXRzLCB3YXJuIG9uIG91dCBvZiBzcGVjIHZhbHVlcy4KPiBWMzogY29t bWl0IG1lc3NhZ2UsIG1ha2UgbGluayB0cmFpbiBjbG9jayByZWNvdmVyeSBmb2xsb3cgRFAgMS40 IHNwZWMuCj4gVjQ6IHN0eWxlIGNoYW5nZXMKPiBWNTogdHlwbwo+IFY2OiBwcmludCBzdGF0ZW1l bnQgcmV2aXNpb25zLCBEUF9SRVYgdG8gRFBDRF9SRVYsIGNvbW1lbnQgY29ycmVjdGlvbgo+IFY3 OiB0eXBvCj4gVjg6IFN0eWxlCj4gVjk6IFN0cmlwIG91dCBEUENEX1JFVl9YWCBpbnRvIHNlcGVy YXRlIHBhdGNoCj4gdjEwOiBEUENEX1JFVl9YWCB0byBEUF9EUENEX1JFVl9YWAo+IAo+IFNpZ25l ZC1vZmYtYnk6IE1hdHQgQXR3b29kIDxtYXR0aGV3LnMuYXR3b29kQGludGVsLmNvbT4KPiBSZXZp ZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKcGF0Y2hlcyBw dXNoZWQgdG8gZHJtLW1pc2MtbmV4dC4KClRoYW5rcywKUm9kcmlnby4KCj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9kcm1fZHBfaGVscGVyLmMgfCAyMiArKysrKysrKysrKysrKysrKystLS0tCj4g IGluY2x1ZGUvZHJtL2RybV9kcF9oZWxwZXIuaCAgICAgfCAgMSArCj4gIDIgZmlsZXMgY2hhbmdl ZCwgMTkgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfaGVs cGVyLmMKPiBpbmRleCBmZmUxNGVjM2U3ZjIuLjM2Yzc2MDlhNGJkNSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2RwX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ry bV9kcF9oZWxwZXIuYwo+IEBAIC0xMTksMTggKzExOSwzMiBAQCB1OCBkcm1fZHBfZ2V0X2FkanVz dF9yZXF1ZXN0X3ByZV9lbXBoYXNpcyhjb25zdCB1OCBsaW5rX3N0YXR1c1tEUF9MSU5LX1NUQVRV U19TSQo+ICBFWFBPUlRfU1lNQk9MKGRybV9kcF9nZXRfYWRqdXN0X3JlcXVlc3RfcHJlX2VtcGhh c2lzKTsKPiAgCj4gIHZvaWQgZHJtX2RwX2xpbmtfdHJhaW5fY2xvY2tfcmVjb3ZlcnlfZGVsYXko Y29uc3QgdTggZHBjZFtEUF9SRUNFSVZFUl9DQVBfU0laRV0pIHsKPiAtCWlmIChkcGNkW0RQX1RS QUlOSU5HX0FVWF9SRF9JTlRFUlZBTF0gPT0gMCkKPiArCWludCByZF9pbnRlcnZhbCA9IGRwY2Rb RFBfVFJBSU5JTkdfQVVYX1JEX0lOVEVSVkFMXSAmCj4gKwkJCSAgRFBfVFJBSU5JTkdfQVVYX1JE X01BU0s7Cj4gKwo+ICsJaWYgKHJkX2ludGVydmFsID4gNCkKPiArCQlEUk1fREVCVUdfS01TKCJB VVggaW50ZXJ2YWwgJWQsIG91dCBvZiByYW5nZSAobWF4IDQpXG4iLAo+ICsJCQkgICAgICByZF9p bnRlcnZhbCk7Cj4gKwo+ICsJaWYgKHJkX2ludGVydmFsID09IDAgfHwgZHBjZFtEUF9EUENEX1JF Vl0gPj0gRFBfRFBDRF9SRVZfMTQpCj4gIAkJdWRlbGF5KDEwMCk7Cj4gIAllbHNlCj4gLQkJbWRl bGF5KGRwY2RbRFBfVFJBSU5JTkdfQVVYX1JEX0lOVEVSVkFMXSAqIDQpOwo+ICsJCW1kZWxheShy ZF9pbnRlcnZhbCAqIDQpOwo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2RwX2xpbmtfdHJhaW5f Y2xvY2tfcmVjb3ZlcnlfZGVsYXkpOwo+ICAKPiAgdm9pZCBkcm1fZHBfbGlua190cmFpbl9jaGFu bmVsX2VxX2RlbGF5KGNvbnN0IHU4IGRwY2RbRFBfUkVDRUlWRVJfQ0FQX1NJWkVdKSB7Cj4gLQlp ZiAoZHBjZFtEUF9UUkFJTklOR19BVVhfUkRfSU5URVJWQUxdID09IDApCj4gKwlpbnQgcmRfaW50 ZXJ2YWwgPSBkcGNkW0RQX1RSQUlOSU5HX0FVWF9SRF9JTlRFUlZBTF0gJgo+ICsJCQkgIERQX1RS QUlOSU5HX0FVWF9SRF9NQVNLOwo+ICsKPiArCWlmIChyZF9pbnRlcnZhbCA+IDQpCj4gKwkJRFJN X0RFQlVHX0tNUygiQVVYIGludGVydmFsICVkLCBvdXQgb2YgcmFuZ2UgKG1heCA0KVxuIiwKPiAr CQkJICAgICAgcmRfaW50ZXJ2YWwpOwo+ICsKPiArCWlmIChyZF9pbnRlcnZhbCA9PSAwKQo+ICAJ CXVkZWxheSg0MDApOwo+ICAJZWxzZQo+IC0JCW1kZWxheShkcGNkW0RQX1RSQUlOSU5HX0FVWF9S RF9JTlRFUlZBTF0gKiA0KTsKPiArCQltZGVsYXkocmRfaW50ZXJ2YWwgKiA0KTsKPiAgfQo+ICBF WFBPUlRfU1lNQk9MKGRybV9kcF9saW5rX3RyYWluX2NoYW5uZWxfZXFfZGVsYXkpOwo+ICAKPiBk aWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2RwX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJt X2RwX2hlbHBlci5oCj4gaW5kZXggOTZkY2VmNDc5ZWQ2Li5lY2YzZTJiZjI5M2IgMTAwNjQ0Cj4g LS0tIGEvaW5jbHVkZS9kcm0vZHJtX2RwX2hlbHBlci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJt X2RwX2hlbHBlci5oCj4gQEAgLTEyNCw2ICsxMjQsNyBAQAo+ICAjIGRlZmluZSBEUF9EUENEX0RJ U1BMQVlfQ09OVFJPTF9DQVBBQkxFICAgICAoMSA8PCAzKSAvKiBlZHAgdjEuMiBvciBoaWdoZXIg Ki8KPiAgCj4gICNkZWZpbmUgRFBfVFJBSU5JTkdfQVVYX1JEX0lOVEVSVkFMICAgICAgICAgMHgw MGUgICAvKiBYWFggMS4yPyAqLwo+ICsjIGRlZmluZSBEUF9UUkFJTklOR19BVVhfUkRfTUFTSyAg ICAgICAgICAgIDB4N0YgICAgLyogWFhYIDEuMj8gKi8KPiAgCj4gICNkZWZpbmUgRFBfQURBUFRF Ul9DQVAJCQkgICAgMHgwMGYgICAvKiAxLjIgKi8KPiAgIyBkZWZpbmUgRFBfRk9SQ0VfTE9BRF9T RU5TRV9DQVAJICAgICgxIDw8IDApCj4gLS0gCj4gMi4xNy4wCj4gCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=