From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error Date: Wed, 16 May 2018 11:42:24 +0200 Message-ID: <20180516094224.GD3438@phenom.ffwll.local> References: <20180509201449.27452-1-ezequiel@collabora.com> <152602366168.22269.11696001916463464983@mail.alporthouse.com> <20180514164823.GH28661@phenom.ffwll.local> <152638659036.18532.13662508480413451560@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id E26026E3BA for ; Wed, 16 May 2018 09:42:28 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id t11-v6so207582wmt.0 for ; Wed, 16 May 2018 02:42:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <152638659036.18532.13662508480413451560@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: dri-devel@lists.freedesktop.org, kernel@collabora.com, Ezequiel Garcia , linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXkgMTUsIDIwMTggYXQgMDE6MTY6MzBQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgRXplcXVpZWwgR2FyY2lhICgyMDE4LTA1LTE0IDIyOjI4OjMxKQo+ID4g T24gTW9uLCAyMDE4LTA1LTE0IGF0IDE4OjQ4ICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ ID4gPiBPbiBGcmksIE1heSAxMSwgMjAxOCBhdCAwODoyNzo0MUFNICswMTAwLCBDaHJpcyBXaWxz b24gd3JvdGU6Cj4gPiA+ID4gUXVvdGluZyBFemVxdWllbCBHYXJjaWEgKDIwMTgtMDUtMDkgMjE6 MTQ6NDkpCj4gPiA+ID4gPiBDaGFuZ2UgaG93IGRtYV9mZW5jZV9hZGRfY2FsbGJhY2soKSBiZWhh dmVzLCB3aGVuIHRoZSBmZW5jZQo+ID4gPiA+ID4gaGFzIGVycm9yLXNpZ25hbGVkIGJ5IHRoZSB0 aW1lIGl0IGlzIGJlaW5nIGFkZC4gQWZ0ZXIgdGhpcyBjb21taXQsCj4gPiA+ID4gPiBkbWFfZmVu Y2VfYWRkX2NhbGxiYWNrKCkgcmV0dXJucyB0aGUgZmVuY2UgZXJyb3IsIGlmIGl0Cj4gPiA+ID4g PiBoYXMgZXJyb3Itc2lnbmFsZWQgYmVmb3JlIGRtYV9mZW5jZV9hZGRfY2FsbGJhY2soKSBpcyBj YWxsZWQuCj4gPiA+ID4gCj4gPiA+ID4gV2h5PyBXaGF0IHByb2JsZW0gYXJlIHlvdSB0cnlpbmcg dG8gc29sdmU/IGZlbmNlLT5lcnJvciBkb2VzIG5vdCBpbXBseQo+ID4gPiA+IHRoYXQgdGhlIGZl bmNlIGhhcyB5ZXQgYmVlbiBzaWduYWxlZCwgYW5kIHRoZSBjYWxsZXIgd2FudHMgYSBjYWxsYmFj awo+ID4gPiA+IHdoZW4gaXQgaXMgc2lnbmFsZWQuCj4gPiA+IAo+ID4gPiBPbiB0b3AgdGhpcyBp cyBpbmNvc2lzdGVudCwgZS5nLiB3ZSBkb24ndCBkbyB0aGUgc2FtZSBmb3IgYW55IG9mIHRoZSBv dGhlcgo+ID4gPiBkbWFfZmVuY2UgaW50ZXJmYWNlcy4gUGx1cyB0aGVyZSdzIHRoZSBpc3N1ZSB0 aGF0IHlvdSBtaWdodCBhbGlhcyBlcnJubwo+ID4gPiB2YWx1ZXMgd2l0aCBmZW5jZSBlcnJubyB2 YWx1ZXMuCj4gPiA+IAo+ID4gCj4gPiBSaWdodC4KPiA+IAo+ID4gPiBJIHRoaW5rIGtlZXBpbmcg dGhlIGVycm9yIGNvZGVzIGZyb20gdGhlIGZ1bmN0aW9ucyB5b3UncmUgY2FsbGluZyBkaXN0aW5j dAo+ID4gPiBmcm9tIHRoZSBlcnJvciBjb2RlIG9mIHRoZSBmZW5jZSBpdHNlbGYgbWFrZXMgYSBs b3Qgb2Ygc2Vuc2UuIFRoZSBmaXJzdAo+ID4gPiB0ZWxscyB5b3Ugd2hldGhlciB5b3VyIHJlcXVl c3Qgd29ya2VkIG91dCAob3Igd2h5IG5vdCksIHRoZSBzZWNvbmQgdGVsbHMKPiA+ID4geW91IHdo ZXRoZXIgdGhlIGFzeW5jaHJvbm91cyBkbWEgb3BlcmF0aW9uIChncHUgcmVuZGVyaW5nLCBwYWdl IGZsaXAsCj4gPiA+IHdoYXRldmVyKSB0aGF0IHRoZSBkbWFfZmVuY2UgcmVwcmVzZW50cyB3b3Jr ZWQgb3V0IChvciB3aHkgbm90KS4gVGhhdCdzIDIKPiA+ID4gZGlzdGluY3QgdGhpbmdzIGltby4K PiA+ID4gCj4gPiA+IE1pZ2h0IGJlIGdvb2QgdG8gc2hvdyB1cyB0aGUgZHJpdmVyIGNvZGUgdGhh dCBuZWVkcyB0aGlzIGJlaGF2aW91ciBzbyB3ZQo+ID4gPiBjYW4gZGlzY3VzcyBob3cgdG8gYmVz dCBoYW5kbGUgeW91ciB1c2UtY2FzZS4KPiA+ID4gCj4gPiAKPiA+IFRoaXMgY2hhbmdlIGFyb3Nl IHdoaWxlIGRpc2N1c3NpbmcgdGhlIGluLWZlbmNlcyBzdXBwb3J0IGZvciB2aWRlbzRsaW51eC4K PiA+IEhlcmUncyB0aGUgcGF0Y2ggdGhhdCBjYWxscyBkbWFfZmVuY2VfYWRkX2NhbGxiYWNrIGh0 dHBzOi8vbGttbC5vcmcvbGttbC8yMDE4LzUvNC83NjYuCj4gPiAKPiA+IFRoZSBjb2RlIHNuaXBw ZXQgY3VycmVudGx5IGxvb2tzIHNvbWV0aGluZyBsaWtlIHRoaXM6Cj4gPiAKPiA+ICAgICAgICAg aWYgKHZiLT5pbl9mZW5jZSkgewo+ID4gICAgICAgICAgICAgICAgIHJldCA9IGRtYV9mZW5jZV9h ZGRfY2FsbGJhY2sodmItPmluX2ZlbmNlLCAmdmItPmZlbmNlX2NiLAo+ID4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAKPiA+ICAgICAgICAgICAgICB2YjJfcWJ1Zl9mZW5jZV9jYik7 Cj4gPiAgICAgICAgICAgICAgICAgLyogaXMgdGhlIGZlbmNlIHNpZ25hbGVkPyAqLwo+ID4gICAg ICAgICAgICAgICAgIGlmIChyZXQgPT0gLUVOT0VOVCkgewo+ID4gICAgICAgICAKPiA+ICAgICAg ICAgICAgICAgICBkbWFfZmVuY2VfcHV0KHZiLT5pbl9mZW5jZSk7Cj4gPiAgICAgICAgICAgICAg ICAgICAgICAgICB2Yi0+aW5fZmVuY2UgPSBOVUxMOwo+ID4gICAgICAgICAgICAgICAgIH0gZWxz ZSBpZiAocmV0KQo+ID4gewo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgZ290byB1bmxvY2s7 Cj4gPiAgICAgICAgICAgICAgICAgfQo+ID4gICAgICAgICB9Cj4gPiAKPiA+IEluIHRoaXMgdXNl IGNhc2UsIGlmIHRoZSBjYWxsYmFjayBpcyBhZGRlZCBzdWNjZXNzZnVsbHksCj4gPiB0aGUgdmlk ZW80bGludXggY29yZSBkZWZlcnMgdGhlIGFjdGl2YXRpb24gb2YgdGhlIGJ1ZmZlcgo+ID4gdW50 aWwgdGhlIGZlbmNlIHNpZ25hbHMuCj4gPiAKPiA+IElmIHRoZSBmZW5jZSBpcyBzaWduYWxlZCAo Y3VycmVudGx5IGRpc3JlZ2FyZGluZyBvZiBlcnJvcnMpCj4gPiB0aGVuIHRoZSBidWZmZXIgaXMg YXNzdW1lZCB0byBiZSByZWFkeSB0byBiZSBhY3RpdmF0ZWQsCj4gPiBhbmQgc28gaXQgZ2V0cyBx dWV1ZWQgZm9yIGhhcmR3YXJlIHVzYWdlLgo+ID4gCj4gPiBHaXZpbmcgc29tZSBtb3JlIHRob3Vn aHQgdG8gdGhpcywgSSdtIG5vdCBzbyBzdXJlIHdoYXQgaXMKPiA+IHRoZSByaWdodCBhY3Rpb24g aWYgYSBmZW5jZSBzaWduYWxlZCB3aXRoIGVycm9yLiBJbiB0aGlzIGNhc2UsCj4gPiBpdCBhcHBl YXJzIHRvIG1lIHRoYXQgd2Ugc2hvdWxkbid0IGJlIHVzaW5nIHRoaXMgYnVmZmVyCj4gPiBpZiBp dHMgaW4tZmVuY2UgaXMgaW4gZXJyb3IsIGJ1dCBwZXJoYXBzIEknbSBtaXNzaW5nCj4gPiBzb21l dGhpbmcuCj4gCj4gV2hhdCBJIGhhdmUgaW4gbWluZCBmb3IgYXN5bmMgZXJyb3JzIGlzIHRvIHNr aXAgdGhlIG9wZXJhdGlvbiBhbmQKPiBwcm9wYWdhdGUgdGhlIGVycm9yIG9udG8gdGhlIG5leHQg ZmVuY2UuIE1vc3RseSBiZWNhdXNlIHRob3NlIGFzeW5jCj4gZXJyb3JzIG1heSBpbmNsdWRlIGZh dGFsIGVycm9ycyBzdWNoIGFzIHVuYWJsZSB0byBwaW4gdGhlIGJhY2tpbmcKPiBzdG9yYWdlIGZv ciB0aGUgb3BlcmF0aW9uLCBidXQgZXZlbiAidHJpdmlhbCIgZXJyb3JzIHN1Y2ggYXMgYW4gZWFy bHkKPiBvcGVyYXRpb24gZmFpbGluZyBtZWFucyB0aGF0IHRoaXMgcmVxdWVzdCBpcyB0aGVuIHN1 YmplY3QgdG8gZ2FyYmFnZS1pbiwKPiBnYXJiYWdlLW91dC4gSG93ZXZlciwgZm9yIHRyaXZpYWwg ZXJyb3JzIEkgd291bGQganVzdCBwcm9wYWdhdGUgdGhlCj4gZXJyb3Igc3RhdHVzIChzbyB0aGUg Y2FsbGVyIGtub3dzIHNvbWV0aGluZyB3ZW50IHdyb25nIGlmIHRoZXkgY2FyZSwgYnV0Cj4gaW4g YWxsIGxpa2VsaWhvb2Qgbm8gb25lIHdpbGwgbm90aWNlKSBhbmQgY29udGludWUgb24gd2l0aCB0 aGUgZ2xpdGNoeQo+IG9wZXJhdGlvbi4KCkluIGdlbmVyYWwsIHRoZXJlJ3Mgbm90IHJlYWxseSBh bnkgaGFyZCBydWxlIGFib3V0IHByb3BhZ2F0aW5nIGZlbmNlCmVycm9ycyBhY3Jvc3MgZGV2aWNl cy4gSXQncyBtb3N0bHkganVzdCB1c2VkIGJ5IGRyaXZlcnMgaW50ZXJuYWxseSB0byBrZWVwCnRy YWNrIG9mIGZhaWxlZCBzdHVmZiAoZ3B1IGhhbmdzIG9yIGFueXRoaW5nIGVsc2UgYXN5bmMgbGlr ZSBDaHJpcwpkZXNjcmliZXMgaGVyZSkuCgpGb3IgdjRsIEknbSBub3Qgc3VyZSB5b3Ugd2FudCB0 byBjYXJlIG11Y2ggYWJvdXQgdGhpcywgc2luY2UgcmlnaHQgbm93IHRoZQptYWluIHVzZSBvZiBm ZW5jZSBlcnJvcnMgaXMgZ3B1IGhhbmcgcmVjb3ZlcnkgKHdoZXRoZXIgaXQncyB0aGUgZHJpdmVy IG9yCmh3IHRoYXQncyBodW5nIGRvZXNuJ3QgbWF0dGVyIGhlcmUpLgotRGFuaWVsCi0tIApEYW5p ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxv Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK