dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Haneen Mohammed <hamohammed.sa@gmail.com>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: dri-devel@lists.freedesktop.org, Sean Paul <seanpaul@google.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v2 0/3] Expanding the basic vkms features
Date: Thu, 17 May 2018 22:42:32 +0300	[thread overview]
Message-ID: <20180517194232.GA2444@haneen-vb> (raw)
In-Reply-To: <cover.1526514457.git.rodrigosiqueiramelo@gmail.com>

On Wed, May 16, 2018 at 08:55:06PM -0300, Rodrigo Siqueira wrote:
> This series of patches add a centralized initialization mechanism, a
> single CRTC with a plane, an encoder, and extra module information. 
> 
> Changes in v2:
>  - Remove unused definitions
>  - Improve file names
>  - Improve code separation
>  - Remove unnecessary formats
> 
> Rodrigo Siqueira (3):
>   drm/vkms: Add mode_config initialization
>   drm/vkms: Add basic CRTC initialization
>   drm/vkms: Add extra information about vkms
> 
>  drivers/gpu/drm/Kconfig            |  8 ++-
>  drivers/gpu/drm/vkms/Makefile      |  2 +-
>  drivers/gpu/drm/vkms/vkms_crtc.c   | 35 ++++++++++++
>  drivers/gpu/drm/vkms/vkms_drv.c    | 61 +++++++++-----------
>  drivers/gpu/drm/vkms/vkms_drv.h    | 24 +++++++-
>  drivers/gpu/drm/vkms/vkms_output.c | 91 ++++++++++++++++++++++++++++++
>  drivers/gpu/drm/vkms/vkms_plane.c  | 46 +++++++++++++++
>  7 files changed, 227 insertions(+), 40 deletions(-)
>  create mode 100644 drivers/gpu/drm/vkms/vkms_crtc.c
>  create mode 100644 drivers/gpu/drm/vkms/vkms_output.c
>  create mode 100644 drivers/gpu/drm/vkms/vkms_plane.c
> 
> -- 
> 2.17.0

with my limited knowledge on DRM, these looks good to me.

Reviewed-by: Haneen Mohammed <hamohammed.sa@gmail>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-05-17 19:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 23:55 [PATCH v2 0/3] Expanding the basic vkms features Rodrigo Siqueira
2018-05-16 23:55 ` [PATCH v2 1/3] drm/vkms: Add mode_config initialization Rodrigo Siqueira
2018-05-16 23:56 ` [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization Rodrigo Siqueira
2018-05-20  6:22   ` Haneen Mohammed
2018-05-20 14:28     ` Rodrigo Siqueira
2018-05-20 16:44       ` Haneen Mohammed
2018-05-20 18:41         ` Rodrigo Siqueira
2018-05-23  8:53     ` Daniel Vetter
2018-05-24  2:24       ` Haneen Mohammed
2019-01-18  0:51   ` [v2,2/3] " Thomas Gleixner
2019-01-21  8:57     ` Rodrigo Siqueira
2018-05-16 23:56 ` [PATCH v2 3/3] drm/vkms: Add extra information about vkms Rodrigo Siqueira
2018-05-17 19:42 ` Haneen Mohammed [this message]
2018-05-23  8:55   ` [PATCH v2 0/3] Expanding the basic vkms features Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517194232.GA2444@haneen-vb \
    --to=hamohammed.sa@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=rodrigosiqueiramelo@gmail.com \
    --cc=seanpaul@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).