* [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks() @ 2018-05-18 8:04 ` Dan Carpenter 2018-05-23 0:33 ` Inki Dae 0 siblings, 1 reply; 2+ messages in thread From: Dan Carpenter @ 2018-05-18 8:04 UTC (permalink / raw) To: Inki Dae, Marek Szyprowski Cc: linux-samsung-soc, David Airlie, kernel-janitors, Seung-Woo Kim, Krzysztof Kozlowski, Kyungmin Park, Kukjin Kim, dri-devel "id" needs to be signed for the error handling to work. Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 4dfbfc7f3b84..5ce84025d1cb 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -1200,7 +1200,7 @@ static int fimc_setup_clocks(struct fimc_context *ctx) int exynos_drm_check_fimc_device(struct device *dev) { - unsigned int id = of_alias_get_id(dev->of_node, "fimc"); + int id = of_alias_get_id(dev->of_node, "fimc"); if (id >= 0 && (BIT(id) & fimc_mask)) return 0; _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks() 2018-05-18 8:04 ` [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks() Dan Carpenter @ 2018-05-23 0:33 ` Inki Dae 0 siblings, 0 replies; 2+ messages in thread From: Inki Dae @ 2018-05-23 0:33 UTC (permalink / raw) To: Dan Carpenter, Marek Szyprowski Cc: linux-samsung-soc, David Airlie, kernel-janitors, Seung-Woo Kim, Krzysztof Kozlowski, Kyungmin Park, Kukjin Kim, dri-devel 2018년 05월 18일 17:04에 Dan Carpenter 이(가) 쓴 글: > "id" needs to be signed for the error handling to work. Applied to exynos-drm-fixes-v4.18-rc1. Thanks, Inki Dae > > Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c > index 4dfbfc7f3b84..5ce84025d1cb 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c > @@ -1200,7 +1200,7 @@ static int fimc_setup_clocks(struct fimc_context *ctx) > > int exynos_drm_check_fimc_device(struct device *dev) > { > - unsigned int id = of_alias_get_id(dev->of_node, "fimc"); > + int id = of_alias_get_id(dev->of_node, "fimc"); > > if (id >= 0 && (BIT(id) & fimc_mask)) > return 0; > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-23 0:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180518080527epcas1p293dfaa13795c92f9239e8c9bd95af9ad@epcas1p2.samsung.com>
2018-05-18 8:04 ` [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks() Dan Carpenter
2018-05-23 0:33 ` Inki Dae
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).