From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel: simple: fix data type in KEO TX31D200VM0BAA timings Date: Fri, 18 May 2018 12:18:37 +0200 Message-ID: <20180518101837.GB5312@ulmo> References: <20180419212003.8155-1-stefan@agner.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1617679394==" Return-path: Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id D37296E428 for ; Fri, 18 May 2018 10:18:40 +0000 (UTC) Received: by mail-wr0-x242.google.com with SMTP id t16-v6so5452752wrm.9 for ; Fri, 18 May 2018 03:18:40 -0700 (PDT) In-Reply-To: <20180419212003.8155-1-stefan@agner.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stefan Agner Cc: airlied@linux.ie, jagannadh.teki@gmail.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1617679394== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p4qYPpj5QlsIQJ0K" Content-Disposition: inline --p4qYPpj5QlsIQJ0K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 19, 2018 at 11:20:03PM +0200, Stefan Agner wrote: > All values in a struct struct timing_entry (every entry in > struct display_timing) require an integer. Choose the closest > safe integer of 32. >=20 > This avoids a warning seen with clang: > drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit > conversion from 'double' to 'u32' (aka 'unsigned int') > changes value from 33.5 to 33 [-Wliteral-conversion] > .vfront_porch =3D { 6, 21, 33.5 }, > ~ ^~~~ > drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit > conversion from 'double' to 'u32' (aka 'unsigned int') > changes value from 33.5 to 33 [-Wliteral-conversion] > .vback_porch =3D { 6, 21, 33.5 }, > ~ ^~~~ >=20 > Signed-off-by: Stefan Agner > --- > drivers/gpu/drm/panel/panel-simple.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Thierry --p4qYPpj5QlsIQJ0K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlr+qH0ACgkQ3SOs138+ s6FvjBAAhcDhsnbc4CTMt8nKBhpQv2eI5RBuP1iI/Y9Sz6iuk/SJDMz/dKZKcihW IKufvzkEP/R7KSjGm4PIFihJMg6HsY2srkU3T1LvVII89GD6py3eAXdbAAmd3swg m3mEIYIWxjKsCcePfyCQ5X3iIgkRHFdPSJemEvrj3j4cM91EoS3bikr+2zO0XYlg k5u9U+CKvXql1w+A4WT1q4fr3luvF6KIdngtm9ZpbUouKyMgo/7SWPlCUuG3bhsv hl+VS9ru1uaHdce6zomTHJ4p18Mz5Wc7i3YHK8O/5r5tSRsIjYBS6B/hkj53R9mh ut7N0qQaS6asA5dWy2ljfy+fX7Noo0GLahyJ2w0bcgPFJRL64fJmgZ1jkbIui7NV 4rbEN+udE+It4/N0OajOaDS1Izv3+7axuju9YretE2EXxQxZMKFHRgt4R1FYTxr6 7Ypy2mQc8IpekiJxpWFc9H3uyqj2cI1M6jJ0/0Gv/FAMfVm2aEnLJ2keGb5WcPFg nmLMzhsmfTSzBNcalfrjZlRWfeRIvPpNFH8l7X9JJQT6fDmuh+KlDSVHZ+HhxwDI mwYv7ejuBLM1E66VmHpcurO6t2Tiz/6CPRdMUphb6BHKia+bqTX7vB/Kh+dmGWAC U6qPjTEeHeluWTXSRAp/RvHW+z0Ha0jXhN+58ElDRjqnejL6XNg= =KbKx -----END PGP SIGNATURE----- --p4qYPpj5QlsIQJ0K-- --===============1617679394== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1617679394==--