Re: [GIT PULL] TDA998x I2C driver CEC support

From: Russell King <rmk@armlinux.org.uk>
To: Daniel Vetter <daniel@ffwll.ch>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Airlie <airlied@linux.ie>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [GIT PULL] TDA998x I2C driver CEC support
Date: Wed, 23 May 2018 10:13:19 +0100	[thread overview]
Message-ID: <20180523091319.GB21976@flint.armlinux.org.uk> (raw)
In-Reply-To: <20180523084815.GM3438@phenom.ffwll.local>

On Wed, May 23, 2018 at 10:48:15AM +0200, Daniel Vetter wrote:
> On Tue, May 22, 2018 at 09:27:07AM +0100, Russell King wrote:
> > On Tue, May 22, 2018 at 10:53:49AM +1000, Dave Airlie wrote:
> > > Sorry I missed this, just fell between the cracks,
> > > 
> > > Any reason you can't/don't use git pull-request to generate pulls? we
> > > have some scripts that parse pulls for tracking now, but this pull
> > > didn't get into the system as it doesn't use the template.
> > 
> > I've never used git pull-request, and it doesn't seem to be part of
> > the git installation I have:
> 
> The command is called request-pull. Our scripting wraps it in
> pull-request, which I guess caused the confusion.

[Adding Linus]

Hmm, so where do people put the hand-written commentry in a git
request-pull formatted request that Linus likes to see when sending
such requests to Linus?

I can understand other maintainers not caring about that, but whatever
solution I have to this must work for sending to Linus as well - the
format of my pull requests are based on an example format from Linus
in the early days of git before request-pull even existed.  They also
satisfy Linus' other need which is that they need to be clearly
identifyable as truely being from the maintainer - I believe Linus
uses format and language in the request as part of that.

The other thing I notice is that the request-pull format is very
impersonal, doesn't say what the summary of changes are (it probably
has no way to do so), and contains no gratitudes - its tone is very
much like an order than a request.  Compare the one I sent in April
with this:

The following changes since commit 0adb32858b0bddf4ada5f364a84ed60b196dbcda:

  Linux 4.16 (2018-04-01 14:20:27 -0700)

are available in the git repository at:

  git://git.armlinux.org.uk/~rmk/linux-arm.git drm-tda998x-devel

for you to fetch changes up to ba52762fb1430b2a2ea8127c1a292c15f13b8dac:

  dt-bindings: tda998x: add the calibration gpio (2018-04-24 10:44:36 +0100)

----------------------------------------------------------------
Russell King (7):
      drm/i2c: tda998x: move mutex/waitqueue/timer/work init early
      drm/i2c: tda998x: fix error cleanup paths
      drm/i2c: tda998x: move CEC device initialisation later
      drm/i2c: tda998x: always disable and clear interrupts at probe
      drm/i2c: tda9950: add CEC driver
      drm/i2c: tda998x: add CEC support
      dt-bindings: tda998x: add the calibration gpio

 .../devicetree/bindings/display/bridge/tda998x.txt |   3 +
 drivers/gpu/drm/i2c/Kconfig                        |   6 +
 drivers/gpu/drm/i2c/Makefile                       |   1 +
 drivers/gpu/drm/i2c/tda9950.c                      | 509 +++++++++++++++++++++
 drivers/gpu/drm/i2c/tda998x_drv.c                  | 242 ++++++++--
 include/linux/platform_data/tda9950.h              |  16 +
 6 files changed, 750 insertions(+), 27 deletions(-)
 create mode 100644 drivers/gpu/drm/i2c/tda9950.c
 create mode 100644 include/linux/platform_data/tda9950.h

-- 
Russell King
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel