From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ayan Kumar Halder <ayan.halder@arm.com>
Cc: liviu.dudau@arm.com, brian.starkey@arm.com,
alexandru-cosmin.gheorghe@arm.com, gustavo@padovan.org,
maarten.lankhorst@linux.intel.com, seanpaul@chromium.org,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, nd@arm.com
Subject: Re: [PATCH] drm: check_pixel_format() should return true if no modifiers are passed for a supported pixel format
Date: Fri, 25 May 2018 18:54:56 +0300 [thread overview]
Message-ID: <20180525155456.GF23723@intel.com> (raw)
In-Reply-To: <1527262541-13964-1-git-send-email-ayan.halder@arm.com>
On Fri, May 25, 2018 at 04:35:41PM +0100, Ayan Kumar Halder wrote:
> If a plane supports a pixel format and the framebuffer does not pass any
> modifiers, then drm_plane_check_pixel_format() should always return true
> for the given format regardless of whether the plane supports any
> modifiers or not.
If your plane supports DRM_FORMAT_MOD_LINEAR then you should add that
to the plane's modifier list.
>
> Signed-off-by: Ayan Kumar Halder <ayan.halder@arm.com>
> ---
> drivers/gpu/drm/drm_plane.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
> index 6d2a6e4..873c084 100644
> --- a/drivers/gpu/drm/drm_plane.c
> +++ b/drivers/gpu/drm/drm_plane.c
> @@ -564,6 +564,9 @@ int drm_plane_check_pixel_format(struct drm_plane *plane,
> if (!plane->modifier_count)
> return 0;
>
> + if (modifier == DRM_FORMAT_MOD_NONE)
> + return 0;
> +
> for (i = 0; i < plane->modifier_count; i++) {
> if (modifier == plane->modifiers[i])
> break;
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2018-05-25 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 15:35 [PATCH] drm: check_pixel_format() should return true if no modifiers are passed for a supported pixel format Ayan Kumar Halder
2018-05-25 15:48 ` Brian Starkey
2018-05-25 16:08 ` Ville Syrjälä
2018-05-25 15:54 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525155456.GF23723@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=alexandru-cosmin.gheorghe@arm.com \
--cc=ayan.halder@arm.com \
--cc=brian.starkey@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=nd@arm.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).