From: Heiko Stuebner <heiko@sntech.de>
To: dri-devel@lists.freedesktop.org
Cc: marc.zyngier@arm.com, robin.murphy@arm.com,
jeffy.chen@rock-chips.com, tfiga@chromium.org,
linux-rockchip@lists.infradead.org,
enric.balletbo@collabora.co.uk, tomeu.vizoso@collabora.co.uk,
ezequiel@collabora.com
Subject: [PATCH v2 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change
Date: Mon, 28 May 2018 15:20:00 +0200 [thread overview]
Message-ID: <20180528132002.7712-1-heiko@sntech.de> (raw)
This still tries to address the hang seen by Ezequiel Garcia on rk3288.
As Tomasz noted, trying to count enablement can run into concurrency
issues, so instead we'll just check if the vop is runtime-enabled
to see if it could be the source of the irq and then just do our
own clk_enable in the isr to bridge the possible gap between
pm_runtime_enable and clk_enable in the core vop_enable() function.
Display tested to still work on rk3328 and rk3399, but as I don't see
the hang from Ezequiel I hope that this fixes it.
changes in v2:
- adapt approach ... don't try to count usage ourself, because of
possible concurrency issues with vop enable/disable
Heiko Stuebner (1):
drm/rockchip: vop: split out core clock enablement into separate
functions
Sandy Huang (1):
drm/rockchip: vop: fix irq disabled after vop driver probed
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 72 ++++++++++++++-------
1 file changed, 50 insertions(+), 22 deletions(-)
--
2.17.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2018-05-28 13:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 13:20 Heiko Stuebner [this message]
2018-05-28 13:20 ` [PATCH v2 1/2] drm/rockchip: vop: split out core clock enablement into separate functions Heiko Stuebner
2018-05-28 13:20 ` [PATCH v2 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed Heiko Stuebner
[not found] ` <20180528132002.7712-3-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2018-05-29 7:43 ` Marc Zyngier
2018-05-29 11:59 ` Robin Murphy
2018-05-29 12:17 ` Heiko Stübner
2018-05-29 17:43 ` Robin Murphy
[not found] ` <20180528132002.7712-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2018-05-30 17:18 ` [PATCH v2 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528132002.7712-1-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.co.uk \
--cc=ezequiel@collabora.com \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=robin.murphy@arm.com \
--cc=tfiga@chromium.org \
--cc=tomeu.vizoso@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).