From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused Date: Tue, 29 May 2018 16:38:20 +0200 Message-ID: <20180529143820.GD22634@ulmo> References: <20180525155030.3667352-1-arnd@arndb.de> <20180525155030.3667352-8-arnd@arndb.de> <20180528163243.538de32f@bbrezillon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0826161238==" Return-path: Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E56E6E337 for ; Tue, 29 May 2018 14:38:23 +0000 (UTC) Received: by mail-wr0-x244.google.com with SMTP id y15-v6so25946397wrg.11 for ; Tue, 29 May 2018 07:38:23 -0700 (PDT) In-Reply-To: <20180528163243.538de32f@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: Arnd Bergmann , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org --===============0826161238== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AbQceqfdZEv+FvjW" Content-Disposition: inline --AbQceqfdZEv+FvjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 28, 2018 at 04:32:43PM +0200, Boris Brezillon wrote: > +Thierry >=20 > Hi Arnd, >=20 > On Fri, 25 May 2018 17:50:15 +0200 > Arnd Bergmann wrote: >=20 > > These two functions are unused in some configurations, and using __mayb= e_unused > > is the easiest way to shut up the harmless warnings: > >=20 > > drivers/gpu/drm/bridge/cdns-dsi.c:1353:12: error: 'cdns_dsi_suspend' de= fined but not used [-Werror=3Dunused-function] > > static int cdns_dsi_suspend(struct device *dev) > > ^~~~~~~~~~~~~~~~ > > drivers/gpu/drm/bridge/cdns-dsi.c:1340:12: error: 'cdns_dsi_resume' def= ined but not used [-Werror=3Dunused-function] > > static int cdns_dsi_resume(struct device *dev) > >=20 > > Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") > > Signed-off-by: Arnd Bergmann >=20 > Hm, I thought such a patch had already been applied by Thierry [1]. >=20 > [1]https://www.spinics.net/lists/dri-devel/msg174363.html Yeah, that's in drm-misc-next, but didn't seem to have made it into linux-next until today. Thierry --AbQceqfdZEv+FvjW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlsNZdwACgkQ3SOs138+ s6F4HBAAiEcTbFfNEgt0B2F0aZmaJL+oMi35fsOc8w+6Q+WCIV6JncQrjVdORIBc NVcXK0nc0BA3TPOydDtDnHt6mxhM6wHdOVKSiFcIiZRnaQKV/WLZ+m1l+pUW9CJb 4saYvCDi+/xKUh2ISKyXu2AE1VQ7PNEBjFry8S2B4VevBxEJmkUFHSKgdKaUMum5 GZcWOF5bNYhs32tG4met3//szeYkMzWYX/auVWf8je8oDPphl4vLXiBnA/uj9xd6 aIcbnlvKP+ILjaqMd6Zi7bpSvHr57pYIRGxvu0bA+3daim/l3Rt6w8+NUcWEhvHy Uip4XNdz+Fd9Y2kwluwD+l7Z/27HgnxO1mI147UfAdUHu9zg1jMCDRj2yjbvw/MW X7UgjyM7TFlwJjBkF3WpJcS9ilRjdPDrz/+fbEDklCzCo54yFune9fgcpA1O8b5T x1Ze2/3VmQ2FJrWDt+LncRbVdIhHZDJJN2ijFgdx3UzXdzTkRmsgsfgScfKJSZN9 41I5Pmx4WlKR6XW5A4/6F9Ymsn8dufdTPm41ujwkqevRujvIMVkAL6wmpaQsiDHb NYh0+8+fdz8vwBRh58mTQe0fwfigUmTg69e4b8W7b3gqGAUITKQfdc7x3M4rRXzW xvsVhh8DgsI7A9ru+plNNzi/sBHpC0vMC8xmtsBeuDl5WGuem2U= =2/Rq -----END PGP SIGNATURE----- --AbQceqfdZEv+FvjW-- --===============0826161238== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0826161238==--