From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haneen Mohammed Subject: [PATCH v2] drm: Add checks for NULL drm_*_helper_funcs Date: Wed, 30 May 2018 03:42:59 +0300 Message-ID: <20180530004259.GA7981@haneen-vb> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 832866EFC6 for ; Wed, 30 May 2018 00:43:11 +0000 (UTC) Received: by mail-wr0-x243.google.com with SMTP id i12-v6so27766529wrc.4 for ; Tue, 29 May 2018 17:43:11 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Rodrigo Siqueira , David Airlie , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org VGhpcyBwYXRjaCBhZGQgY2hlY2tzIGZvciBOVUxMIGRybV9bY29ubmVjdG9yL2NydGMvcGxhbmVd X2hlbHBlcl9mdW5jcwpwb2ludGVycyBiZWZvcmUgZGVyZWZyZW5jaW5nIHRoZSB2YXJpYWJsZSB0 byBhdm9pZCBOVUxMIHBvaW50ZXIKZGVyZWZlcmVuY2UgYW5kIG1ha2UgdGhlIGhlbHBlciBmdW5j dGlvbnMgb3B0aW9uYWwgaW4gdGhlIGZvbGxvd2luZwpjYXNlczoKCjEpIHdoZW4gdXNpbmcgZHJt X2hlbHBlcl9wcm9iZV9zaW5nbGVfY29ubmVjdG9yX21vZGVzIGZvciBmaWxsX21vZGVzCmNhbGxi YWNrIGluIHRoZSBkcm1fY29ubmVjdG9yX2Z1bmNzLgoyKSB1c2luZyBkcm1fYXRvbWljX2hlbHBl cl9bY2hlY2svY29tbWl0XSBmb3IgYXRvbWljX1tjaGVjay9jb21taXRdCmNhbGxiYWNrcyBpbiB0 aGUgZHJtX21vZGVfY29uZmlnX2Z1bmNzLgoKVGhlIGRlcGVuZGVuY3kgaXMgYXMgZm9sbG93OgoK ZHJtX2Nvbm5lY3Rvcl9mdW5jczoKKiBmaWxsX21vZGVzID0gZHJtX2hlbHBlcl9wcm9iZV9zaW5n bGVfY29ubmVjdG9yX21vZGVzCgliKSBkcm1faGVscGVyX3Byb2JlX2RldGVjdCAtPiBkcm1fY29u bmVjdG9yX2hlbHBlcl9mdW5jcwoKZHJtX21vZGVfY29uZmlnX2Z1bmNzOgoqIGF0b21pY19jaGVj ayA9IGRybV9hdG9taWNfaGVscGVyX2NoZWNrCglhKSBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19t b2Rlc2V0IC0+IGRybV9jb25uZWN0b3IgaGVscGVyX2Z1bmNzCglhKSBoYW5kbGVfY29uZmxpY3Rp bmdfZW5jb2RlcnMgLT4gZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MKCWIpIG1vZGVfZml4dXAg LT4gZHJtX2NydGNfaGVscGVyX2Z1bmNzCgljKSB1cGRhdGVfY29ubmVjdG9yX3JvdXRpbmcgLT4g ZHJtX2Nvbm5lY3RvdF9oZWxwZXJfZnVuY3MKCiogYXRvbWljX2NvbW1pdCA9IGRybV9hdG9taWNf aGVscGVyX2NvbW1pdAoJYSkgZHJtX2F0b21pY19oZWxwZXJfcHJlcGFyZV9wbGFuZXMgLT4gZHJt X3BsYW5lX2hlbHBlcl9mdW5jcwoJYikgZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFuZXMg LT4gZHJtX3BsYW5lX2hlbHBlcl9mdW5jcwoKU2lnbmVkLW9mZi1ieTogSGFuZWVuIE1vaGFtbWVk IDxoYW1vaGFtbWVkLnNhQGdtYWlsLmNvbT4KLS0tCkNoYW5lcyBpbiB2MjoKLSBhZGQgdGhlIGxl YXN0IGFtb3VudCBvZiBjaGVja3MgdG8gbWFrZSB0aGUgaGVscGVycyBvcHRpb25hbCBmb3Igdmtt cwoKIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgMTYgKysrKysrKystLS0t LS0tLQogZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYyAgfCAgNSArKystLQogMiBm aWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fYXRvbWljX2hlbHBlci5jCmluZGV4IDJhN2NlY2E4MmI5ZS4uZmYzNjg0YzRhODNjIDEw MDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYworKysgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwpAQCAtMTEyLDkgKzExMiw5IEBAIHN0YXRp YyBpbnQgaGFuZGxlX2NvbmZsaWN0aW5nX2VuY29kZXJzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRl ICpzdGF0ZSwKIAkJaWYgKCFuZXdfY29ubl9zdGF0ZS0+Y3J0YykKIAkJCWNvbnRpbnVlOwogCi0J CWlmIChmdW5jcy0+YXRvbWljX2Jlc3RfZW5jb2RlcikKKwkJaWYgKGZ1bmNzICYmIGZ1bmNzLT5h dG9taWNfYmVzdF9lbmNvZGVyKQogCQkJbmV3X2VuY29kZXIgPSBmdW5jcy0+YXRvbWljX2Jlc3Rf ZW5jb2Rlcihjb25uZWN0b3IsIG5ld19jb25uX3N0YXRlKTsKLQkJZWxzZSBpZiAoZnVuY3MtPmJl c3RfZW5jb2RlcikKKwkJZWxzZSBpZiAoZnVuY3MgJiYgZnVuY3MtPmJlc3RfZW5jb2RlcikKIAkJ CW5ld19lbmNvZGVyID0gZnVuY3MtPmJlc3RfZW5jb2Rlcihjb25uZWN0b3IpOwogCQllbHNlCiAJ CQluZXdfZW5jb2RlciA9IGRybV9hdG9taWNfaGVscGVyX2Jlc3RfZW5jb2Rlcihjb25uZWN0b3Ip OwpAQCAtMzA4LDEwICszMDgsMTAgQEAgdXBkYXRlX2Nvbm5lY3Rvcl9yb3V0aW5nKHN0cnVjdCBk cm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKIAogCWZ1bmNzID0gY29ubmVjdG9yLT5oZWxwZXJfcHJp dmF0ZTsKIAotCWlmIChmdW5jcy0+YXRvbWljX2Jlc3RfZW5jb2RlcikKKwlpZiAoZnVuY3MgJiYg ZnVuY3MtPmF0b21pY19iZXN0X2VuY29kZXIpCiAJCW5ld19lbmNvZGVyID0gZnVuY3MtPmF0b21p Y19iZXN0X2VuY29kZXIoY29ubmVjdG9yLAogCQkJCQkJCSBuZXdfY29ubmVjdG9yX3N0YXRlKTsK LQllbHNlIGlmIChmdW5jcy0+YmVzdF9lbmNvZGVyKQorCWVsc2UgaWYgKGZ1bmNzICYmIGZ1bmNz LT5iZXN0X2VuY29kZXIpCiAJCW5ld19lbmNvZGVyID0gZnVuY3MtPmJlc3RfZW5jb2Rlcihjb25u ZWN0b3IpOwogCWVsc2UKIAkJbmV3X2VuY29kZXIgPSBkcm1fYXRvbWljX2hlbHBlcl9iZXN0X2Vu Y29kZXIoY29ubmVjdG9yKTsKQEAgLTQzOCw3ICs0MzgsNyBAQCBtb2RlX2ZpeHVwKHN0cnVjdCBk cm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKIAkJCWNvbnRpbnVlOwogCiAJCWZ1bmNzID0gY3J0Yy0+ aGVscGVyX3ByaXZhdGU7Ci0JCWlmICghZnVuY3MtPm1vZGVfZml4dXApCisJCWlmICghZnVuY3Mg fHwgIWZ1bmNzLT5tb2RlX2ZpeHVwKQogCQkJY29udGludWU7CiAKIAkJcmV0ID0gZnVuY3MtPm1v ZGVfZml4dXAoY3J0YywgJm5ld19jcnRjX3N0YXRlLT5tb2RlLApAQCAtNjM5LDcgKzYzOSw3IEBA IGRybV9hdG9taWNfaGVscGVyX2NoZWNrX21vZGVzZXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwK IAkJCQluZXdfY3J0Y19zdGF0ZS0+Y29ubmVjdG9yc19jaGFuZ2VkID0gdHJ1ZTsKIAkJfQogCi0J CWlmIChmdW5jcy0+YXRvbWljX2NoZWNrKQorCQlpZiAoZnVuY3MgJiYgZnVuY3MtPmF0b21pY19j aGVjaykKIAkJCXJldCA9IGZ1bmNzLT5hdG9taWNfY2hlY2soY29ubmVjdG9yLCBuZXdfY29ubmVj dG9yX3N0YXRlKTsKIAkJaWYgKHJldCkKIAkJCXJldHVybiByZXQ7CkBAIC0yMTE3LDcgKzIxMTcs NyBAQCBpbnQgZHJtX2F0b21pY19oZWxwZXJfcHJlcGFyZV9wbGFuZXMoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwKIAogCQlmdW5jcyA9IHBsYW5lLT5oZWxwZXJfcHJpdmF0ZTsKIAotCQlpZiAoZnVu Y3MtPnByZXBhcmVfZmIpIHsKKwkJaWYgKGZ1bmNzICYmIGZ1bmNzLT5wcmVwYXJlX2ZiKSB7CiAJ CQlyZXQgPSBmdW5jcy0+cHJlcGFyZV9mYihwbGFuZSwgbmV3X3BsYW5lX3N0YXRlKTsKIAkJCWlm IChyZXQpCiAJCQkJZ290byBmYWlsOwpAQCAtMjQxMiw3ICsyNDEyLDcgQEAgdm9pZCBkcm1fYXRv bWljX2hlbHBlcl9jbGVhbnVwX3BsYW5lcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAogCiAJCWZ1 bmNzID0gcGxhbmUtPmhlbHBlcl9wcml2YXRlOwogCi0JCWlmIChmdW5jcy0+Y2xlYW51cF9mYikK KwkJaWYgKGZ1bmNzICYmIGZ1bmNzLT5jbGVhbnVwX2ZiKQogCQkJZnVuY3MtPmNsZWFudXBfZmIo cGxhbmUsIHBsYW5lX3N0YXRlKTsKIAl9CiB9CmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX3Byb2JlX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwpp bmRleCA1Mjc3NDMzOTQxNTAuLjJmZWE1NGQxNmViYiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9wcm9iZV9oZWxwZXIuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hl bHBlci5jCkBAIC0zMjAsNyArMzIwLDcgQEAgZHJtX2hlbHBlcl9wcm9iZV9kZXRlY3Qoc3RydWN0 IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKIAlpZiAocmV0KQogCQlyZXR1cm4gcmV0OwogCi0J aWYgKGZ1bmNzLT5kZXRlY3RfY3R4KQorCWlmIChmdW5jcyAmJiBmdW5jcy0+ZGV0ZWN0X2N0eCkK IAkJcmV0dXJuIGZ1bmNzLT5kZXRlY3RfY3R4KGNvbm5lY3RvciwgY3R4LCBmb3JjZSk7CiAJZWxz ZSBpZiAoY29ubmVjdG9yLT5mdW5jcy0+ZGV0ZWN0KQogCQlyZXR1cm4gY29ubmVjdG9yLT5mdW5j cy0+ZGV0ZWN0KGNvbm5lY3RvciwgZm9yY2UpOwpAQCAtNDgwLDcgKzQ4MCw4IEBAIGludCBkcm1f aGVscGVyX3Byb2JlX3NpbmdsZV9jb25uZWN0b3JfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3RvciwKIAkJZ290byBwcnVuZTsKIAl9CiAKLQljb3VudCA9ICgqY29ubmVjdG9yX2Z1 bmNzLT5nZXRfbW9kZXMpKGNvbm5lY3Rvcik7CisJaWYgKGNvbm5lY3Rvcl9mdW5jcyAmJiBjb25u ZWN0b3JfZnVuY3MtPmdldF9tb2RlcykKKwkJY291bnQgPSAoKmNvbm5lY3Rvcl9mdW5jcy0+Z2V0 X21vZGVzKShjb25uZWN0b3IpOwogCiAJaWYgKGNvdW50ID09IDAgJiYgY29ubmVjdG9yLT5zdGF0 dXMgPT0gY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQpCiAJCWNvdW50ID0gZHJtX2FkZF9tb2Rl c19ub2VkaWQoY29ubmVjdG9yLCAxMDI0LCA3NjgpOwotLSAKMi4xNy4wCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK