From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 02/13] drm/vmwgfx: Stop using plane->fb in vmw_kms_helper_dirty() Date: Wed, 30 May 2018 23:08:57 +0300 Message-ID: <20180530200857.GS23723@intel.com> References: <20180525185045.29689-1-ville.syrjala@linux.intel.com> <20180525185045.29689-3-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180525185045.29689-3-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Thomas Hellstrom , Daniel Vetter , intel-gfx@lists.freedesktop.org, VMware Graphics , Deepak Rawat List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXkgMjUsIDIwMTggYXQgMDk6NTA6MzRQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IEluc3RlYWQgb2YgcGxhbmUtPmZiICh3aGljaCB3ZSdyZSBnb2luZyB0byBkZXBy ZWNhdGUgZm9yIGF0b21pYyBkcml2ZXJzKQo+IHdlIG5lZWQgdG8gbG9vayBhdCBwbGFuZS0+c3Rh dGUtPmZiLiBUaGUgbWF6ZSBvZiBjb2RlIGxlYWRpbmcgdG8KPiB2bXdfa21zX2hlbHBlcl9kaXJ0 eSgpIHdhc24ndCBwYXJ0aWN1bGFybHkgY2xlYXIsIGJ1dCBteSBhbmFseXNpcwo+IGNvbmNsdWRl ZCB0aGF0IHRoZSBjYWxscyBvcmlnaW5hdGluZyBmcm9tIHZtd18qX3ByaW1hcnlfcGxhbmVfYXRv bWljX3VwZGF0ZSgpCj4gYWxsIHBhc3MgaW4gdGhlIGNydGMgd2hpY2ggbWVhbnMgd2UnbGwgbmV2 ZXIgZW5kIHVwIGluIHRoaXMgYnJhbmNoCj4gb2YgdGhlIGZ1bmN0aW9uLiBBbGwgb3RoZXIgY2Fs bGVycyB1c2UgZHJtX21vZGVzZXRfbG9ja19hbGwoKSBzb21ld2hlcmUKPiBoaWdoZXIgdXAsIHdo aWNoIG1lYW5zIGFjY2Vzc2luZyBwbGFuZS0+c3RhdGUgaXMgc2FmZS4gV2UnbGwgdG9zcyBpbgo+ IGEgbG9ja2RlcCBhc3NlcnQgdG8gY2F0Y2ggd3Jvbmdkb2Vycy4KPiAKPiB2MjogRHJvcCB0aGUg Y29tbWVudCBhbmQgbWFrZSB0aGUgY29kZSBkbyB3aGF0IGl0IGRpZCBiZWZvcmUgKFRob21hcykK PiAKPiBDYzogRGVlcGFrIFJhd2F0IDxkcmF3YXRAdm13YXJlLmNvbT4KPiBDYzogVGhvbWFzIEhl bGxzdHJvbSA8dGhlbGxzdHJvbUB2bXdhcmUuY29tPgo+IENjOiBTaW5jbGFpciBZZWggPHN5ZWhA dm13YXJlLmNvbT4KPiBDYzogVk13YXJlIEdyYXBoaWNzIDxsaW51eC1ncmFwaGljcy1tYWludGFp bmVyQHZtd2FyZS5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwu Y2g+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMg fCA5ICsrKysrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9r bXMuYyBiL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2ttcy5jCj4gaW5kZXggMmU0YzM4 YmI4NDZkLi41NDE3ZWIxYjQ4NmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dm eC92bXdnZnhfa21zLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9rbXMu Ywo+IEBAIC0yMzI2LDkgKzIzMjYsMTIgQEAgaW50IHZtd19rbXNfaGVscGVyX2RpcnR5KHN0cnVj dCB2bXdfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAl9IGVsc2Ugewo+ICAJCWxpc3RfZm9yX2VhY2hf ZW50cnkoY3J0YywgJmRldl9wcml2LT5kZXYtPm1vZGVfY29uZmlnLmNydGNfbGlzdCwKPiAgCQkJ CSAgICBoZWFkKSB7Cj4gLQkJCWlmIChjcnRjLT5wcmltYXJ5LT5mYiAhPSAmZnJhbWVidWZmZXIt PmJhc2UpCj4gLQkJCQljb250aW51ZTsKPiAtCQkJdW5pdHNbbnVtX3VuaXRzKytdID0gdm13X2Ny dGNfdG9fZHUoY3J0Yyk7Cj4gKwkJCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lID0gY3J0Yy0+cHJp bWFyeTsKPiArCj4gKwkJCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJnBsYW5lLT5tdXRleCk7CgprYnVp bGQgdGVzdCByb2JvdCB0b2xkIG1lCj4+IGluY2x1ZGUvbGludXgvbG9ja2RlcC5oOjM0Nzo1Mjog ZXJyb3I6ICdzdHJ1Y3QgZHJtX21vZGVzZXRfbG9jaycgaGFzCj4+IG5vIG1lbWJlciBuYW1lZCAn ZGVwX21hcCcgICAgICAgICAgICAgICAgICAgICAgCiAgICAjZGVmaW5lIGxvY2tkZXBfaXNfaGVs ZChsb2NrKSAgbG9ja19pc19oZWxkKCYobG9jayktPmRlcF9tYXApICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCgpNYXliZSBJJ2xsIGp1c3QgZHJv cCB0aGUgYXNzZXJ0cz8gT3IgZG8gcGVvcGxlIHJlYWxseSB3YW50IHRoZW0KKGluIHdoaWNoIGNh c2UgSSBndWVzIEkgbmVlZCB0byBkaWcgb3V0IHRoZSB1bmRlcmx5aW5nIG11dGV4KT8KCj4gKwo+ ICsJCQlpZiAocGxhbmUtPnN0YXRlLT5mYiA9PSAmZnJhbWVidWZmZXItPmJhc2UpCj4gKwkJCQl1 bml0c1tudW1fdW5pdHMrK10gPSB2bXdfY3J0Y190b19kdShjcnRjKTsKPiAgCQl9Cj4gIAl9Cj4g IAo+IC0tIAo+IDIuMTYuMQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK