From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm: Add checks for NULL drm_*_helper_funcs Date: Thu, 31 May 2018 10:01:04 +0200 Message-ID: <20180531080104.GQ3438@phenom.ffwll.local> References: <20180530004259.GA7981@haneen-vb> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 810FA6E224 for ; Thu, 31 May 2018 08:01:08 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id 18-v6so46697083wml.2 for ; Thu, 31 May 2018 01:01:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180530004259.GA7981@haneen-vb> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Haneen Mohammed Cc: Rodrigo Siqueira , David Airlie , dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMzAsIDIwMTggYXQgMDM6NDI6NTlBTSArMDMwMCwgSGFuZWVuIE1vaGFtbWVk IHdyb3RlOgo+IFRoaXMgcGF0Y2ggYWRkIGNoZWNrcyBmb3IgTlVMTCBkcm1fW2Nvbm5lY3Rvci9j cnRjL3BsYW5lXV9oZWxwZXJfZnVuY3MKPiBwb2ludGVycyBiZWZvcmUgZGVyZWZyZW5jaW5nIHRo ZSB2YXJpYWJsZSB0byBhdm9pZCBOVUxMIHBvaW50ZXIKPiBkZXJlZmVyZW5jZSBhbmQgbWFrZSB0 aGUgaGVscGVyIGZ1bmN0aW9ucyBvcHRpb25hbCBpbiB0aGUgZm9sbG93aW5nCj4gY2FzZXM6Cj4g Cj4gMSkgd2hlbiB1c2luZyBkcm1faGVscGVyX3Byb2JlX3NpbmdsZV9jb25uZWN0b3JfbW9kZXMg Zm9yIGZpbGxfbW9kZXMKPiBjYWxsYmFjayBpbiB0aGUgZHJtX2Nvbm5lY3Rvcl9mdW5jcy4KPiAy KSB1c2luZyBkcm1fYXRvbWljX2hlbHBlcl9bY2hlY2svY29tbWl0XSBmb3IgYXRvbWljX1tjaGVj ay9jb21taXRdCj4gY2FsbGJhY2tzIGluIHRoZSBkcm1fbW9kZV9jb25maWdfZnVuY3MuCj4gCj4g VGhlIGRlcGVuZGVuY3kgaXMgYXMgZm9sbG93Ogo+IAo+IGRybV9jb25uZWN0b3JfZnVuY3M6Cj4g KiBmaWxsX21vZGVzID0gZHJtX2hlbHBlcl9wcm9iZV9zaW5nbGVfY29ubmVjdG9yX21vZGVzCj4g CWIpIGRybV9oZWxwZXJfcHJvYmVfZGV0ZWN0IC0+IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNz Cj4gCj4gZHJtX21vZGVfY29uZmlnX2Z1bmNzOgo+ICogYXRvbWljX2NoZWNrID0gZHJtX2F0b21p Y19oZWxwZXJfY2hlY2sKPiAJYSkgZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfbW9kZXNldCAtPiBk cm1fY29ubmVjdG9yIGhlbHBlcl9mdW5jcwo+IAlhKSBoYW5kbGVfY29uZmxpY3RpbmdfZW5jb2Rl cnMgLT4gZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MKPiAJYikgbW9kZV9maXh1cCAtPiBkcm1f Y3J0Y19oZWxwZXJfZnVuY3MKPiAJYykgdXBkYXRlX2Nvbm5lY3Rvcl9yb3V0aW5nIC0+IGRybV9j b25uZWN0b3RfaGVscGVyX2Z1bmNzCj4gCj4gKiBhdG9taWNfY29tbWl0ID0gZHJtX2F0b21pY19o ZWxwZXJfY29tbWl0Cj4gCWEpIGRybV9hdG9taWNfaGVscGVyX3ByZXBhcmVfcGxhbmVzIC0+IGRy bV9wbGFuZV9oZWxwZXJfZnVuY3MKPiAJYikgZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFu ZXMgLT4gZHJtX3BsYW5lX2hlbHBlcl9mdW5jcwo+IAo+IFNpZ25lZC1vZmYtYnk6IEhhbmVlbiBN b2hhbW1lZCA8aGFtb2hhbW1lZC5zYUBnbWFpbC5jb20+CgpPaywgSSB0aGluayBtYWtpbmcgZHJt X2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3Mgb3B0aW9uYWwgbWFrZXMgc29tZSBzZW5zZSAtCi0+YmVz dF9jb25uZWN0b3IgaGFzIGEgZGVmYXVsdCBpbXBsZW1lbmF0aW9uIHRoYXQgd29ya3MgZm9yIGFs bW9zdApldmVyeW9uZSwgYW5kIGlmIHlvdSBkb24ndCBoYXZlIGEgd2F5IHRvIGRldGVjdCB0aGUg b3V0cHV0IGl0J3Mgc2lsbHkgdG8KaGF2ZSBhIGRlZmF1bHQgaW1wbGVtZW50YXRpb24gdGhhdCBk b2VzIG5vdGhpbmcuCgpCdXQgbWFraW5nIHRoZSBwbGFuZS9jcnRjIGZ1bmNzIG9wdGlvbmFsIGdp dmVzIHlvdSBhIGRyaXZlciB3aGljaCBkb2VzCmV4YWN0bHkgbm90aGluZywgYW5kIHRoYXQncyBu b3QgdGVycmlibHkgdXNlZnVsLgoKSSB0aGluayByZXNwaW5uaW5nIHRoaXMgdG8ganVzdCBtYWtl IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNzIG9wdGlvbmFsCmlzIHJlYXNvbmFibGUsIGFuZCBm b3IgYWxsIG90aGVycyB3ZSBuZWVkIHRvIHN0YXJ0IG1ha2luZyB2a21zIGZ1bmN0aW9uYWwKOi0p CgpDaGVlcnMsIERhbmllbAoKPiAtLS0KPiBDaGFuZXMgaW4gdjI6Cj4gLSBhZGQgdGhlIGxlYXN0 IGFtb3VudCBvZiBjaGVja3MgdG8gbWFrZSB0aGUgaGVscGVycyBvcHRpb25hbCBmb3Igdmttcwo+ IAo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8IDE2ICsrKysrKysrLS0t LS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYyAgfCAgNSArKystLQo+ ICAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gaW5kZXggMmE3Y2VjYTgyYjllLi5mZjM2 ODRjNGE4M2MgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVy LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IEBAIC0xMTIs OSArMTEyLDkgQEAgc3RhdGljIGludCBoYW5kbGVfY29uZmxpY3RpbmdfZW5jb2RlcnMoc3RydWN0 IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICAJCWlmICghbmV3X2Nvbm5fc3RhdGUtPmNydGMp Cj4gIAkJCWNvbnRpbnVlOwo+ICAKPiAtCQlpZiAoZnVuY3MtPmF0b21pY19iZXN0X2VuY29kZXIp Cj4gKwkJaWYgKGZ1bmNzICYmIGZ1bmNzLT5hdG9taWNfYmVzdF9lbmNvZGVyKQo+ICAJCQluZXdf ZW5jb2RlciA9IGZ1bmNzLT5hdG9taWNfYmVzdF9lbmNvZGVyKGNvbm5lY3RvciwgbmV3X2Nvbm5f c3RhdGUpOwo+IC0JCWVsc2UgaWYgKGZ1bmNzLT5iZXN0X2VuY29kZXIpCj4gKwkJZWxzZSBpZiAo ZnVuY3MgJiYgZnVuY3MtPmJlc3RfZW5jb2RlcikKPiAgCQkJbmV3X2VuY29kZXIgPSBmdW5jcy0+ YmVzdF9lbmNvZGVyKGNvbm5lY3Rvcik7Cj4gIAkJZWxzZQo+ICAJCQluZXdfZW5jb2RlciA9IGRy bV9hdG9taWNfaGVscGVyX2Jlc3RfZW5jb2Rlcihjb25uZWN0b3IpOwo+IEBAIC0zMDgsMTAgKzMw OCwxMCBAQCB1cGRhdGVfY29ubmVjdG9yX3JvdXRpbmcoc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlLAo+ICAKPiAgCWZ1bmNzID0gY29ubmVjdG9yLT5oZWxwZXJfcHJpdmF0ZTsKPiAgCj4g LQlpZiAoZnVuY3MtPmF0b21pY19iZXN0X2VuY29kZXIpCj4gKwlpZiAoZnVuY3MgJiYgZnVuY3Mt PmF0b21pY19iZXN0X2VuY29kZXIpCj4gIAkJbmV3X2VuY29kZXIgPSBmdW5jcy0+YXRvbWljX2Jl c3RfZW5jb2Rlcihjb25uZWN0b3IsCj4gIAkJCQkJCQkgbmV3X2Nvbm5lY3Rvcl9zdGF0ZSk7Cj4g LQllbHNlIGlmIChmdW5jcy0+YmVzdF9lbmNvZGVyKQo+ICsJZWxzZSBpZiAoZnVuY3MgJiYgZnVu Y3MtPmJlc3RfZW5jb2RlcikKPiAgCQluZXdfZW5jb2RlciA9IGZ1bmNzLT5iZXN0X2VuY29kZXIo Y29ubmVjdG9yKTsKPiAgCWVsc2UKPiAgCQluZXdfZW5jb2RlciA9IGRybV9hdG9taWNfaGVscGVy X2Jlc3RfZW5jb2Rlcihjb25uZWN0b3IpOwo+IEBAIC00MzgsNyArNDM4LDcgQEAgbW9kZV9maXh1 cChzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIAkJCWNvbnRpbnVlOwo+ICAKPiAg CQlmdW5jcyA9IGNydGMtPmhlbHBlcl9wcml2YXRlOwo+IC0JCWlmICghZnVuY3MtPm1vZGVfZml4 dXApCj4gKwkJaWYgKCFmdW5jcyB8fCAhZnVuY3MtPm1vZGVfZml4dXApCj4gIAkJCWNvbnRpbnVl Owo+ICAKPiAgCQlyZXQgPSBmdW5jcy0+bW9kZV9maXh1cChjcnRjLCAmbmV3X2NydGNfc3RhdGUt Pm1vZGUsCj4gQEAgLTYzOSw3ICs2MzksNyBAQCBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rl c2V0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCQluZXdfY3J0Y19zdGF0ZS0+Y29ubmVj dG9yc19jaGFuZ2VkID0gdHJ1ZTsKPiAgCQl9Cj4gIAo+IC0JCWlmIChmdW5jcy0+YXRvbWljX2No ZWNrKQo+ICsJCWlmIChmdW5jcyAmJiBmdW5jcy0+YXRvbWljX2NoZWNrKQo+ICAJCQlyZXQgPSBm dW5jcy0+YXRvbWljX2NoZWNrKGNvbm5lY3RvciwgbmV3X2Nvbm5lY3Rvcl9zdGF0ZSk7Cj4gIAkJ aWYgKHJldCkKPiAgCQkJcmV0dXJuIHJldDsKPiBAQCAtMjExNyw3ICsyMTE3LDcgQEAgaW50IGRy bV9hdG9taWNfaGVscGVyX3ByZXBhcmVfcGxhbmVzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4g IAo+ICAJCWZ1bmNzID0gcGxhbmUtPmhlbHBlcl9wcml2YXRlOwo+ICAKPiAtCQlpZiAoZnVuY3Mt PnByZXBhcmVfZmIpIHsKPiArCQlpZiAoZnVuY3MgJiYgZnVuY3MtPnByZXBhcmVfZmIpIHsKPiAg CQkJcmV0ID0gZnVuY3MtPnByZXBhcmVfZmIocGxhbmUsIG5ld19wbGFuZV9zdGF0ZSk7Cj4gIAkJ CWlmIChyZXQpCj4gIAkJCQlnb3RvIGZhaWw7Cj4gQEAgLTI0MTIsNyArMjQxMiw3IEBAIHZvaWQg ZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFuZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwK PiAgCj4gIAkJZnVuY3MgPSBwbGFuZS0+aGVscGVyX3ByaXZhdGU7Cj4gIAo+IC0JCWlmIChmdW5j cy0+Y2xlYW51cF9mYikKPiArCQlpZiAoZnVuY3MgJiYgZnVuY3MtPmNsZWFudXBfZmIpCj4gIAkJ CWZ1bmNzLT5jbGVhbnVwX2ZiKHBsYW5lLCBwbGFuZV9zdGF0ZSk7Cj4gIAl9Cj4gIH0KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fcHJvYmVfaGVscGVyLmMKPiBpbmRleCA1Mjc3NDMzOTQxNTAuLjJmZWE1NGQxNmVi YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwo+IEBAIC0zMjAsNyArMzIwLDcg QEAgZHJtX2hlbHBlcl9wcm9iZV9kZXRlY3Qoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rv ciwKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gLQlpZiAoZnVuY3MtPmRldGVj dF9jdHgpCj4gKwlpZiAoZnVuY3MgJiYgZnVuY3MtPmRldGVjdF9jdHgpCj4gIAkJcmV0dXJuIGZ1 bmNzLT5kZXRlY3RfY3R4KGNvbm5lY3RvciwgY3R4LCBmb3JjZSk7Cj4gIAllbHNlIGlmIChjb25u ZWN0b3ItPmZ1bmNzLT5kZXRlY3QpCj4gIAkJcmV0dXJuIGNvbm5lY3Rvci0+ZnVuY3MtPmRldGVj dChjb25uZWN0b3IsIGZvcmNlKTsKPiBAQCAtNDgwLDcgKzQ4MCw4IEBAIGludCBkcm1faGVscGVy X3Byb2JlX3NpbmdsZV9jb25uZWN0b3JfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5l Y3RvciwKPiAgCQlnb3RvIHBydW5lOwo+ICAJfQo+ICAKPiAtCWNvdW50ID0gKCpjb25uZWN0b3Jf ZnVuY3MtPmdldF9tb2RlcykoY29ubmVjdG9yKTsKPiArCWlmIChjb25uZWN0b3JfZnVuY3MgJiYg Y29ubmVjdG9yX2Z1bmNzLT5nZXRfbW9kZXMpCj4gKwkJY291bnQgPSAoKmNvbm5lY3Rvcl9mdW5j cy0+Z2V0X21vZGVzKShjb25uZWN0b3IpOwo+ICAKPiAgCWlmIChjb3VudCA9PSAwICYmIGNvbm5l Y3Rvci0+c3RhdHVzID09IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkKQo+ICAJCWNvdW50ID0g ZHJtX2FkZF9tb2Rlc19ub2VkaWQoY29ubmVjdG9yLCAxMDI0LCA3NjgpOwo+IC0tIAo+IDIuMTcu MAo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=