dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: rkir@google.com
To: b.zolnierkie@samsung.com, rkir@google.com
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Christoffer Dall <christoffer.dall@linaro.org>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH 3/3] ANDROID: goldfish_fb: Set pixclock = 0
Date: Thu, 31 May 2018 15:02:52 -0700	[thread overview]
Message-ID: <20180531220252.58679-3-rkir@google.com> (raw)
In-Reply-To: <20180531220252.58679-1-rkir@google.com>

From: Christoffer Dall <christoffer.dall@linaro.org>

User space Android code identifies pixclock == 0 as a sign for emulation
and will set the frame rate to 60 fps when reading this value, which is
the desired outcome.

Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 drivers/video/fbdev/goldfishfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
index 01732858b60d..3a9e5f1b758e 100644
--- a/drivers/video/fbdev/goldfishfb.c
+++ b/drivers/video/fbdev/goldfishfb.c
@@ -237,7 +237,7 @@ static int goldfish_fb_probe(struct platform_device *pdev)
 	fb->fb.var.activate	= FB_ACTIVATE_NOW;
 	fb->fb.var.height	= readl(fb->reg_base + FB_GET_PHYS_HEIGHT);
 	fb->fb.var.width	= readl(fb->reg_base + FB_GET_PHYS_WIDTH);
-	fb->fb.var.pixclock	= 10000;
+	fb->fb.var.pixclock	= 0;
 
 	fb->fb.var.red.offset = 11;
 	fb->fb.var.red.length = 5;
-- 
2.17.0.921.gf22659ad46-goog

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-05-31 22:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 22:02 [PATCH 1/3] Fix checkpatch warnings in goldfishfb.c rkir
2018-05-31 22:02 ` [PATCH 2/3] goldfish: Enable ACPI-based enumeration for goldfish framebuffer rkir
2018-06-08 16:21   ` Bartlomiej Zolnierkiewicz
2018-05-31 22:02 ` rkir [this message]
2018-06-08 16:23   ` [PATCH 3/3] ANDROID: goldfish_fb: Set pixclock = 0 Bartlomiej Zolnierkiewicz
2018-06-08 23:40     ` Roman Kiryanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180531220252.58679-3-rkir@google.com \
    --to=rkir@google.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=christoffer.dall@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=peter.maydell@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox