dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: "Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Maxime Ripard" <maxime.ripard@free-electrons.com>,
	dri-devel@lists.freedesktop.org,
	"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>,
	Ben Skeggs <bskeggs@redhat.com>, Sinclair Yeh <syeh@vmware.com>,
	Thomas Hellstrom <thellstrom@vmware.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH v3 0/2] drm: Add generic colorkey plane properties
Date: Mon,  4 Jun 2018 01:00:57 +0300	[thread overview]
Message-ID: <20180603220059.17670-1-digetx@gmail.com> (raw)

Hello,

In this version I've reduced color keying modes and properties to a bare
minimum because considering several modes and properties at once might take
quite a lot of effort due to a variety of HW capabilities. This allows us to
start easy with the generic colorkey properties support.

For the starter let's implement probably the most common (and simple) color
keying mode - the "green screen" (or "chroma key") mode. More advanced modes
and features could be implemented later on by as needed basis.

Following Ville's Syrjälä review comments to v2, the color key value is now
given in ARGB16161616 format. Drivers have to convert this 16bpc format into
internal color key value representation themselves. This works well for cases
where conversion is done to a non-planar integer formats, but I'm not sure how
drivers are supposed to cope with cases where conversion involves churning with
fixed point math / floating point representation. Comments are welcome.

v2: https://lists.freedesktop.org/archives/dri-devel/2018-May/178408.html
v1: https://lists.freedesktop.org/archives/dri-devel/2017-December/160510.html

Dmitry Osipenko (1):
  drm/tegra: plane: Implement generic colorkey property for older
    Tegra's

Laurent Pinchart (1):
  drm: Add generic colorkey properties for DRM planes

 drivers/gpu/drm/drm_atomic.c  |  12 ++++
 drivers/gpu/drm/drm_blend.c   |  99 +++++++++++++++++++++++++++++++++
 drivers/gpu/drm/tegra/dc.c    |  25 +++++++++
 drivers/gpu/drm/tegra/dc.h    |   7 +++
 drivers/gpu/drm/tegra/plane.c | 102 ++++++++++++++++++++++++++++++++++
 include/drm/drm_blend.h       |   3 +
 include/drm/drm_plane.h       |  53 ++++++++++++++++++
 7 files changed, 301 insertions(+)

-- 
2.17.0

             reply	other threads:[~2018-06-03 22:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-03 22:00 Dmitry Osipenko [this message]
2018-06-03 22:00 ` [RFC PATCH v3 1/2] drm: Add generic colorkey properties for DRM planes Dmitry Osipenko
2018-07-06 12:11   ` Maarten Lankhorst
2018-07-06 12:23     ` Ville Syrjälä
2018-07-06 13:05       ` Dmitry Osipenko
2018-07-06 14:10         ` Ville Syrjälä
2018-07-06 14:58           ` Maarten Lankhorst
2018-07-06 14:58           ` Dmitry Osipenko
2018-07-06 15:40             ` Russell King - ARM Linux
2018-07-06 16:32               ` Ville Syrjälä
2018-07-06 16:33               ` Dmitry Osipenko
2018-07-06 17:01                 ` Russell King - ARM Linux
2018-07-06 19:48                   ` Dmitry Osipenko
2018-06-03 22:00 ` [RFC PATCH v3 2/2] drm/tegra: plane: Implement generic colorkey property for older Tegra's Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180603220059.17670-1-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.ripard@free-electrons.com \
    --cc=narmstrong@baylibre.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=syeh@vmware.com \
    --cc=thellstrom@vmware.com \
    --cc=thierry.reding@gmail.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).