From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinclair Yeh Subject: Re: [PATCH v2 02/13] drm/vmwgfx: Stop using plane->fb in vmw_kms_helper_dirty() Date: Mon, 4 Jun 2018 11:13:53 -0700 Message-ID: <20180604181352.GA31191@vmware.com> References: <20180525185045.29689-1-ville.syrjala@linux.intel.com> <20180525185045.29689-3-ville.syrjala@linux.intel.com> <20180530200857.GS23723@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180530200857.GS23723@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Thomas Hellstrom , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, VMware Graphics , Deepak Rawat List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMzAsIDIwMTggYXQgMTE6MDg6NTdQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgTWF5IDI1LCAyMDE4IGF0IDA5OjUwOjM0UE0gKzAzMDAsIFZpbGxl IFN5cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+ID4gCj4gPiBJbnN0ZWFkIG9mIHBsYW5lLT5mYiAod2hpY2ggd2Un cmUgZ29pbmcgdG8gZGVwcmVjYXRlIGZvciBhdG9taWMgZHJpdmVycykKPiA+IHdlIG5lZWQgdG8g bG9vayBhdCBwbGFuZS0+c3RhdGUtPmZiLiBUaGUgbWF6ZSBvZiBjb2RlIGxlYWRpbmcgdG8KPiA+ IHZtd19rbXNfaGVscGVyX2RpcnR5KCkgd2Fzbid0IHBhcnRpY3VsYXJseSBjbGVhciwgYnV0IG15 IGFuYWx5c2lzCj4gPiBjb25jbHVkZWQgdGhhdCB0aGUgY2FsbHMgb3JpZ2luYXRpbmcgZnJvbSB2 bXdfKl9wcmltYXJ5X3BsYW5lX2F0b21pY191cGRhdGUoKQo+ID4gYWxsIHBhc3MgaW4gdGhlIGNy dGMgd2hpY2ggbWVhbnMgd2UnbGwgbmV2ZXIgZW5kIHVwIGluIHRoaXMgYnJhbmNoCj4gPiBvZiB0 aGUgZnVuY3Rpb24uIEFsbCBvdGhlciBjYWxsZXJzIHVzZSBkcm1fbW9kZXNldF9sb2NrX2FsbCgp IHNvbWV3aGVyZQo+ID4gaGlnaGVyIHVwLCB3aGljaCBtZWFucyBhY2Nlc3NpbmcgcGxhbmUtPnN0 YXRlIGlzIHNhZmUuIFdlJ2xsIHRvc3MgaW4KPiA+IGEgbG9ja2RlcCBhc3NlcnQgdG8gY2F0Y2gg d3Jvbmdkb2Vycy4KPiA+IAo+ID4gdjI6IERyb3AgdGhlIGNvbW1lbnQgYW5kIG1ha2UgdGhlIGNv ZGUgZG8gd2hhdCBpdCBkaWQgYmVmb3JlIChUaG9tYXMpCj4gPiAKPiA+IENjOiBEZWVwYWsgUmF3 YXQgPGRyYXdhdEB2bXdhcmUuY29tPgo+ID4gQ2M6IFRob21hcyBIZWxsc3Ryb20gPHRoZWxsc3Ry b21Adm13YXJlLmNvbT4KPiA+IENjOiBTaW5jbGFpciBZZWggPHN5ZWhAdm13YXJlLmNvbT4KPiA+ IENjOiBWTXdhcmUgR3JhcGhpY3MgPGxpbnV4LWdyYXBoaWNzLW1haW50YWluZXJAdm13YXJlLmNv bT4KPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gU2ln bmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2ttcy5jIHwgOSAr KysrKystLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhf a21zLmMgYi9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9rbXMuYwo+ID4gaW5kZXggMmU0 YzM4YmI4NDZkLi41NDE3ZWIxYjQ4NmUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v dm13Z2Z4L3Ztd2dmeF9rbXMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdn Znhfa21zLmMKPiA+IEBAIC0yMzI2LDkgKzIzMjYsMTIgQEAgaW50IHZtd19rbXNfaGVscGVyX2Rp cnR5KHN0cnVjdCB2bXdfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgCX0gZWxzZSB7Cj4gPiAgCQls aXN0X2Zvcl9lYWNoX2VudHJ5KGNydGMsICZkZXZfcHJpdi0+ZGV2LT5tb2RlX2NvbmZpZy5jcnRj X2xpc3QsCj4gPiAgCQkJCSAgICBoZWFkKSB7Cj4gPiAtCQkJaWYgKGNydGMtPnByaW1hcnktPmZi ICE9ICZmcmFtZWJ1ZmZlci0+YmFzZSkKPiA+IC0JCQkJY29udGludWU7Cj4gPiAtCQkJdW5pdHNb bnVtX3VuaXRzKytdID0gdm13X2NydGNfdG9fZHUoY3J0Yyk7Cj4gPiArCQkJc3RydWN0IGRybV9w bGFuZSAqcGxhbmUgPSBjcnRjLT5wcmltYXJ5Owo+ID4gKwo+ID4gKwkJCWxvY2tkZXBfYXNzZXJ0 X2hlbGQoJnBsYW5lLT5tdXRleCk7Cj4gCj4ga2J1aWxkIHRlc3Qgcm9ib3QgdG9sZCBtZQo+ID4+ IGluY2x1ZGUvbGludXgvbG9ja2RlcC5oOjM0Nzo1MjogZXJyb3I6ICdzdHJ1Y3QgZHJtX21vZGVz ZXRfbG9jaycgaGFzCj4gPj4gbm8gbWVtYmVyIG5hbWVkICdkZXBfbWFwJyAgICAgICAgICAgICAg ICAgICAgICAKPiAgICAgI2RlZmluZSBsb2NrZGVwX2lzX2hlbGQobG9jaykgIGxvY2tfaXNfaGVs ZCgmKGxvY2spLT5kZXBfbWFwKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIAo+IAo+IE1heWJlIEknbGwganVzdCBkcm9wIHRoZSBhc3NlcnRzPyBP ciBkbyBwZW9wbGUgcmVhbGx5IHdhbnQgdGhlbQo+IChpbiB3aGljaCBjYXNlIEkgZ3VlcyBJIG5l ZWQgdG8gZGlnIG91dCB0aGUgdW5kZXJseWluZyBtdXRleCk/CgpFaXRoZXJ3YXkgaXMgZmluZSB3 aXRoIG1lLgoKCj4gCj4gPiArCj4gPiArCQkJaWYgKHBsYW5lLT5zdGF0ZS0+ZmIgPT0gJmZyYW1l YnVmZmVyLT5iYXNlKQo+ID4gKwkJCQl1bml0c1tudW1fdW5pdHMrK10gPSB2bXdfY3J0Y190b19k dShjcnRjKTsKPiA+ICAJCX0KPiA+ICAJfQo+ID4gIAo+ID4gLS0gCj4gPiAyLjE2LjEKPiAKPiAt LSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK