dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: gustavo@padovan.org, maarten.lankhorst@linux.intel.com,
	seanpaul@chromium.org, airlied@linux.ie, vincent.abriou@st.com
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: [PATCH v1 7/7] drm: sti: remove the last call to debugfs
Date: Tue,  5 Jun 2018 15:54:07 +0200	[thread overview]
Message-ID: <20180605135407.20214-8-benjamin.gaignard@linaro.org> (raw)
In-Reply-To: <20180605135407.20214-1-benjamin.gaignard@linaro.org>

Thanks to all the hooks in drm structure, custom debugfs could be
removed of sti driver.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
---
 drivers/gpu/drm/sti/sti_drv.c | 50 -------------------------------------------
 1 file changed, 50 deletions(-)

diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index 90c46b49c931..95b0ac4d819c 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -7,7 +7,6 @@
 #include <drm/drmP.h>
 
 #include <linux/component.h>
-#include <linux/debugfs.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/of_platform.h>
@@ -72,53 +71,6 @@ static int sti_drm_fps_set(void *data, u64 val)
 DEFINE_SIMPLE_ATTRIBUTE(sti_drm_fps_fops,
 			sti_drm_fps_get, sti_drm_fps_set, "%llu\n");
 
-static int sti_drm_fps_dbg_show(struct seq_file *s, void *data)
-{
-	struct drm_info_node *node = s->private;
-	struct drm_device *dev = node->minor->dev;
-	struct drm_plane *p;
-
-	list_for_each_entry(p, &dev->mode_config.plane_list, head) {
-		struct sti_plane *plane = to_sti_plane(p);
-
-		seq_printf(s, "%s%s\n",
-			   plane->fps_info.fps_str,
-			   plane->fps_info.fips_str);
-	}
-
-	return 0;
-}
-
-static struct drm_info_list sti_drm_dbg_list[] = {
-	{"fps_get", sti_drm_fps_dbg_show, 0},
-};
-
-static int sti_drm_dbg_init(struct drm_minor *minor)
-{
-	struct dentry *dentry;
-	int ret;
-
-	ret = drm_debugfs_create_files(sti_drm_dbg_list,
-				       ARRAY_SIZE(sti_drm_dbg_list),
-				       minor->debugfs_root, minor);
-	if (ret)
-		goto err;
-
-	dentry = debugfs_create_file("fps_show", S_IRUGO | S_IWUSR,
-				     minor->debugfs_root, minor->dev,
-				     &sti_drm_fps_fops);
-	if (!dentry) {
-		ret = -ENOMEM;
-		goto err;
-	}
-
-	DRM_INFO("%s: debugfs installed\n", DRIVER_NAME);
-	return 0;
-err:
-	DRM_ERROR("%s: cannot install debugfs\n", DRIVER_NAME);
-	return ret;
-}
-
 static const struct drm_mode_config_funcs sti_mode_config_funcs = {
 	.fb_create = drm_gem_fb_create,
 	.output_poll_changed = drm_fb_helper_output_poll_changed,
@@ -167,8 +119,6 @@ static struct drm_driver sti_driver = {
 	.gem_prime_vunmap = drm_gem_cma_prime_vunmap,
 	.gem_prime_mmap = drm_gem_cma_prime_mmap,
 
-	.debugfs_init = sti_drm_dbg_init,
-
 	.name = DRIVER_NAME,
 	.desc = DRIVER_DESC,
 	.date = DRIVER_DATE,
-- 
2.15.0

  parent reply	other threads:[~2018-06-05 13:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 13:54 [PATCH v1 0/7] Remove debugfs from sti display driver Benjamin Gaignard
2018-06-05 13:54 ` [PATCH v1 1/7] drm: print plane state normalized zpos value Benjamin Gaignard
2018-06-15 14:50   ` Philippe CORNU
2018-07-06  8:24   ` Benjamin Gaignard
2018-06-05 13:54 ` [PATCH v1 2/7] drm: add hook to print encoder status Benjamin Gaignard
2018-06-18 15:58   ` Philippe CORNU
2018-07-03  9:28   ` Daniel Vetter
2018-06-05 13:54 ` [PATCH v1 3/7] drm: sti: make planes use atomic_print_state instead of debugfs Benjamin Gaignard
2018-06-18 16:05   ` Philippe CORNU
2018-06-05 13:54 ` [PATCH v1 4/7] drm: sti: make connectors " Benjamin Gaignard
2018-06-18 16:07   ` Philippe CORNU
2018-06-05 13:54 ` [PATCH v1 5/7] drm: sti: make crtc " Benjamin Gaignard
2018-06-18 16:10   ` Philippe CORNU
2018-06-05 13:54 ` [PATCH v1 6/7] drm: sti: make encoders " Benjamin Gaignard
2018-06-18 16:11   ` Philippe CORNU
2018-06-05 13:54 ` Benjamin Gaignard [this message]
2018-06-18 16:12   ` [PATCH v1 7/7] drm: sti: remove the last call to debugfs Philippe CORNU
2018-06-29 13:25 ` [PATCH v1 0/7] Remove debugfs from sti display driver Benjamin Gaignard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180605135407.20214-8-benjamin.gaignard@linaro.org \
    --to=benjamin.gaignard@linaro.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@padovan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=seanpaul@chromium.org \
    --cc=vincent.abriou@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).