Re: [PATCH 0/3] drm/omapdrm: Replace {un/reference} with {put,get} functions

Thomas Zimmermann
2018-09-26T11:19:14Z

[-- Attachment #1.1.1: Type: text/plain, Size: 2092 bytes --]

OK, great. Thanks again for taking the patches.

Am 26.09.18 um 13:02 schrieb Tomi Valkeinen:
> On 26/09/18 13:50, Thomas Zimmermann wrote:
>> Hi
>>
>> Thanks. I rebased just today. Patch 3 is slightly out of date. Do you
>> want me to post an update?
>
> Yes, the third one conflicted. I fixed it as follows. If it looks
> the same as your rebased one, no need to resend:
>
>
> From 1ebbed291771d486aa25d42d024c9040c1254b3a Mon Sep 17 00:00:00 2001
> From: Thomas Zimmermann <tdz@users.sourceforge.net>
> Date: Mon, 18 Jun 2018 15:07:27 +0200
> Subject: [PATCH] drm/omap: Replace drm_dev_unref with drm_dev_put
>
> This patch unifies the naming of DRM functions for reference counting
> of struct drm_device. The resulting code is more aligned with the rest
> of the Linux kernel interfaces.
>
> Signed-off-by: Thomas Zimmermann <tdz@users.sourceforge.net>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index f14d02ca968c..5e67d58cbc28 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -614,7 +614,7 @@ static int omapdrm_init(struct omap_drm_private *priv, struct device *dev)
> omap_disconnect_pipelines(ddev);
> err_crtc_uninit:
> omap_crtc_pre_uninit(priv);
> - drm_dev_unref(ddev);
> + drm_dev_put(ddev);
> return ret;
> }
>
> @@ -643,7 +643,7 @@ static void omapdrm_cleanup(struct omap_drm_private *priv)
> omap_disconnect_pipelines(ddev);
> omap_crtc_pre_uninit(priv);
>
> - drm_dev_unref(ddev);
> + drm_dev_put(ddev);
> }
>
> static int pdev_probe(struct platform_device *pdev)
>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg
Tel: +49-911-74053-0; Fax: +49-911-7417755; https://www.suse.com/
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard,
Graham Norton, HRB 21284 (AG Nürnberg)

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]