From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] dma-buf: lock the reservation object during (un)map_dma_buf v2 Date: Mon, 25 Jun 2018 11:12:17 +0200 Message-ID: <20180625091217.GO2958@phenom.ffwll.local> References: <20180622141103.1787-1-christian.koenig@amd.com> <20180622141103.1787-3-christian.koenig@amd.com> <20180625082231.GM2958@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180625082231.GM2958@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKdW4gMjUsIDIwMTggYXQgMTA6MjI6MzFBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBGcmksIEp1biAyMiwgMjAxOCBhdCAwNDoxMTowMVBNICswMjAwLCBDaHJpc3Rp YW4gS8O2bmlnIHdyb3RlOgo+ID4gRmlyc3Qgc3RlcCB0b3dhcmRzIHVucGlubmVkIERNQSBidWYg b3BlcmF0aW9uLgo+ID4gCj4gPiBJJ3ZlIGNoZWNrZWQgdGhlIERSTSBkcml2ZXJzIHRvIHBvdGVu dGlhbCBsb2NraW5nIG9mIHRoZSByZXNlcnZhdGlvbgo+ID4gb2JqZWN0LCBidXQgZXNzZW50aWFs bHkgd2UgbmVlZCB0byBhdWRpdCBhbGwgaW1wbGVtZW50YXRpb25zIG9mIHRoZQo+ID4gZG1hX2J1 ZiBfb3BzIGZvciB0aGlzIHRvIHdvcmsuCj4gPiAKPiA+IHYyOiByZW9yZGVyZWQKPiA+IAo+ID4g U2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29t Pgo+IAo+IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNo PgoKT2sgSSBkaWQgcmV2aWV3IGRyaXZlcnMgYSBiaXQsIGJ1dCBhcHBhcmVudGx5IG5vdCB3ZWxs IGVub3VnaCBieSBmYXIuIGk5MTUKQ0kgaXMgdW5oYXBweToKCmh0dHBzOi8vaW50ZWwtZ2Z4LWNp LjAxLm9yZy90cmVlL2RybS10aXAvUGF0Y2h3b3JrXzk0MDAvZmktd2hsLXUvaWd0QGdlbV9tbWFw X2d0dEBiYXNpYy1zbWFsbC1iby10aWxlZHguaHRtbAoKU28geWVhaCBpbnNlcnRpbmcgdGhhdCBs b2NrIGluIHRoZXJlIGlzbid0IHRoZSBtb3N0IHRyaXZpYWwgdGhpbmcgOi0vCgpJIGtpbmRhIGFz c3VtZSB0aGF0IG90aGVyIGRyaXZlcnMgd2lsbCBoYXZlIHNpbWlsYXIgaXNzdWVzLCBlLmcuIG9t YXBkcm0ncwp1c2Ugb2YgZGV2LT5zdHJ1Y3RfbXV0ZXggYWxzbyB2ZXJ5IG11Y2ggbG9va3MgbGlr ZSBpdCdsbCByZXN1bHQgaW4gYSBuZXcKbG9ja2luZyBpbnZlcnNpb24uCi1EYW5pZWwKCj4gCj4g PiAtLS0KPiA+ICBkcml2ZXJzL2RtYS1idWYvZG1hLWJ1Zi5jIHwgOSArKysrKystLS0KPiA+ICBp bmNsdWRlL2xpbnV4L2RtYS1idWYuaCAgIHwgNCArKysrCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAx MCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9kbWEtYnVmL2RtYS1idWYuYyBiL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMKPiA+IGlu ZGV4IGRjOTRlNzZlMmUyYS4uNDlmMjNiNzkxZWI4IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9k bWEtYnVmL2RtYS1idWYuYwo+ID4gKysrIGIvZHJpdmVycy9kbWEtYnVmL2RtYS1idWYuYwo+ID4g QEAgLTY2NSw3ICs2NjUsOSBAQCBzdHJ1Y3Qgc2dfdGFibGUgKmRtYV9idWZfbWFwX2F0dGFjaG1l bnQoc3RydWN0IGRtYV9idWZfYXR0YWNobWVudCAqYXR0YWNoLAo+ID4gIAlpZiAoV0FSTl9PTigh YXR0YWNoIHx8ICFhdHRhY2gtPmRtYWJ1ZikpCj4gPiAgCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFM KTsKPiA+ICAKPiA+IC0Jc2dfdGFibGUgPSBhdHRhY2gtPmRtYWJ1Zi0+b3BzLT5tYXBfZG1hX2J1 ZihhdHRhY2gsIGRpcmVjdGlvbik7Cj4gPiArCXJlc2VydmF0aW9uX29iamVjdF9sb2NrKGF0dGFj aC0+ZG1hYnVmLT5yZXN2LCBOVUxMKTsKPiA+ICsJc2dfdGFibGUgPSBkbWFfYnVmX21hcF9hdHRh Y2htZW50X2xvY2tlZChhdHRhY2gsIGRpcmVjdGlvbik7Cj4gPiArCXJlc2VydmF0aW9uX29iamVj dF91bmxvY2soYXR0YWNoLT5kbWFidWYtPnJlc3YpOwo+ID4gIAlpZiAoIXNnX3RhYmxlKQo+ID4g IAkJc2dfdGFibGUgPSBFUlJfUFRSKC1FTk9NRU0pOwo+ID4gIAo+ID4gQEAgLTcxNSw4ICs3MTcs OSBAQCB2b2lkIGRtYV9idWZfdW5tYXBfYXR0YWNobWVudChzdHJ1Y3QgZG1hX2J1Zl9hdHRhY2ht ZW50ICphdHRhY2gsCj4gPiAgCWlmIChXQVJOX09OKCFhdHRhY2ggfHwgIWF0dGFjaC0+ZG1hYnVm IHx8ICFzZ190YWJsZSkpCj4gPiAgCQlyZXR1cm47Cj4gPiAgCj4gPiAtCWF0dGFjaC0+ZG1hYnVm LT5vcHMtPnVubWFwX2RtYV9idWYoYXR0YWNoLCBzZ190YWJsZSwKPiA+IC0JCQkJCQlkaXJlY3Rp b24pOwo+ID4gKwlyZXNlcnZhdGlvbl9vYmplY3RfbG9jayhhdHRhY2gtPmRtYWJ1Zi0+cmVzdiwg TlVMTCk7Cj4gPiArCWRtYV9idWZfdW5tYXBfYXR0YWNobWVudF9sb2NrZWQoYXR0YWNoLCBzZ190 YWJsZSwgZGlyZWN0aW9uKTsKPiA+ICsJcmVzZXJ2YXRpb25fb2JqZWN0X3VubG9jayhhdHRhY2gt PmRtYWJ1Zi0+cmVzdik7Cj4gPiAgfQo+ID4gIEVYUE9SVF9TWU1CT0xfR1BMKGRtYV9idWZfdW5t YXBfYXR0YWNobWVudCk7Cj4gPiAgCj4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9kbWEt YnVmLmggYi9pbmNsdWRlL2xpbnV4L2RtYS1idWYuaAo+ID4gaW5kZXggYTI1ZTc1NGFlMmY3Li4w MjQ2NThkMWYyMmUgMTAwNjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L2RtYS1idWYuaAo+ID4g KysrIGIvaW5jbHVkZS9saW51eC9kbWEtYnVmLmgKPiA+IEBAIC0xMTgsNiArMTE4LDggQEAgc3Ry dWN0IGRtYV9idWZfb3BzIHsKPiA+ICAJICogYW55IG90aGVyIGtpbmQgb2Ygc2hhcmluZyB0aGF0 IHRoZSBleHBvcnRlciBtaWdodCB3aXNoIHRvIG1ha2UKPiA+ICAJICogYXZhaWxhYmxlIHRvIGJ1 ZmZlci11c2Vycy4KPiA+ICAJICoKPiA+ICsJICogVGhpcyBpcyBjYWxsZWQgd2l0aCB0aGUgZG1h YnVmLT5yZXN2IG9iamVjdCBsb2NrZWQuCj4gPiArCSAqCj4gPiAgCSAqIFJldHVybnM6Cj4gPiAg CSAqCj4gPiAgCSAqIEEgJnNnX3RhYmxlIHNjYXR0ZXIgbGlzdCBvZiBvciB0aGUgYmFja2luZyBz dG9yYWdlIG9mIHRoZSBETUEgYnVmZmVyLAo+ID4gQEAgLTEzOCw2ICsxNDAsOCBAQCBzdHJ1Y3Qg ZG1hX2J1Zl9vcHMgewo+ID4gIAkgKiBJdCBzaG91bGQgYWxzbyB1bnBpbiB0aGUgYmFja2luZyBz dG9yYWdlIGlmIHRoaXMgaXMgdGhlIGxhc3QgbWFwcGluZwo+ID4gIAkgKiBvZiB0aGUgRE1BIGJ1 ZmZlciwgaXQgdGhlIGV4cG9ydGVyIHN1cHBvcnRzIGJhY2tpbmcgc3RvcmFnZQo+ID4gIAkgKiBt aWdyYXRpb24uCj4gPiArCSAqCj4gPiArCSAqIFRoaXMgaXMgY2FsbGVkIHdpdGggdGhlIGRtYWJ1 Zi0+cmVzdiBvYmplY3QgbG9ja2VkLgo+ID4gIAkgKi8KPiA+ICAJdm9pZCAoKnVubWFwX2RtYV9i dWYpKHN0cnVjdCBkbWFfYnVmX2F0dGFjaG1lbnQgKiwKPiA+ICAJCQkgICAgICBzdHJ1Y3Qgc2df dGFibGUgKiwKPiA+IC0tIAo+ID4gMi4xNC4xCj4gPiAKPiAKPiAtLSAKPiBEYW5pZWwgVmV0dGVy Cj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCj4gaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK