From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/8] drm/fb-helper: Eliminate the .best_encoder() usage Date: Wed, 27 Jun 2018 11:03:31 +0200 Message-ID: <20180627090331.GE13978@phenom.ffwll.local> References: <20180626174714.32012-1-ville.syrjala@linux.intel.com> <20180626174714.32012-2-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69BB56E464 for ; Wed, 27 Jun 2018 09:03:36 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id g12-v6so2620483edi.9 for ; Wed, 27 Jun 2018 02:03:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180626174714.32012-2-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville Syrjala Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMjYsIDIwMTggYXQgMDg6NDc6MDdQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IEluc3RlYWQgb2YgdXNpbmcgdGhlIC5iZXN0X2VuY29kZXIoKSBob29rIHRvIGZp Z3VyZSBvdXQgd2hldGhlciBhIGdpdmVuCj4gY29ubmVjdG9yK2NydGMgY29tYm8gd2lsbCB3b3Jr LCBsZXQncyBpbnN0ZWFkIGRvIHdoYXQgdXNlcnNwYWNlIGRvZXMgYW5kCj4ganVzdCBpdGVyYXRl IG92ZXIgYWxsIHRoZSBlbmNvZGVycyBmb3IgdGhlIGNvbm5lY3RvciwgYW5kIHRoZW4gY2hlY2sK PiBlYWNoIGNydGMgYWdhaW5zdCBlYWNoIGVuY29kZXIncyBwb3NzaWJsZV9jcnRjcyBiaXRtYXNr Lgo+IAo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVs LmNvbT4KPiBDYzogSGFycnkgV2VudGxhbmQgPGhhcnJ5LndlbnRsYW5kQGFtZC5jb20+Cj4gQ2M6 IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQWNrZWQtYnk6IERhbmll bCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gU3VnZ2VzdGVkLWJ5OiBEYW5pZWwg VmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9kcm1fZmJfaGVscGVyLmMgfCAzNiArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+IGluZGV4IGNhYjE0ZjI1MzM4NC4uNjFj MzljZDc1YTI3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gQEAgLTIzMjMsNiArMjMy MywyMyBAQCBzdGF0aWMgYm9vbCBkcm1fdGFyZ2V0X3ByZWZlcnJlZChzdHJ1Y3QgZHJtX2ZiX2hl bHBlciAqZmJfaGVscGVyLAo+ICAJcmV0dXJuIHRydWU7Cj4gIH0KPiAgCj4gK3N0YXRpYyBib29s IGNvbm5lY3Rvcl9jcnRjX29rKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gKwkJ CSAgICAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiArewo+ICsJaW50IGk7Cj4gKwo+ICsJZm9y IChpID0gMDsgaSA8IERSTV9DT05ORUNUT1JfTUFYX0VOQ09ERVI7IGkrKykgewo+ICsJCXN0cnVj dCBkcm1fZW5jb2RlciAqZW5jb2RlciA9Cj4gKwkJCWRybV9lbmNvZGVyX2ZpbmQoY29ubmVjdG9y LT5kZXYsIE5VTEwsCj4gKwkJCQkJIGNvbm5lY3Rvci0+ZW5jb2Rlcl9pZHNbaV0pOwo+ICsKClNo b3VsZG4ndCB3ZSBhbHNvIGNoZWNrIGZvciBlbmNvZGVyICE9IE5VTEwgaGVyZT8gSnVzdCBmb3Ig dGhlIGNhc2Ugd2hlcmUKYSBjb25uZWN0b3IgZG9lcyBub3Qgd29yayBvbiB0aGUgZ2l2ZW4gY3J0 Yywgd2hlcmUgd2UgZG8gZXhwZWN0IHRvCmFjdHVhbGx5IHJ1biBvZmYgdGhlIGVuZCBvZiB0aGUg dmFsaWQgZW50cmllcyBpbiB0aGUgYXJyYXkuCgpXaXRoIHRoYXQgZml4ZWQ6CgpSZXZpZXdlZC1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gKwkJaWYgKGVuY29k ZXItPnBvc3NpYmxlX2NydGNzICYgZHJtX2NydGNfbWFzayhjcnRjKSkKPiArCQkJcmV0dXJuIHRy dWU7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIGZhbHNlOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IGRy bV9waWNrX2NydGNzKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIsCj4gIAkJCSAgc3Ry dWN0IGRybV9mYl9oZWxwZXJfY3J0YyAqKmJlc3RfY3J0Y3MsCj4gIAkJCSAgc3RydWN0IGRybV9k aXNwbGF5X21vZGUgKiptb2RlcywKPiBAQCAtMjMzMSw3ICsyMzQ4LDYgQEAgc3RhdGljIGludCBk cm1fcGlja19jcnRjcyhzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyLAo+ICAJaW50IGMs IG87Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICAJY29uc3Qgc3RydWN0 IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNzICpjb25uZWN0b3JfZnVuY3M7Cj4gLQlzdHJ1Y3Qg ZHJtX2VuY29kZXIgKmVuY29kZXI7Cj4gIAlpbnQgbXlfc2NvcmUsIGJlc3Rfc2NvcmUsIHNjb3Jl Owo+ICAJc3RydWN0IGRybV9mYl9oZWxwZXJfY3J0YyAqKmNydGNzLCAqY3J0YzsKPiAgCXN0cnVj dCBkcm1fZmJfaGVscGVyX2Nvbm5lY3RvciAqZmJfaGVscGVyX2Nvbm47Cj4gQEAgLTIzNjIsMjAg KzIzNzgsNiBAQCBzdGF0aWMgaW50IGRybV9waWNrX2NydGNzKHN0cnVjdCBkcm1fZmJfaGVscGVy ICpmYl9oZWxwZXIsCj4gIAo+ICAJY29ubmVjdG9yX2Z1bmNzID0gY29ubmVjdG9yLT5oZWxwZXJf cHJpdmF0ZTsKPiAgCj4gLQkvKgo+IC0JICogSWYgdGhlIERSTSBkZXZpY2UgaW1wbGVtZW50cyBh dG9taWMgaG9va3MgYW5kIC0+YmVzdF9lbmNvZGVyKCkgaXMKPiAtCSAqIE5VTEwgd2UgZmFsbGJh Y2sgdG8gdGhlIGRlZmF1bHQgZHJtX2F0b21pY19oZWxwZXJfYmVzdF9lbmNvZGVyKCkKPiAtCSAq IGhlbHBlci4KPiAtCSAqLwo+IC0JaWYgKGRybV9kcnZfdXNlc19hdG9taWNfbW9kZXNldChmYl9o ZWxwZXItPmRldikgJiYKPiAtCSAgICAhY29ubmVjdG9yX2Z1bmNzLT5iZXN0X2VuY29kZXIpCj4g LQkJZW5jb2RlciA9IGRybV9hdG9taWNfaGVscGVyX2Jlc3RfZW5jb2Rlcihjb25uZWN0b3IpOwo+ IC0JZWxzZQo+IC0JCWVuY29kZXIgPSBjb25uZWN0b3JfZnVuY3MtPmJlc3RfZW5jb2Rlcihjb25u ZWN0b3IpOwo+IC0KPiAtCWlmICghZW5jb2RlcikKPiAtCQlnb3RvIG91dDsKPiAtCj4gIAkvKgo+ ICAJICogc2VsZWN0IGEgY3J0YyBmb3IgdGhpcyBjb25uZWN0b3IgYW5kIHRoZW4gYXR0ZW1wdCB0 byBjb25maWd1cmUKPiAgCSAqIHJlbWFpbmluZyBjb25uZWN0b3JzCj4gQEAgLTIzODMsNyArMjM4 NSw3IEBAIHN0YXRpYyBpbnQgZHJtX3BpY2tfY3J0Y3Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmZi X2hlbHBlciwKPiAgCWZvciAoYyA9IDA7IGMgPCBmYl9oZWxwZXItPmNydGNfY291bnQ7IGMrKykg ewo+ICAJCWNydGMgPSAmZmJfaGVscGVyLT5jcnRjX2luZm9bY107Cj4gIAo+IC0JCWlmICgoZW5j b2Rlci0+cG9zc2libGVfY3J0Y3MgJiAoMSA8PCBjKSkgPT0gMCkKPiArCQlpZiAoIWNvbm5lY3Rv cl9jcnRjX29rKGNvbm5lY3RvciwgY3J0Yy0+bW9kZV9zZXQuY3J0YykpCj4gIAkJCWNvbnRpbnVl Owo+ICAKPiAgCQlmb3IgKG8gPSAwOyBvIDwgbjsgbysrKQo+IEBAIC0yNDEwLDcgKzI0MTIsNyBA QCBzdGF0aWMgaW50IGRybV9waWNrX2NydGNzKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxw ZXIsCj4gIAkJCSAgICAgICBzaXplb2Yoc3RydWN0IGRybV9mYl9oZWxwZXJfY3J0YyAqKSk7Cj4g IAkJfQo+ICAJfQo+IC1vdXQ6Cj4gKwo+ICAJa2ZyZWUoY3J0Y3MpOwo+ICAJcmV0dXJuIGJlc3Rf c2NvcmU7Cj4gIH0KPiAtLSAKPiAyLjE2LjQKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJl IEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK