From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/3] drm: Introduce __setplane_atomic()
Date: Thu, 28 Jun 2018 19:05:10 +0200
Message-ID: <20180628170510.GX13978@phenom.ffwll.local>
References: <20180628135457.14647-1-ville.syrjala@linux.intel.com>
 <20180628135457.14647-2-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20180628135457.14647-2-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCBKdW4gMjgsIDIwMTggYXQgMDQ6NTQ6NTZQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3
cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu
Y29tPgo+IAo+IEFsbCB0aGUgcGxhbmUtPmZiL29sZF9mYi9jcnRjIGRhbmNlIG9mIF9fc2V0cGxh
bmVfaW50ZXJuYWwoKSBpcwo+IHBvaW50bGVzcyBvbiBhdG9taWMgZHJpdmVycy4gU28gbGV0J3Mg
anVzdCBpbnRyb2R1Y2UgYSBzaW1wbGVyCj4gdmVyc2lvbiB0aGF0IHNraXBzIGFsbCB0aGF0Lgo+
IAo+IElkZWFsbHkgd2UgY291bGQgYWxzbyBza2lwIHRoZSBfX3NldHBsYW5lX2NoZWNrKCkgYXMK
PiBkcm1fYXRvbWljX3BsYW5lX2NoZWNrKCkgYWxyZWFkeSBjaGVja3MgZm9yIGV2ZXJ5dGhpbmcs
IGJ1dCB0aGUKPiBsZWdhY3kgY3Vyc29yLyJhc3luYyIgLnVwZGF0ZV9wbGFuZSgpIHRyaWNrcyBi
eXBhc3MgdGhhdCBzbwo+IHdlIHN0aWxsIG5lZWQgdG8gY2FsbCBfX3NldHBsYW5lX2NoZWNrKCku
IFRvc3MgaW4gYSBGSVhNRSB0bwo+IHJlbWluZCBzb21lb25lIHRvIGNsZWFuIHRoaXMgdXAgbGF0
ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp
bnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jIHwgNjgg
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tCj4gIDEgZmlsZSBj
aGFuZ2VkLCA1NyBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFu
ZS5jCj4gaW5kZXggNWM5N2EwMTMxNDg0Li41ODcwMjM0MDgwOGMgMTAwNjQ0Cj4gLS0tIGEvZHJp
dmVycy9ncHUvZHJtL2RybV9wbGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFu
ZS5jCj4gQEAgLTY0OSw2ICs2NDksOCBAQCBzdGF0aWMgaW50IF9fc2V0cGxhbmVfaW50ZXJuYWwo
c3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIHsKPiAgCWludCByZXQgPSAwOwo+ICAKPiArCVdB
Uk5fT04ocGxhbmUtPnN0YXRlKTsKPiArCj4gIAkvKiBObyBmYiBtZWFucyBzaHV0IGl0IGRvd24g
Ki8KPiAgCWlmICghZmIpIHsKPiAgCQlwbGFuZS0+b2xkX2ZiID0gcGxhbmUtPmZiOwo+IEBAIC02
NzMsMTEgKzY3NSw5IEBAIHN0YXRpYyBpbnQgX19zZXRwbGFuZV9pbnRlcm5hbChzdHJ1Y3QgZHJt
X3BsYW5lICpwbGFuZSwKPiAgCQkJCQkgY3J0Y194LCBjcnRjX3ksIGNydGNfdywgY3J0Y19oLAo+
ICAJCQkJCSBzcmNfeCwgc3JjX3ksIHNyY193LCBzcmNfaCwgY3R4KTsKPiAgCWlmICghcmV0KSB7
Cj4gLQkJaWYgKCFwbGFuZS0+c3RhdGUpIHsKPiAtCQkJcGxhbmUtPmNydGMgPSBjcnRjOwo+IC0J
CQlwbGFuZS0+ZmIgPSBmYjsKPiAtCQkJZHJtX2ZyYW1lYnVmZmVyX2dldChwbGFuZS0+ZmIpOwo+
IC0JCX0KPiArCQlwbGFuZS0+Y3J0YyA9IGNydGM7Cj4gKwkJcGxhbmUtPmZiID0gZmI7Cj4gKwkJ
ZHJtX2ZyYW1lYnVmZmVyX2dldChwbGFuZS0+ZmIpOwo+ICAJfSBlbHNlIHsKPiAgCQlwbGFuZS0+
b2xkX2ZiID0gTlVMTDsKPiAgCX0KPiBAQCAtNjkwLDYgKzY5MCw0MSBAQCBzdGF0aWMgaW50IF9f
c2V0cGxhbmVfaW50ZXJuYWwoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAlyZXR1cm4gcmV0
Owo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IF9fc2V0cGxhbmVfYXRvbWljKHN0cnVjdCBkcm1fcGxh
bmUgKnBsYW5lLAo+ICsJCQkgICAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiArCQkJICAgICBz
dHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiArCQkJICAgICBpbnQzMl90IGNydGNfeCwgaW50
MzJfdCBjcnRjX3ksCj4gKwkJCSAgICAgdWludDMyX3QgY3J0Y193LCB1aW50MzJfdCBjcnRjX2gs
Cj4gKwkJCSAgICAgdWludDMyX3Qgc3JjX3gsIHVpbnQzMl90IHNyY195LAo+ICsJCQkgICAgIHVp
bnQzMl90IHNyY193LCB1aW50MzJfdCBzcmNfaCwKPiArCQkJICAgICBzdHJ1Y3QgZHJtX21vZGVz
ZXRfYWNxdWlyZV9jdHggKmN0eCkKPiArewo+ICsJaW50IHJldDsKPiArCj4gKwlXQVJOX09OKCFw
bGFuZS0+c3RhdGUpOwo+ICsKPiArCS8qIE5vIGZiIG1lYW5zIHNodXQgaXQgZG93biAqLwo+ICsJ
aWYgKCFmYikKPiArCQlyZXR1cm4gcGxhbmUtPmZ1bmNzLT5kaXNhYmxlX3BsYW5lKHBsYW5lLCBj
dHgpOwo+ICsKPiArCS8qCj4gKwkgKiBGSVhNRTogVGhpcyBpcyByZWR1bmRhbnQgd2l0aCBkcm1f
YXRvbWljX3BsYW5lX2NoZWNrKCksCj4gKwkgKiBidXQgdGhlIGxlZ2FjeSBjdXJzb3IvImFzeW5j
IiAudXBkYXRlX3BsYW5lKCkgdHJpY2tzCj4gKwkgKiBkb24ndCBjYWxsIHRoYXQgc28gd2Ugc3Rp
bGwgbmVlZCB0aGlzIGhlcmUuIFNob3VsZCByZW1vdmUKPiArCSAqIHRoaXMgd2hlbiBhbGwgLnVw
ZGF0ZV9wbGFuZSgpIGltcGxlbWVudGF0aW9ucyBoYXZlIGJlZW4KPiArCSAqIGZpeGVkIHRvIGNh
bGwgZHJtX2F0b21pY19wbGFuZV9jaGVjaygpLgo+ICsJICovCj4gKwlyZXQgPSBfX3NldHBsYW5l
X2NoZWNrKHBsYW5lLCBjcnRjLCBmYiwKPiArCQkJICAgICAgIGNydGNfeCwgY3J0Y195LCBjcnRj
X3csIGNydGNfaCwKPiArCQkJICAgICAgIHNyY194LCBzcmNfeSwgc3JjX3csIHNyY19oKTsKPiAr
CWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwlyZXR1cm4gcGxhbmUtPmZ1bmNzLT51
cGRhdGVfcGxhbmUocGxhbmUsIGNydGMsIGZiLAo+ICsJCQkJCSAgY3J0Y194LCBjcnRjX3ksIGNy
dGNfdywgY3J0Y19oLAo+ICsJCQkJCSAgc3JjX3gsIHNyY195LCBzcmNfdywgc3JjX2gsIGN0eCk7
Cj4gK30KPiArCj4gIHN0YXRpYyBpbnQgc2V0cGxhbmVfaW50ZXJuYWwoc3RydWN0IGRybV9wbGFu
ZSAqcGxhbmUsCj4gIAkJCSAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCQkgICAgIHN0
cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+IEBAIC03MDcsOSArNzQyLDE1IEBAIHN0YXRpYyBp
bnQgc2V0cGxhbmVfaW50ZXJuYWwoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAlyZXQgPSBk
cm1fbW9kZXNldF9sb2NrX2FsbF9jdHgocGxhbmUtPmRldiwgJmN0eCk7Cj4gIAlpZiAocmV0KQo+
ICAJCWdvdG8gZmFpbDsKPiAtCXJldCA9IF9fc2V0cGxhbmVfaW50ZXJuYWwocGxhbmUsIGNydGMs
IGZiLAo+IC0JCQkJICBjcnRjX3gsIGNydGNfeSwgY3J0Y193LCBjcnRjX2gsCj4gLQkJCQkgIHNy
Y194LCBzcmNfeSwgc3JjX3csIHNyY19oLCAmY3R4KTsKPiArCj4gKwlpZiAocGxhbmUtPnN0YXRl
KQoKV2UncmUgbm90IDEwMCUgY29uc2lzdGVudCwgYnV0IEkgdGhpbmsgdGhpcyBoZXJlIHdpbGwg
bWFrZSBsaWZlIGhhcmRlciBmb3IKZHJpdmVycyB0cmFuc2l0aW9uaW5nIHRvIGF0b21pYy4gTm90
IG1hbnkgbGVmdCwgYnV0IHN0aWxsIHNvbWUuCgpQbGVhc2UgdXNlIGRybV9kcnZfdXNlc19hdG9t
aWNfbW9kZXNldCgpIGluc3RlYWQgYW5kIGNoZWNrIGluc3RlYWQgZm9yCkRSSVZFUl9BVE9NSUMg
aW4geW91ciBXQVJOX09OIGluIGFsbCB0aGUgcGxhY2VzIHlvdSdyZSBjaGVja2luZyBmb3IKLT5z
dGF0ZSBpbiB0aGlzIHBhdGNoIGFuZCB0aGUgbmV4dCBvbmUuCgpXaXRoIHRoYXQgZml4ZWQsIG9u
IHRoZSBzZXJpZXM6CgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm
ZndsbC5jaD4KCj4gKwkJcmV0ID0gX19zZXRwbGFuZV9hdG9taWMocGxhbmUsIGNydGMsIGZiLAo+
ICsJCQkJCWNydGNfeCwgY3J0Y195LCBjcnRjX3csIGNydGNfaCwKPiArCQkJCQlzcmNfeCwgc3Jj
X3ksIHNyY193LCBzcmNfaCwgJmN0eCk7Cj4gKwllbHNlCj4gKwkJcmV0ID0gX19zZXRwbGFuZV9p
bnRlcm5hbChwbGFuZSwgY3J0YywgZmIsCj4gKwkJCQkJICBjcnRjX3gsIGNydGNfeSwgY3J0Y193
LCBjcnRjX2gsCj4gKwkJCQkJICBzcmNfeCwgc3JjX3ksIHNyY193LCBzcmNfaCwgJmN0eCk7Cj4g
IAo+ICBmYWlsOgo+ICAJaWYgKHJldCA9PSAtRURFQURMSykgewo+IEBAIC04NDEsOSArODgyLDE0
IEBAIHN0YXRpYyBpbnQgZHJtX21vZGVfY3Vyc29yX3VuaXZlcnNhbChzdHJ1Y3QgZHJtX2NydGMg
KmNydGMsCj4gIAkJc3JjX2ggPSBmYi0+aGVpZ2h0IDw8IDE2Owo+ICAJfQo+ICAKPiAtCXJldCA9
IF9fc2V0cGxhbmVfaW50ZXJuYWwocGxhbmUsIGNydGMsIGZiLAo+IC0JCQkJICBjcnRjX3gsIGNy
dGNfeSwgY3J0Y193LCBjcnRjX2gsCj4gLQkJCQkgIDAsIDAsIHNyY193LCBzcmNfaCwgY3R4KTsK
PiArCWlmIChwbGFuZS0+c3RhdGUpCj4gKwkJcmV0ID0gX19zZXRwbGFuZV9hdG9taWMocGxhbmUs
IGNydGMsIGZiLAo+ICsJCQkJCWNydGNfeCwgY3J0Y195LCBjcnRjX3csIGNydGNfaCwKPiArCQkJ
CQkwLCAwLCBzcmNfdywgc3JjX2gsIGN0eCk7Cj4gKwllbHNlCj4gKwkJcmV0ID0gX19zZXRwbGFu
ZV9pbnRlcm5hbChwbGFuZSwgY3J0YywgZmIsCj4gKwkJCQkJICBjcnRjX3gsIGNydGNfeSwgY3J0
Y193LCBjcnRjX2gsCj4gKwkJCQkJICAwLCAwLCBzcmNfdywgc3JjX2gsIGN0eCk7Cj4gIAo+ICAJ
aWYgKGZiKQo+ICAJCWRybV9mcmFtZWJ1ZmZlcl9wdXQoZmIpOwo+IC0tIAo+IDIuMTYuNAo+IAo+
IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRl
dmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw
czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0g
CkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6
Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w
Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs
LWdmeAo=