From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 4/8] drm/crtc: Add a generic infrastructure to fake VBLANK events
Date: Mon, 2 Jul 2018 10:46:43 +0200 [thread overview]
Message-ID: <20180702104643.45230f1b@bbrezillon> (raw)
In-Reply-To: <20180702084054.GK13978@phenom.ffwll.local>
On Mon, 2 Jul 2018 10:40:54 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> > >
> > > > + * Note that, even when no_blank is set to true, the CRTC driver can still
> > > > + * steal the &drm_crtc_state.event object and send the event on its own.
> > > > + * That's usually what happens when a job is queued to the writeback
> > > > + * connector.
> > >
> > > The last sentence is confusing imo. Just drop it?
> >
> > Yes, I know, but it's also important to state that the ->no_blank +
> > event == NULL is a valid combination, and just means that the driver
> > decided to generate the event (that happens when a new WB job is
> > queued).
>
> Then make it more explicit, as-is I had no idea what you meant exactly.
> What about
Your suggestion is missing :P.
> >
> > >
> > > Please use the inline comment style for struct members, and then also
> > > polish the formatting a bit (e.g. paragraph breaks, which are only
> > > possible with the inline style).
> >
> > I considered that, but the other fields were already documented in the
> > single block above the struct, so I thought keeping things consistent
> > was better. Should I just add this field doc inline and keep the other
> > ones where they are, or should I add a patch moving all docs inline?
>
> There's _lots_ of inline comments already, and all new ones should be
> inline. The only reason I haven't done the conversion to all of them is
> that it would be a nice opportunity to update/clean up the comments
> (often there's a lot more to say than what's captured in the single line),
> which is why it didn't happen yet. Just moving the comments without
> updating them seems less useful imo.
>
> I'd just do the inline comment for this, that's what everyone else is
> doing too.
Okay, will do.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-02 8:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 11:17 [PATCH v2 0/8] drm/vc4: Add support for the transposer IP Boris Brezillon
2018-06-29 11:17 ` [PATCH v2 1/8] drm/atomic: Avoid connector to writeback_connector casts Boris Brezillon
2018-07-02 7:49 ` Daniel Vetter
2018-06-29 11:17 ` [PATCH v2 2/8] drm/connector: Pass a drm_connector_state to ->atomic_commit() Boris Brezillon
2018-06-29 11:23 ` Liviu Dudau
2018-06-29 11:37 ` Liviu Dudau
2018-07-02 7:51 ` Daniel Vetter
2018-07-02 9:49 ` Boris Brezillon
2018-07-02 11:14 ` Liviu Dudau
2018-07-02 11:58 ` Boris Brezillon
2018-06-29 11:17 ` [PATCH v2 3/8] drm/vc4: Use wait_for_flip_done() instead of wait_for_vblanks() Boris Brezillon
2018-06-29 20:19 ` Eric Anholt
2018-06-29 11:17 ` [PATCH v2 4/8] drm/crtc: Add a generic infrastructure to fake VBLANK events Boris Brezillon
2018-06-29 11:38 ` Liviu Dudau
2018-07-02 8:02 ` Daniel Vetter
2018-07-02 8:14 ` Boris Brezillon
2018-07-02 8:37 ` Daniel Vetter
2018-07-02 9:01 ` Boris Brezillon
2018-07-02 8:40 ` Daniel Vetter
2018-07-02 8:46 ` Boris Brezillon [this message]
2018-06-29 11:17 ` [PATCH v2 5/8] drm/atomic: Call drm_atomic_helper_fake_vblank() from the generic commit_tail() helpers Boris Brezillon
2018-06-29 11:38 ` Liviu Dudau
2018-07-02 7:54 ` Daniel Vetter
2018-07-02 7:57 ` Daniel Vetter
2018-07-02 7:59 ` Boris Brezillon
2018-07-02 7:58 ` Boris Brezillon
2018-06-29 11:17 ` [PATCH v2 6/8] drm/vc4: Call drm_atomic_helper_fake_vblank() in the commit path Boris Brezillon
2018-06-29 20:27 ` Eric Anholt
2018-06-29 11:17 ` [PATCH v2 7/8] drm/vc4: Add support for the transposer block Boris Brezillon
2018-06-29 20:35 ` Eric Anholt
2018-07-02 10:19 ` Boris Brezillon
2018-06-29 11:17 ` [PATCH v2 8/8] ARM: dts: bcm283x: Add Transposer block Boris Brezillon
2018-06-29 20:27 ` Eric Anholt
2018-06-29 11:17 ` [PATCH v2 0/8] drm/vc4: Add support for the transposer IP Boris Brezillon
2018-06-29 11:40 ` Liviu Dudau
2018-07-02 10:21 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702104643.45230f1b@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox