dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Mahesh Kumar <mahesh1.kumar@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback
Date: Mon,  2 Jul 2018 16:37:22 +0530	[thread overview]
Message-ID: <20180702110729.8171-4-mahesh1.kumar@intel.com> (raw)
In-Reply-To: <20180702110729.8171-1-mahesh1.kumar@intel.com>

This patch implements "verify_crc_source" callback function for
rockchip drm driver.

Changes since V1:
 - simplify the verification (Jani N)

Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index effecbed2d11..77e91b15ddb4 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -1138,12 +1138,31 @@ static int vop_crtc_set_crc_source(struct drm_crtc *crtc,
 
 	return ret;
 }
+
+static int
+vop_crtc_verify_crc_source(struct drm_crtc *crtc, const char *source_name,
+			   size_t *values_cnt)
+{
+	if (source_name && strcmp(source_name, "auto") != 0)
+		return -EINVAL;
+
+	*values_cnt = 3;
+	return 0;
+}
+
 #else
 static int vop_crtc_set_crc_source(struct drm_crtc *crtc,
 				   const char *source_name, size_t *values_cnt)
 {
 	return -ENODEV;
 }
+
+static int
+vop_crtc_verify_crc_source(struct drm_crtc *crtc, const char *source_name,
+			   size_t *values_cnt)
+{
+	return -ENODEV;
+}
 #endif
 
 static const struct drm_crtc_funcs vop_crtc_funcs = {
@@ -1156,6 +1175,7 @@ static const struct drm_crtc_funcs vop_crtc_funcs = {
 	.enable_vblank = vop_crtc_enable_vblank,
 	.disable_vblank = vop_crtc_disable_vblank,
 	.set_crc_source = vop_crtc_set_crc_source,
+	.verify_crc_source = vop_crtc_verify_crc_source,
 };
 
 static void vop_fb_unref_worker(struct drm_flip_work *work, void *val)
-- 
2.16.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-07-02 11:07 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 11:07 [PATCH 00/10] Improve crc-core driver interface Mahesh Kumar
2018-07-02 11:07 ` [PATCH 01/10] drm: crc: Introduce verify_crc_source callback Mahesh Kumar
2018-07-10 11:26   ` Laurent Pinchart
2018-07-10 11:54     ` Kumar, Mahesh
2018-07-10 12:10       ` Laurent Pinchart
2018-07-10 12:12         ` Kumar, Mahesh
2018-07-02 11:07 ` [PATCH 02/10] drm: crc: Introduce get_crc_sources callback Mahesh Kumar
2018-07-10 11:22   ` Laurent Pinchart
2018-07-10 12:01     ` Kumar, Mahesh
2018-07-10 12:09       ` Laurent Pinchart
2018-07-10 12:11         ` Kumar, Mahesh
2018-07-02 11:07 ` Mahesh Kumar [this message]
2018-07-03 10:16   ` [PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback Maarten Lankhorst
2018-07-03 10:46     ` Heiko Stübner
2018-07-02 11:07 ` [PATCH 04/10] drm/amdgpu_dm/crc: " Mahesh Kumar
2018-07-03 10:19   ` Maarten Lankhorst
2018-07-03 13:04     ` Leo Li
2018-07-02 11:07 ` [PATCH 05/10] drm/rcar-du/crc: " Mahesh Kumar
2018-07-03 10:20   ` Maarten Lankhorst
2018-07-10 11:37   ` Laurent Pinchart
2018-07-10 12:59     ` Kumar, Mahesh
2018-07-11 10:45       ` Laurent Pinchart
2018-07-02 11:07 ` [PATCH 06/10] drm/i915/crc: implement " Mahesh Kumar
2018-07-02 12:18   ` Maarten Lankhorst
2018-07-02 11:07 ` [PATCH 07/10] drm/i915/crc: implement get_crc_sources callback Mahesh Kumar
2018-07-02 11:07 ` [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function Mahesh Kumar
2018-07-03 13:05   ` Leo Li
2018-07-10 11:49   ` Laurent Pinchart
2018-07-10 13:18     ` Kumar, Mahesh
2018-07-02 11:07 ` [PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()" Mahesh Kumar
2018-07-10 12:02   ` Laurent Pinchart
2018-07-02 11:07 ` [PATCH 10/10] drm: crc: Introduce pre_crc_read function Mahesh Kumar
2018-07-10 12:05   ` Laurent Pinchart
2018-07-02 16:15 ` [PATCH 00/10] Improve crc-core driver interface Alex Deucher
     [not found] <20180711151145.21010-1-mahesh1.kumar@intel.com>
2018-07-11 15:11 ` [PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback Mahesh Kumar
  -- strict thread matches above, loose matches on Subject: below --
2018-07-12  8:36 [PATCH 00/10] Improve crc-core driver interface Mahesh Kumar
2018-07-12  8:36 ` [PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback Mahesh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180702110729.8171-4-mahesh1.kumar@intel.com \
    --to=mahesh1.kumar@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).