From: Boris Brezillon <boris.brezillon@bootlin.com>
To: kbuild test robot <lkp@intel.com>
Cc: David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
dri-devel@lists.freedesktop.org, kbuild-all@01.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3 3/9] drm/connector: Make ->atomic_commit() optional
Date: Mon, 2 Jul 2018 18:41:44 +0200 [thread overview]
Message-ID: <20180702184144.57c7fe37@bbrezillon> (raw)
In-Reply-To: <201807022259.ppuuJiwK%fengguang.wu@intel.com>
On Mon, 2 Jul 2018 23:30:05 +0800
kbuild test robot <lkp@intel.com> wrote:
> Hi Boris,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on next-20180702]
> [cannot apply to drm/drm-next anholt/for-next robh/for-next v4.18-rc3 v4.18-rc2 v4.18-rc1 v4.18-rc3]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-vc4-Add-support-for-the-transposer-IP/20180702-211805
> config: x86_64-randconfig-x015-201826 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> drivers/gpu//drm/drm_atomic_helper.c: In function 'drm_atomic_helper_commit_writebacks':
> >> drivers/gpu//drm/drm_atomic_helper.c:1187:13: error: 'const struct drm_connector_helper_funcs' has no member named 'funcs'
> if (!funcs->funcs->atomic_commit)
> ^~
>
> vim +1187 drivers/gpu//drm/drm_atomic_helper.c
>
> 1175
> 1176 static void drm_atomic_helper_commit_writebacks(struct drm_device *dev,
> 1177 struct drm_atomic_state *old_state)
> 1178 {
> 1179 struct drm_connector *connector;
> 1180 struct drm_connector_state *new_conn_state;
> 1181 int i;
> 1182
> 1183 for_each_new_connector_in_state(old_state, connector, new_conn_state, i) {
> 1184 const struct drm_connector_helper_funcs *funcs;
> 1185
> 1186 funcs = connector->helper_private;
> > 1187 if (!funcs->funcs->atomic_commit)
Oh, shame on me! :-)
I'll send a v4 with this build failure fixed, and this time I'll
compile-test at least. :-)
> 1188 continue;
> 1189
> 1190 if (new_conn_state->writeback_job && new_conn_state->writeback_job->fb) {
> 1191 WARN_ON(connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK);
> 1192 funcs->atomic_commit(connector, new_conn_state);
> 1193 }
> 1194 }
> 1195 }
> 1196
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-02 16:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 12:20 [PATCH v3 0/9] drm/vc4: Add support for the transposer IP Boris Brezillon
2018-07-02 12:20 ` [PATCH v3 1/9] drm/atomic: Avoid connector to writeback_connector casts Boris Brezillon
2018-07-02 12:20 ` [PATCH v3 2/9] drm/connector: Pass a drm_connector_state to ->atomic_commit() Boris Brezillon
2018-07-02 12:20 ` [PATCH v3 3/9] drm/connector: Make ->atomic_commit() optional Boris Brezillon
2018-07-02 12:56 ` Liviu Dudau
2018-07-02 15:30 ` kbuild test robot
2018-07-02 15:30 ` kbuild test robot
2018-07-02 16:41 ` Boris Brezillon [this message]
2018-07-02 12:20 ` [PATCH v3 4/9] drm/vc4: Use wait_for_flip_done() instead of wait_for_vblanks() Boris Brezillon
2018-07-02 12:20 ` [PATCH v3 5/9] drm/crtc: Add a generic infrastructure to fake VBLANK events Boris Brezillon
2018-07-02 12:20 ` [PATCH v3 6/9] drm/atomic: Call fake_vblank() from the generic commit_tail() helpers Boris Brezillon
2018-07-02 12:20 ` [PATCH v3 7/9] drm/vc4: Call drm_atomic_helper_fake_vblank() in the commit path Boris Brezillon
2018-07-02 12:20 ` [PATCH v3 8/9] drm/vc4: Add support for the transposer block Boris Brezillon
2018-07-02 18:52 ` Eric Anholt
2018-07-02 19:10 ` Boris Brezillon
2018-07-02 12:20 ` [PATCH v3 9/9] ARM: dts: bcm283x: Add Transposer block Boris Brezillon
2018-07-02 19:51 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702184144.57c7fe37@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbuild-all@01.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox