dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
	"hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm: Fix hdmi connector content type property docs
Date: Tue, 3 Jul 2018 08:58:50 +0200	[thread overview]
Message-ID: <20180703065850.GA7880@phenom.ffwll.local> (raw)
In-Reply-To: <919ef9752c077d943808891aa42d1aadce38d5fc.camel@intel.com>

On Mon, Jul 02, 2018 at 10:03:51AM +0000, Lisovskiy, Stanislav wrote:
> On Mon, 2018-07-02 at 11:10 +0200, Daniel Vetter wrote:
> > Apparently didn't get carefully checked.
> > 
> > Fixes: 50525c332b55 ("drm: content-type property for HDMI connector")
> > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> >  Documentation/gpu/drm-kms.rst   | 2 +-
> >  drivers/gpu/drm/drm_connector.c | 4 +---
> >  2 files changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-
> > kms.rst
> > index 4f6f113a7f5d..514939433004 100644
> > --- a/Documentation/gpu/drm-kms.rst
> > +++ b/Documentation/gpu/drm-kms.rst
> > @@ -527,7 +527,7 @@ Standard Connector Properties
> >     :doc: standard connector properties
> >  
> >  HDMI Specific Connector Properties
> > ------------------------------
> > +----------------------------------
> >  
> >  .. kernel-doc:: drivers/gpu/drm/drm_connector.c
> >     :doc: HDMI connector properties
> > diff --git a/drivers/gpu/drm/drm_connector.c
> > b/drivers/gpu/drm/drm_connector.c
> > index 2f9ebddd178e..b09b3a3e4024 100644
> > --- a/drivers/gpu/drm/drm_connector.c
> > +++ b/drivers/gpu/drm/drm_connector.c
> > @@ -1033,9 +1033,7 @@
> > EXPORT_SYMBOL(drm_mode_create_dvi_i_properties);
> >   *
> >   *	Drivers can set up this property by calling
> >   *	drm_connector_attach_content_type_property(). Decoding to
> > - *	infoframe values is done through
> > - *	drm_hdmi_get_content_type_from_property() and
> > - *	drm_hdmi_get_itc_bit_from_property().
> > + *	infoframe values is done through
> > drm_hdmi_avi_infoframe_content_type().
> >   */
> 
> All right, thank you very much for spotting, there were so much
> last
> minute changes that I probably got confused.

Yeah figured as much, nw.

> Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

Thanks for your review, applied to drm-misc-next.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2018-07-03  6:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02  9:10 [PATCH] drm: Fix hdmi connector content type property docs Daniel Vetter
2018-07-02 10:03 ` Lisovskiy, Stanislav
2018-07-03  6:58   ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703065850.GA7880@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hans.verkuil@cisco.com \
    --cc=stanislav.lisovskiy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox