From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] dma-buf: lock the reservation object during (un)map_dma_buf v2 Date: Tue, 3 Jul 2018 14:52:35 +0200 Message-ID: <20180703125235.GB3891@phenom.ffwll.local> References: <20180622141103.1787-1-christian.koenig@amd.com> <20180622141103.1787-3-christian.koenig@amd.com> <20180625082231.GM2958@phenom.ffwll.local> <20180625091217.GO2958@phenom.ffwll.local> <2ebff18b-414d-c971-1b7f-f6a21aacf196@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <2ebff18b-414d-c971-1b7f-f6a21aacf196@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: christian.koenig@amd.com Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdWwgMDMsIDIwMTggYXQgMDE6NDY6NDRQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBbSAyNS4wNi4yMDE4IHVtIDExOjEyIHNjaHJpZWIgRGFuaWVsIFZldHRlcjoK PiA+IE9uIE1vbiwgSnVuIDI1LCAyMDE4IGF0IDEwOjIyOjMxQU0gKzAyMDAsIERhbmllbCBWZXR0 ZXIgd3JvdGU6Cj4gPiA+IE9uIEZyaSwgSnVuIDIyLCAyMDE4IGF0IDA0OjExOjAxUE0gKzAyMDAs IENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6Cj4gPiA+ID4gRmlyc3Qgc3RlcCB0b3dhcmRzIHVucGlu bmVkIERNQSBidWYgb3BlcmF0aW9uLgo+ID4gPiA+IAo+ID4gPiA+IEkndmUgY2hlY2tlZCB0aGUg RFJNIGRyaXZlcnMgdG8gcG90ZW50aWFsIGxvY2tpbmcgb2YgdGhlIHJlc2VydmF0aW9uCj4gPiA+ ID4gb2JqZWN0LCBidXQgZXNzZW50aWFsbHkgd2UgbmVlZCB0byBhdWRpdCBhbGwgaW1wbGVtZW50 YXRpb25zIG9mIHRoZQo+ID4gPiA+IGRtYV9idWYgX29wcyBmb3IgdGhpcyB0byB3b3JrLgo+ID4g PiA+IAo+ID4gPiA+IHYyOiByZW9yZGVyZWQKPiA+ID4gPiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gPiA+IFJldmll d2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gT2sgSSBk aWQgcmV2aWV3IGRyaXZlcnMgYSBiaXQsIGJ1dCBhcHBhcmVudGx5IG5vdCB3ZWxsIGVub3VnaCBi eSBmYXIuIGk5MTUKPiA+IENJIGlzIHVuaGFwcHk6Cj4gPiAKPiA+IGh0dHBzOi8vaW50ZWwtZ2Z4 LWNpLjAxLm9yZy90cmVlL2RybS10aXAvUGF0Y2h3b3JrXzk0MDAvZmktd2hsLXUvaWd0QGdlbV9t bWFwX2d0dEBiYXNpYy1zbWFsbC1iby10aWxlZHguaHRtbAo+ID4gCj4gPiBTbyB5ZWFoIGluc2Vy dGluZyB0aGF0IGxvY2sgaW4gdGhlcmUgaXNuJ3QgdGhlIG1vc3QgdHJpdmlhbCB0aGluZyA6LS8K PiA+IAo+ID4gSSBraW5kYSBhc3N1bWUgdGhhdCBvdGhlciBkcml2ZXJzIHdpbGwgaGF2ZSBzaW1p bGFyIGlzc3VlcywgZS5nLiBvbWFwZHJtJ3MKPiA+IHVzZSBvZiBkZXYtPnN0cnVjdF9tdXRleCBh bHNvIHZlcnkgbXVjaCBsb29rcyBsaWtlIGl0J2xsIHJlc3VsdCBpbiBhIG5ldwo+ID4gbG9ja2lu ZyBpbnZlcnNpb24uCj4gCj4gQWgsIGNyYXAuIEFscmVhZHkgZmVhcmVkIHRoYXQgdGhpcyB3b3Vs ZG4ndCBiZSBlYXN5LCBidXQgeWVhaCB0aGF0IGl0IGlzIGFzCj4gYmFkIGFzIHRoaXMgaXMgcmF0 aGVyIGRpc2FwcG9pbnRpbmcuCj4gCj4gVGhhbmtzIGZvciB0aGUgaW5mbywgZ29pbmcgdG8ga2Vl cCB0aGlua2luZyBhYm91dCBob3cgdG8gc29sdmUgdGhvc2UgaXNzdWVzLgoKU2lkZSBub3RlOiBX ZSB3YW50IHRvIG1ha2Ugc3VyZSB0aGF0IGRyaXZlcnMgZG9uJ3QgZ2V0IHRoZSByZXNlcnZhdGlv bl9vYmoKbG9ja2luZyBoaWVyYXJjaHkgd3JvbmcgaW4gb3RoZXIgcGxhY2VzICh1c2luZyBkZXYt PnN0cnVjdF9tdXRleCBpcyBraW5kYQphIHByZS1leGlzdGluZyBtaXMtdXNlIHRoYXQgd2UgY2Fu J3Qgd2lzaCBhd2F5IHJldHJvYWN0aXZlbHkKdW5mb3J0dW5hdGVseSkuIE9uZSByZWFsbHkgaW1w b3J0YW50IHRoaW5nIGlzIHRoYXQgc2hyaW5rZXIgdnMgcmVzdl9vYmoKbXVzdCB3b3JrIHdpdGgg dHJ5bG9ja3MgaW4gdGhlIHNocmlua2VyLCBzbyB0aGF0IHlvdSBjYW4gYWxsb2NhdGUgbWVtb3J5 CndoaWxlIGhvbGRpbmcgcmVzZXJ2YXRpb24gb2JqZWN0cy4KCk9uZSBuZWF0IHRyaWNrIHRvIHRl YWNoIGxvY2tkZXAgYWJvdXQgdGhpcyB3b3VsZCBiZSB0byBoYXZlIGEgZHVtbXkKCmlmIChJU19F TkFCTEVEKENPTkZJR19QUk9WRV9MT0NLSU5HKSkgewoJd3dfbXV0ZXhfbG9jayhkbWFfYnVmLT5y ZXN2X29iaik7Cglmc19yZWNsYWltX2FjcXVpcmUoR0ZQX0tFUk5FTCk7Cglmc19yZWNsYWltX3Jl bGVhc2UoR0ZQX0tFUk5FTCk7Cgl3d19tdXRleF91bmxvY2soZG1hX2J1Zi0+cmVzdl9vYmopOwp9 CgppbiBkbWFfYnVmX2luaXQoKS4gV2UncmUgdXNpbmcgdGhlIGZzX3JlY2xhaW1fYWNxdWlyZS9y ZWxlYXNlIGNoZWNrIHZlcnkKc3VjY2Vzc2Z1bGx5IHRvIGltcHJvdmUgb3VyIGlndCB0ZXN0IGNv dmVyYWdlIGZvciBpOTE1LmtvIGluIG90aGVyIGFyZWFzLgoKVG90YWxseSB1bnJlbGF0ZWQgdG8g ZGV2LT5zdHJ1Y3RfbXV0ZXgsIGJ1dCB0aG91Z2h0cz8gV2VsbCBmb3IKZGV2LT5zdHJ1Y3RfbXV0 ZXggd2UgY291bGQgYXQgbGVhc3QgZGVjaWRlIG9uIG9uZSB0cnVlIHdheSB0byBuZXN0CnJlc3Zf b2JqIHZzLiBkZXYtPnN0cnVjdF9tdXRleCBhcyBtYXliZSBhbiBpbnRlcmltIHN0ZXAsIGJ1dCBu b3Qgc3VyZSBob3cKbXVjaCB0aGF0IHdvdWxkIGhlbHAuCi1EYW5pZWwKCj4gCj4gQ2hyaXN0aWFu Lgo+IAo+ID4gLURhbmllbAo+ID4gCj4gPiA+ID4gLS0tCj4gPiA+ID4gICBkcml2ZXJzL2RtYS1i dWYvZG1hLWJ1Zi5jIHwgOSArKysrKystLS0KPiA+ID4gPiAgIGluY2x1ZGUvbGludXgvZG1hLWJ1 Zi5oICAgfCA0ICsrKysKPiA+ID4gPiAgIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygr KSwgMyBkZWxldGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9k bWEtYnVmL2RtYS1idWYuYyBiL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMKPiA+ID4gPiBpbmRl eCBkYzk0ZTc2ZTJlMmEuLjQ5ZjIzYjc5MWViOCAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJz L2RtYS1idWYvZG1hLWJ1Zi5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9kbWEtYnVmL2RtYS1idWYu Ywo+ID4gPiA+IEBAIC02NjUsNyArNjY1LDkgQEAgc3RydWN0IHNnX3RhYmxlICpkbWFfYnVmX21h cF9hdHRhY2htZW50KHN0cnVjdCBkbWFfYnVmX2F0dGFjaG1lbnQgKmF0dGFjaCwKPiA+ID4gPiAg IAlpZiAoV0FSTl9PTighYXR0YWNoIHx8ICFhdHRhY2gtPmRtYWJ1ZikpCj4gPiA+ID4gICAJCXJl dHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ID4gPiA+IC0Jc2dfdGFibGUgPSBhdHRhY2gtPmRtYWJ1 Zi0+b3BzLT5tYXBfZG1hX2J1ZihhdHRhY2gsIGRpcmVjdGlvbik7Cj4gPiA+ID4gKwlyZXNlcnZh dGlvbl9vYmplY3RfbG9jayhhdHRhY2gtPmRtYWJ1Zi0+cmVzdiwgTlVMTCk7Cj4gPiA+ID4gKwlz Z190YWJsZSA9IGRtYV9idWZfbWFwX2F0dGFjaG1lbnRfbG9ja2VkKGF0dGFjaCwgZGlyZWN0aW9u KTsKPiA+ID4gPiArCXJlc2VydmF0aW9uX29iamVjdF91bmxvY2soYXR0YWNoLT5kbWFidWYtPnJl c3YpOwo+ID4gPiA+ICAgCWlmICghc2dfdGFibGUpCj4gPiA+ID4gICAJCXNnX3RhYmxlID0gRVJS X1BUUigtRU5PTUVNKTsKPiA+ID4gPiBAQCAtNzE1LDggKzcxNyw5IEBAIHZvaWQgZG1hX2J1Zl91 bm1hcF9hdHRhY2htZW50KHN0cnVjdCBkbWFfYnVmX2F0dGFjaG1lbnQgKmF0dGFjaCwKPiA+ID4g PiAgIAlpZiAoV0FSTl9PTighYXR0YWNoIHx8ICFhdHRhY2gtPmRtYWJ1ZiB8fCAhc2dfdGFibGUp KQo+ID4gPiA+ICAgCQlyZXR1cm47Cj4gPiA+ID4gLQlhdHRhY2gtPmRtYWJ1Zi0+b3BzLT51bm1h cF9kbWFfYnVmKGF0dGFjaCwgc2dfdGFibGUsCj4gPiA+ID4gLQkJCQkJCWRpcmVjdGlvbik7Cj4g PiA+ID4gKwlyZXNlcnZhdGlvbl9vYmplY3RfbG9jayhhdHRhY2gtPmRtYWJ1Zi0+cmVzdiwgTlVM TCk7Cj4gPiA+ID4gKwlkbWFfYnVmX3VubWFwX2F0dGFjaG1lbnRfbG9ja2VkKGF0dGFjaCwgc2df dGFibGUsIGRpcmVjdGlvbik7Cj4gPiA+ID4gKwlyZXNlcnZhdGlvbl9vYmplY3RfdW5sb2NrKGF0 dGFjaC0+ZG1hYnVmLT5yZXN2KTsKPiA+ID4gPiAgIH0KPiA+ID4gPiAgIEVYUE9SVF9TWU1CT0xf R1BMKGRtYV9idWZfdW5tYXBfYXR0YWNobWVudCk7Cj4gPiA+ID4gZGlmZiAtLWdpdCBhL2luY2x1 ZGUvbGludXgvZG1hLWJ1Zi5oIGIvaW5jbHVkZS9saW51eC9kbWEtYnVmLmgKPiA+ID4gPiBpbmRl eCBhMjVlNzU0YWUyZjcuLjAyNDY1OGQxZjIyZSAxMDA2NDQKPiA+ID4gPiAtLS0gYS9pbmNsdWRl L2xpbnV4L2RtYS1idWYuaAo+ID4gPiA+ICsrKyBiL2luY2x1ZGUvbGludXgvZG1hLWJ1Zi5oCj4g PiA+ID4gQEAgLTExOCw2ICsxMTgsOCBAQCBzdHJ1Y3QgZG1hX2J1Zl9vcHMgewo+ID4gPiA+ICAg CSAqIGFueSBvdGhlciBraW5kIG9mIHNoYXJpbmcgdGhhdCB0aGUgZXhwb3J0ZXIgbWlnaHQgd2lz aCB0byBtYWtlCj4gPiA+ID4gICAJICogYXZhaWxhYmxlIHRvIGJ1ZmZlci11c2Vycy4KPiA+ID4g PiAgIAkgKgo+ID4gPiA+ICsJICogVGhpcyBpcyBjYWxsZWQgd2l0aCB0aGUgZG1hYnVmLT5yZXN2 IG9iamVjdCBsb2NrZWQuCj4gPiA+ID4gKwkgKgo+ID4gPiA+ICAgCSAqIFJldHVybnM6Cj4gPiA+ ID4gICAJICoKPiA+ID4gPiAgIAkgKiBBICZzZ190YWJsZSBzY2F0dGVyIGxpc3Qgb2Ygb3IgdGhl IGJhY2tpbmcgc3RvcmFnZSBvZiB0aGUgRE1BIGJ1ZmZlciwKPiA+ID4gPiBAQCAtMTM4LDYgKzE0 MCw4IEBAIHN0cnVjdCBkbWFfYnVmX29wcyB7Cj4gPiA+ID4gICAJICogSXQgc2hvdWxkIGFsc28g dW5waW4gdGhlIGJhY2tpbmcgc3RvcmFnZSBpZiB0aGlzIGlzIHRoZSBsYXN0IG1hcHBpbmcKPiA+ ID4gPiAgIAkgKiBvZiB0aGUgRE1BIGJ1ZmZlciwgaXQgdGhlIGV4cG9ydGVyIHN1cHBvcnRzIGJh Y2tpbmcgc3RvcmFnZQo+ID4gPiA+ICAgCSAqIG1pZ3JhdGlvbi4KPiA+ID4gPiArCSAqCj4gPiA+ ID4gKwkgKiBUaGlzIGlzIGNhbGxlZCB3aXRoIHRoZSBkbWFidWYtPnJlc3Ygb2JqZWN0IGxvY2tl ZC4KPiA+ID4gPiAgIAkgKi8KPiA+ID4gPiAgIAl2b2lkICgqdW5tYXBfZG1hX2J1Zikoc3RydWN0 IGRtYV9idWZfYXR0YWNobWVudCAqLAo+ID4gPiA+ICAgCQkJICAgICAgc3RydWN0IHNnX3RhYmxl ICosCj4gPiA+ID4gLS0gCj4gPiA+ID4gMi4xNC4xCj4gPiA+ID4gCj4gPiA+IC0tIAo+ID4gPiBE YW5pZWwgVmV0dGVyCj4gPiA+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+ ID4gPiBodHRwOi8vYmxvZy5mZndsbC5jaAo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUg RW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=