From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks Date: Tue, 10 Jul 2018 10:04:20 +0200 Message-ID: <20180710080420.GI3008@phenom.ffwll.local> References: <3c62d375dc439268e9ea77fb8f3d599ee927a2a6.1531149873.git.hamohammed.sa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45DA36E828 for ; Tue, 10 Jul 2018 08:04:24 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id x5-v6so12211646edr.0 for ; Tue, 10 Jul 2018 01:04:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <3c62d375dc439268e9ea77fb8f3d599ee927a2a6.1531149873.git.hamohammed.sa@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Haneen Mohammed Cc: rodrigosiqueiramelo@gmail.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKdWwgMDksIDIwMTggYXQgMDY6NDY6NDlQTSArMDMwMCwgSGFuZWVuIE1vaGFtbWVk IHdyb3RlOgo+IFRoaXMgcGF0Y2ggbWFwL3VubWFwIEdFTSBiYWNraW5nIG1lbW9yeSB0byBrZXJu ZWwgYWRkcmVzcyBzcGFjZQo+IGluIHByZXBhcmUvY2xlYW51cF9mYiByZXNwZWN0aXZlbHkgYW5k IGNhY2hlIHRoZSB2aXJ0dWFsIGFkZHJlc3MKPiBmb3IgbGF0ZXIgdXNlLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IEhhbmVlbiBNb2hhbW1lZCA8aGFtb2hhbW1lZC5zYUBnbWFpbC5jb20+Cj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfcGxhbmUuYyB8IDQxICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKykKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19wbGFuZS5jIGIvZHJpdmVycy9n cHUvZHJtL3ZrbXMvdmttc19wbGFuZS5jCj4gaW5kZXggZjdmNjMxNDNmNmQwLi5mNDY0ZWIwZTA1 ZGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19wbGFuZS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19wbGFuZS5jCj4gQEAgLTksNiArOSw3IEBACj4g ICNpbmNsdWRlICJ2a21zX2Rydi5oIgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9wbGFuZV9oZWxwZXIu aD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljX2hlbHBlci5oPgo+ICsjaW5jbHVkZSA8ZHJt L2RybV9nZW1fZnJhbWVidWZmZXJfaGVscGVyLmg+Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0 IGRybV9wbGFuZV9mdW5jcyB2a21zX3BsYW5lX2Z1bmNzID0gewo+ICAJLnVwZGF0ZV9wbGFuZQkJ PSBkcm1fYXRvbWljX2hlbHBlcl91cGRhdGVfcGxhbmUsCj4gQEAgLTMwLDkgKzMxLDQ5IEBAIHN0 YXRpYyB2b2lkIHZrbXNfcHJpbWFyeV9wbGFuZV91cGRhdGUoc3RydWN0IGRybV9wbGFuZSAqcGxh bmUsCj4gIHsKPiAgfQo+ICAKPiArc3RhdGljIGludCB2a21zX3ByZXBhcmVfZmIoc3RydWN0IGRy bV9wbGFuZSAqcGxhbmUsCj4gKwkJCSAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ ICt7Cj4gKwlzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKmdlbV9vYmo7Cj4gKwlzdHJ1Y3Qgdmttc19n ZW1fb2JqZWN0ICp2a21zX29iajsKPiArCj4gKwlpZiAoIXN0YXRlLT5mYikKPiArCQlyZXR1cm4g MDsKPiArCj4gKwlnZW1fb2JqID0gZHJtX2dlbV9mYl9nZXRfb2JqKHN0YXRlLT5mYiwgMCk7Cj4g Kwl2a21zX29iaiA9IGNvbnRhaW5lcl9vZihnZW1fb2JqLCBzdHJ1Y3Qgdmttc19nZW1fb2JqZWN0 LCBnZW0pOwo+ICsJdmttc19vYmotPnZhZGRyID0gdmttc19nZW1fdm1hcChnZW1fb2JqKTsKPiAr Cj4gKwlpZiAoIXZrbXNfb2JqLT52YWRkcikKPiArCQlEUk1fSU5GTygidm1hcCBmYWlsZWRcbiIp Owo+ICsKPiArCXJldHVybiBkcm1fZ2VtX2ZiX3ByZXBhcmVfZmIocGxhbmUsIHN0YXRlKTsKPiAr fQo+ICsKPiArc3RhdGljIHZvaWQgdmttc19jbGVhbnVwX2ZiKHN0cnVjdCBkcm1fcGxhbmUgKnBs YW5lLAo+ICsJCQkgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqb2xkX3N0YXRlKQo+ICt7Cj4g KwlzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKmdlbV9vYmo7Cj4gKwlzdHJ1Y3Qgdmttc19nZW1fb2Jq ZWN0ICp2a21zX29iajsKPiArCj4gKwlpZiAoIW9sZF9zdGF0ZS0+ZmIpCj4gKwkJcmV0dXJuOwo+ ICsKPiArCWdlbV9vYmogPSBkcm1fZ2VtX2ZiX2dldF9vYmoob2xkX3N0YXRlLT5mYiwgMCk7Cj4g Kwl2a21zX29iaiA9IGNvbnRhaW5lcl9vZihnZW1fb2JqLCBzdHJ1Y3Qgdmttc19nZW1fb2JqZWN0 LCBnZW0pOwo+ICsKPiArCWlmICh2a21zX29iaiAmJiB2a21zX29iai0+cGFnZXMpIHsKPiArCQl2 dW5tYXAodmttc19vYmotPnZhZGRyKTsKClBsZWFzZSBhbHNvIGNsZWFyIG9iai0+dmFkZHIgaGVy ZS4KCj4gKwkJZHJtX2dlbV9wdXRfcGFnZXMoZ2VtX29iaiwgdmttc19vYmotPnBhZ2VzLCBmYWxz ZSwgdHJ1ZSk7Cj4gKwkJdmttc19vYmotPnBhZ2VzID0gTlVMTDsKCkkgdGhpbmsgaXQnZCBiZSBn b29kIHRvIGFsc28gaGF2ZSBhIHZrbXNfZ2VtX3Z1bm1hcCBoZWxwZXIgZm9yIHRoaXMsIGZvcgpz eW1tZXRyeSBhbmQgcHJldHRpZXIgY29kZS4KClRoZXJlJ3MgYW5vdGhlciBpc3N1ZTogY2xlYW51 cC9wcmVwYXJlX2ZiIGNhbiBiZSBjYWxsZWQgbXVsdGlwbGUgdGltZXMgb24KdGhlIHNhbWUgZmIu IFRoaXMgZG9lc24ndCByZWFsbHkgaGFwcGVuIGZvciB0aGUgY3VycmVudCB2a21zIGNhc2Ugd2hl cmUgd2UKb25seSBoYXZlIDEgcGxhbmUsIGJ1dCBpZiB5b3UgaGF2ZSBtb3JlIHRoYW4gb25lIHBs YW5lIHlvdSBjYW4gYXR0YWNoIHRoZQpzYW1lIGZiIHRvIGFsbCBvZiB0aGVtLiBUaGlzIG1lYW5z IHdlIG5lZWQgYSB2bWFwIGNvdW50ZXIgKHByb2JhYmx5IGJlc3QKcHV0IGludG8gdGhlIHZrbXNf Z2VtX3YodW4pbWFwIGZ1bmN0aW9ucyksIGFuZCBvbmx5IGNyZWF0ZSB0aGUgYWN0dWFsIHZtYXAK d2hlbiB0aGUgY291bnRlciBnb2VzIGZyb20gMCAtPiAxLCBhbmQgcmVsZWFzZSBpdCBvbmx5IHdo ZW4gaXQgZ29lcyBkb3duCnRvIDAgZmluYWxseS4gVXN1YWxseSBpdCdzIGNhbGxlZCB2bWFwX3Vz ZV9jb3VudCBvciBzby4KCk9mYyB0aGF0IG5lZWRzIHRvIGJlIHByb3RlY3RlZCBieSB0aGUgYnVm ZmVyIGxvY2ssIHNvIHlvdSBuZWVkIHRvIHJld29yawp5b3VyIGxvY2tpbmcgYSBiaXQgYW5kIHB1 bGwgaXQgb3V0IGludG8gdGhlIHZtYXAvdnVubWFwIGZ1bmN0aW9ucy4KCkNoZWVycywgRGFuaWVs Cgo+ICsJfQo+ICt9Cj4gKwo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9oZWxwZXJf ZnVuY3Mgdmttc19wcmltYXJ5X2hlbHBlcl9mdW5jcyA9IHsKPiAgCS5hdG9taWNfY2hlY2sJCT0g dmttc19wbGFuZV9hdG9taWNfY2hlY2ssCj4gIAkuYXRvbWljX3VwZGF0ZQkJPSB2a21zX3ByaW1h cnlfcGxhbmVfdXBkYXRlLAo+ICsJLnByZXBhcmVfZmIJCT0gdmttc19wcmVwYXJlX2ZiLAo+ICsJ LmNsZWFudXBfZmIJCT0gdmttc19jbGVhbnVwX2ZiLAo+ICB9Owo+ICAKPiAgc3RydWN0IGRybV9w bGFuZSAqdmttc19wbGFuZV9pbml0KHN0cnVjdCB2a21zX2RldmljZSAqdmttc2RldikKPiAtLSAK PiAyLjE3LjEKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK