From: Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: airlied@linux.ie, liviu.dudau@arm.com,
dri-devel@lists.freedesktop.org, nd@arm.com
Subject: Re: [PATCH] drm/probe-helper: Fix modes reporting for writeback connector
Date: Thu, 12 Jul 2018 10:20:35 +0100 [thread overview]
Message-ID: <20180712092035.GA22153@e114479-lin.cambridge.arm.com> (raw)
In-Reply-To: <20180712085547.GK3008@phenom.ffwll.local>
On Thu, Jul 12, 2018 at 10:55:47AM +0200, Daniel Vetter wrote:
> On Thu, Jul 12, 2018 at 09:48:02AM +0100, Alexandru Gheorghe wrote:
> > Writeback connector is reported as disconnected, currently this causes
> > the setting of the edid property to null and then exit.
> > In order to properly get the modes for writeback we need to add an
> > exception when connector type is DRM_MODE_CONNECTOR_WRITEBACK.
> >
> > Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
>
> Why do you even need a mode list for writeback?
It's used by userspace to know how big the writeback buffer could be.
>
> Also, if you're already faking a mode list for the writeback connector,
> why can't you also fake it's connection status?
> -Daniel
AFAIK Reporting it as disconnected was a way of making sure it will be
ignored by userspace that's not aware of writeback connectorsa. Do you
think it's superfluous with DRM_CLIENT_CAP_WRITEBACK_CONNECTORS ?
>
> > ---
> > drivers/gpu/drm/drm_probe_helper.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
> > index 52774339..c7bdbe2 100644
> > --- a/drivers/gpu/drm/drm_probe_helper.c
> > +++ b/drivers/gpu/drm/drm_probe_helper.c
> > @@ -472,7 +472,8 @@ int drm_helper_probe_single_connector_modes(struct drm_connector *connector,
> >
> > dev->mode_config.poll_running = drm_kms_helper_poll;
> >
> > - if (connector->status == connector_status_disconnected) {
> > + if (connector->status == connector_status_disconnected &&
> > + connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK) {
> > DRM_DEBUG_KMS("[CONNECTOR:%d:%s] disconnected\n",
> > connector->base.id, connector->name);
> > drm_mode_connector_update_edid_property(connector, NULL);
> > --
> > 2.7.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Cheers,
Alex G
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-12 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 8:48 [PATCH] drm/probe-helper: Fix modes reporting for writeback connector Alexandru Gheorghe
2018-07-12 8:55 ` Daniel Vetter
2018-07-12 9:20 ` Alexandru-Cosmin Gheorghe [this message]
2018-07-12 13:08 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712092035.GA22153@e114479-lin.cambridge.arm.com \
--to=alexandru-cosmin.gheorghe@arm.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=liviu.dudau@arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox